Re: [PATCH v5 03/11] mtd: get the ECC info from the parameter page for ONFI nand

[Vikram Narayanan <vikram186@gmail.com>]

On 5/15/2013 2:10 PM, Huang Shijie wrote:
>  From the ONFI spec, we can just get the ECC info from the @ecc_bits field of
> the parameter page.

I wonder what do we do, if the chip is not ONFI compliant?
which means when the legacy calculation in GPMI goes wrong?

> Signed-off-by: Huang Shijie <b32955@freescale.com>
> ---
>   drivers/mtd/nand/nand_base.c |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index edc7663..15630ef 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -2900,6 +2900,11 @@ static int nand_flash_detect_onfi(struct mtd_info *mtd, struct nand_chip *chip,
>   	if (le16_to_cpu(p->features) & 1)
>   		*busw = NAND_BUSWIDTH_16;
>
> +	if (p->ecc_bits != 0xff) {
> +		chip->ecc_strength = p->ecc_bits;
> +		chip->ecc_step = 512;
> +	}
> +
>   	pr_info("ONFI flash detected\n");
>   	return 1;
>   }
>