Re: [PATCH] mm, slab: corrected the comment 'kmem_cache_alloc' to 'slab_alloc_node'

[Zhouping Liu <zliu@redhat.com>]

On 05/16/2013 02:10 AM, Pekka Enberg wrote:
> On Wed, May 15, 2013 at 8:10 PM, Zhouping Liu <sanweidaying@gmail.com> wrote:
>> From: Zhouping Liu <zliu@redhat.com>
>>
>> commit 48356303ff(mm, slab: Rename __cache_alloc() -> slab_alloc())
>> forgot to update the comment 'kmem_cache_alloc' to 'slab_alloc_node'.
>>
>> Signed-off-by: Zhouping Liu <zliu@redhat.com>
>> ---
>>   mm/slab.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/slab.c b/mm/slab.c
>> index 8ccd296..8efb5f7 100644
>> --- a/mm/slab.c
>> +++ b/mm/slab.c
>> @@ -3339,7 +3339,7 @@ done:
>>   }
>>
>>   /**
>> - * kmem_cache_alloc_node - Allocate an object on the specified node
>> + * slab_alloc_node - Allocate an object on the specified node
>>    * @cachep: The cache to allocate from.
>>    * @flags: See kmalloc().
>>    * @nodeid: node number of the target node.
> The point of the comment is to document kernel API and whereas
> slab_alloc_node() is internal to the slab allocator. Can you please
> just move it on top of kmem_cache_alloc_node() definition in the same
> file?

OK, thanks for reviewing, please check V2.

Thanks,
Zhouping

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>