From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: aliguori@us.ibm.com, Lei Li <lilei@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, lcapitulino@redhat.com, kraxel@redhat.com,
Amos Kong <akong@redhat.com>,
lersek@redhat.com
Subject: Re: [Qemu-devel] [PATCH] ps2: add support of auto-repeat
Date: Thu, 16 May 2013 17:20:37 +0200 [thread overview]
Message-ID: <5194F945.8040601@redhat.com> (raw)
In-Reply-To: <CAFEAcA9UQ14L5DMbjiUoQYwMHC2jfDJbkC1_+dZqfDz3q4npFQ@mail.gmail.com>
Il 16/05/2013 17:17, Peter Maydell ha scritto:
> On 16 May 2013 16:09, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> ... In XWindows, you get a KeyRelease for every KeyPress Event. In X,
>> it looks something like this:
>>
>> PRPRPRPRPRPRPRPR
>
> Shouldn't we be abstracting this platform difference
> out in the ui layer, rather than having to deal with it
> in the ps2 device model? That is, we should define what
> our key-repeat model is for the QEMU keyboard-event-handler
> API, and then make sure all our UI frontends (gtk, sdl,
> cocoa, etc) do what we require...
Yes, I am asking Amos to check which of our frontends comply.
It needs to be checked in the host, because Linux guests emulate
autorepeat anyway. Or you can test with FreeDOS.
Paolo
next prev parent reply other threads:[~2013-05-16 15:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 4:30 [Qemu-devel] [PATCH] ps2: add support of auto-repeat Amos Kong
2013-05-16 5:30 ` li guang
2013-05-16 6:58 ` Amos Kong
2013-05-16 7:13 ` li guang
2013-05-16 7:28 ` Amos Kong
2013-05-16 15:04 ` Paolo Bonzini
2013-05-16 6:40 ` Jason Wang
2013-05-16 6:50 ` Peter Maydell
2013-05-16 7:17 ` Amos Kong
2013-05-16 7:23 ` Lei Li
2013-05-16 7:35 ` Amos Kong
2013-05-16 9:11 ` Lei Li
2013-05-16 20:37 ` Amos Kong
2013-05-16 15:09 ` Paolo Bonzini
2013-05-16 15:17 ` Peter Maydell
2013-05-16 15:20 ` Paolo Bonzini [this message]
2013-05-21 8:33 ` Amos Kong
2013-05-21 8:38 ` Paolo Bonzini
2013-05-21 9:04 ` Amos Kong
2013-05-21 9:51 ` Amos Kong
2013-05-21 9:54 ` Paolo Bonzini
2013-05-16 15:03 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5194F945.8040601@redhat.com \
--to=pbonzini@redhat.com \
--cc=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=lilei@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.