From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: mxs: Use set and clear capabilities of the gpio controller
Date: Thu, 16 May 2013 17:37:44 +0200 [thread overview]
Message-ID: <5194FD48.3010106@free-electrons.com> (raw)
In-Reply-To: <20130502024443.GE3442@S2101-09.ap.freescale.net>
Hi Linus,
Le 02/05/2013 04:44, Shawn Guo a ?crit :
> On Mon, Apr 29, 2013 at 04:07:18PM +0200, Maxime Ripard wrote:
>> The current driver doesn't use the set and clear registers found on the
>> mxs gpio controller.
>>
>> This leads the generic gpio controller to be using some internal value
>> to avoid looking up the value stored in the registers, making it behave
>> pretty much like a cache.
>>
>> This raises some coherency problem when a gpio is not modified by the
>> gpio controller, while it can easily be fixed by using the set and clear
>> registers.
>>
>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
Would you consider merging this patch?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Shawn Guo <shawn.guo@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Grant Likely <grant.likely@secretlab.ca>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: mxs: Use set and clear capabilities of the gpio controller
Date: Thu, 16 May 2013 17:37:44 +0200 [thread overview]
Message-ID: <5194FD48.3010106@free-electrons.com> (raw)
In-Reply-To: <20130502024443.GE3442@S2101-09.ap.freescale.net>
Hi Linus,
Le 02/05/2013 04:44, Shawn Guo a écrit :
> On Mon, Apr 29, 2013 at 04:07:18PM +0200, Maxime Ripard wrote:
>> The current driver doesn't use the set and clear registers found on the
>> mxs gpio controller.
>>
>> This leads the generic gpio controller to be using some internal value
>> to avoid looking up the value stored in the registers, making it behave
>> pretty much like a cache.
>>
>> This raises some coherency problem when a gpio is not modified by the
>> gpio controller, while it can easily be fixed by using the set and clear
>> registers.
>>
>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
Would you consider merging this patch?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-05-16 15:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 14:07 [PATCH] gpio: mxs: Use set and clear capabilities of the gpio controller Maxime Ripard
2013-04-29 14:07 ` Maxime Ripard
2013-05-02 2:44 ` Shawn Guo
2013-05-02 2:44 ` Shawn Guo
2013-05-16 15:37 ` Maxime Ripard [this message]
2013-05-16 15:37 ` Maxime Ripard
2013-05-20 18:15 ` Linus Walleij
2013-05-20 18:15 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5194FD48.3010106@free-electrons.com \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.