From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Venu Byravarasu <vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 7/8] usb: phy: tegra: Add error handling & clean up.
Date: Thu, 16 May 2013 15:08:29 -0600 [thread overview]
Message-ID: <51954ACD.4070101@wwwdotorg.org> (raw)
In-Reply-To: <1368713582-29038-8-git-send-email-vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 05/16/2013 08:13 AM, Venu Byravarasu wrote:
> Check return values from all GPIO APIs and handle errors accordingly.
>
> Remove the call to clk_disable_unprepare(); this function does not
> prepare or enable the clock, so the error path should not disable or
> unprepare it.
>
> Signed-off-by: Venu Byravarasu <vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> delta from v3:
> Modified comment section to indicate 'otg_ulpi_create returned NULL'.
I'm being really anal here, but note this wasn't a change to a comment,
but to the error message printed by the code.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Venu Byravarasu <vbyravarasu@nvidia.com>
Cc: gregkh@linuxfoundation.org, stern@rowland.harvard.edu,
balbi@ti.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v4 7/8] usb: phy: tegra: Add error handling & clean up.
Date: Thu, 16 May 2013 15:08:29 -0600 [thread overview]
Message-ID: <51954ACD.4070101@wwwdotorg.org> (raw)
In-Reply-To: <1368713582-29038-8-git-send-email-vbyravarasu@nvidia.com>
On 05/16/2013 08:13 AM, Venu Byravarasu wrote:
> Check return values from all GPIO APIs and handle errors accordingly.
>
> Remove the call to clk_disable_unprepare(); this function does not
> prepare or enable the clock, so the error path should not disable or
> unprepare it.
>
> Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>
> ---
> delta from v3:
> Modified comment section to indicate 'otg_ulpi_create returned NULL'.
I'm being really anal here, but note this wasn't a change to a comment,
but to the error message printed by the code.
next prev parent reply other threads:[~2013-05-16 21:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 14:12 [PATCH v4 0/8] Tegra USB PHY driver series Venu Byravarasu
2013-05-16 14:12 ` Venu Byravarasu
2013-05-16 14:12 ` [PATCH v4 1/8] ARM: tegra: finalize USB EHCI and PHY bindings Venu Byravarasu
2013-05-16 14:12 ` Venu Byravarasu
2013-05-16 14:12 ` [PATCH v4 2/8] arm: dt: Tegra20: Modify ULPI reset GPIO properties Venu Byravarasu
2013-05-16 14:12 ` Venu Byravarasu
[not found] ` <1368713582-29038-1-git-send-email-vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-16 14:12 ` [PATCH v4 3/8] ARM: tegra: update device trees for USB binding rework Venu Byravarasu
2013-05-16 14:12 ` Venu Byravarasu
2013-05-16 23:02 ` Stephen Warren
[not found] ` <51956574.5070206-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-05-17 22:06 ` Stephen Warren
2013-05-17 22:06 ` Stephen Warren
2013-05-16 14:12 ` [PATCH v4 4/8] usb: phy: tegra: Return correct error value provided by clk_get_sys Venu Byravarasu
2013-05-16 14:12 ` Venu Byravarasu
2013-05-16 14:13 ` [PATCH v4 6/8] usb: phy: tegra: get ULPI reset GPIO info using DT Venu Byravarasu
2013-05-16 14:13 ` Venu Byravarasu
2013-05-16 14:13 ` [PATCH v4 8/8] usb: phy: registering Tegra USB PHY as platform driver Venu Byravarasu
2013-05-16 14:13 ` Venu Byravarasu
2013-05-16 14:12 ` [PATCH v4 5/8] usb: phy: tegra: Get PHY mode using DT Venu Byravarasu
2013-05-16 14:12 ` Venu Byravarasu
2013-05-16 14:13 ` [PATCH v4 7/8] usb: phy: tegra: Add error handling & clean up Venu Byravarasu
2013-05-16 14:13 ` Venu Byravarasu
[not found] ` <1368713582-29038-8-git-send-email-vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-16 21:08 ` Stephen Warren [this message]
2013-05-16 21:08 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51954ACD.4070101@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.