From: "Andreas Färber" <afaerber@suse.de>
To: Anthony Green <green@moxielogic.com>
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Hu Tao <hutao@cn.fujitsu.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-moxie: replace target_phys_addr_t with hwaddr
Date: Fri, 17 May 2013 10:26:21 +0200 [thread overview]
Message-ID: <5195E9AD.7040509@suse.de> (raw)
In-Reply-To: <CAFEAcA-vp5bPwmAZj3a6HH71XkZJizQNSSTbFdrSOU60QWZRGw@mail.gmail.com>
Anthony G.,
Am 15.05.2013 10:23, schrieb Peter Maydell:
> On 15 May 2013 07:04, Hu Tao <hutao@cn.fujitsu.com> wrote:
>> target_phys_addr_t has been already replaced by hwaddr, but this
>> one is introduced after.
>>
>> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> This doesn't cause compile errors because it's in a bit
> of code that can never get compiled (it's inside a
> CONFIG_USER_ONLY block but there is no moxie-linux-user
> target in configure).
A similar issue had come up before and I don't remember seeing a clear
answer:
Are you planning to actually implement moxie-linux-user and enable it by
default, so that we can catch any errors? Or should we rather drop any
such unused CONFIG_USER_ONLY code from target-moxie?
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Anthony Green <green@moxielogic.com>
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Hu Tao <hutao@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH] target-moxie: replace target_phys_addr_t with hwaddr
Date: Fri, 17 May 2013 10:26:21 +0200 [thread overview]
Message-ID: <5195E9AD.7040509@suse.de> (raw)
In-Reply-To: <CAFEAcA-vp5bPwmAZj3a6HH71XkZJizQNSSTbFdrSOU60QWZRGw@mail.gmail.com>
Anthony G.,
Am 15.05.2013 10:23, schrieb Peter Maydell:
> On 15 May 2013 07:04, Hu Tao <hutao@cn.fujitsu.com> wrote:
>> target_phys_addr_t has been already replaced by hwaddr, but this
>> one is introduced after.
>>
>> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> This doesn't cause compile errors because it's in a bit
> of code that can never get compiled (it's inside a
> CONFIG_USER_ONLY block but there is no moxie-linux-user
> target in configure).
A similar issue had come up before and I don't remember seeing a clear
answer:
Are you planning to actually implement moxie-linux-user and enable it by
default, so that we can catch any errors? Or should we rather drop any
such unused CONFIG_USER_ONLY code from target-moxie?
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-05-17 8:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 6:04 [Qemu-trivial] [PATCH] target-moxie: replace target_phys_addr_t with hwaddr Hu Tao
2013-05-15 6:04 ` [Qemu-devel] " Hu Tao
2013-05-15 8:23 ` [Qemu-trivial] " Peter Maydell
2013-05-15 8:23 ` Peter Maydell
2013-05-17 8:26 ` Andreas Färber [this message]
2013-05-17 8:26 ` Andreas Färber
2013-05-18 11:28 ` [Qemu-trivial] " Michael Tokarev
2013-05-18 11:28 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5195E9AD.7040509@suse.de \
--to=afaerber@suse.de \
--cc=green@moxielogic.com \
--cc=hutao@cn.fujitsu.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.