All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Wu <josh.wu@atmel.com>
To: <dedekind1@gmail.com>
Cc: plagnioj@jcrosoft.com, linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, nicolas.ferre@atmel.com
Subject: Re: [PATCH 0/4] mtd: atmel_nand: enable Nand Flash Controller (NFC) support
Date: Fri, 17 May 2013 17:58:48 +0800	[thread overview]
Message-ID: <5195FF58.4070909@atmel.com> (raw)
In-Reply-To: <1368696748.15764.184.camel@sauron.fi.intel.com>

Hi, Artem

On 5/16/2013 5:32 PM, Artem Bityutskiy wrote:
> On Tue, 2013-04-23 at 18:29 +0800, Josh Wu wrote:
>> This patch series enable NFC support for SAMA5 soc. It can send command,
>> address cycles automaticly. Also when enable NFC sram, NFC will transfer
>> data to sram. Which can save lots of cpu time.
>>
>> Josh Wu (4):
>>    mtd: atmel_nand: replace pmecc enable code with one function.
>>    mtd: atmel_nand: add Nand Flash Controller (NFC) support
>>    mtd: atmel_nand: enable Nand Flash Controller (NFC) read data
>>      via sram
>>    mtd: atmel_nand: enable Nand Flash Controller (NFC) write via
>>      sram
> Please, re-base against the latest l2-mtd.git tree. The patches do not
> compile:

I've sent out the v2 version which is rebased on the latest l2-mtd.git 
tree. It fixed the compiler error and imcompatible parameters of the 
write_page().
Thanks for point out.

Best Regards,
Josh Wu

> --------------------------------------------------------------------------------
> Failed to build the following commit for configuration "arm-at91cap9_defconfig" (architecture arm)":
>
> 2bd4bff mtd: atmel_nand: enable Nand Flash Controller (NFC) write via sram
>
> drivers/mtd/nand/atmel_nand.c: In function 'nfc_nand_command':
> drivers/mtd/nand/atmel_nand.c:1848: error: 'NAND_CMD_DEPLETE1' undeclared (first use in this function)
> drivers/mtd/nand/atmel_nand.c:1848: error: (Each undeclared identifier is reported only once
> drivers/mtd/nand/atmel_nand.c:1848: error: for each function it appears in.)
> drivers/mtd/nand/atmel_nand.c:1854: error: 'NAND_CMD_STATUS_ERROR' undeclared (first use in this function)
> drivers/mtd/nand/atmel_nand.c:1855: error: 'NAND_CMD_STATUS_ERROR0' undeclared (first use in this function)
> drivers/mtd/nand/atmel_nand.c:1856: error: 'NAND_CMD_STATUS_ERROR1' undeclared (first use in this function)
> drivers/mtd/nand/atmel_nand.c:1857: error: 'NAND_CMD_STATUS_ERROR2' undeclared (first use in this function)
> drivers/mtd/nand/atmel_nand.c:1858: error: 'NAND_CMD_STATUS_ERROR3' undeclared (first use in this function)
> drivers/mtd/nand/atmel_nand.c: In function 'nfc_sram_init':
> drivers/mtd/nand/atmel_nand.c:1979: warning: assignment from incompatible pointer type
> make[4]: *** [drivers/mtd/nand/atmel_nand.o] Error 1
>

WARNING: multiple messages have this Message-ID (diff)
From: josh.wu@atmel.com (Josh Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] mtd: atmel_nand: enable Nand Flash Controller (NFC) support
Date: Fri, 17 May 2013 17:58:48 +0800	[thread overview]
Message-ID: <5195FF58.4070909@atmel.com> (raw)
In-Reply-To: <1368696748.15764.184.camel@sauron.fi.intel.com>

Hi, Artem

On 5/16/2013 5:32 PM, Artem Bityutskiy wrote:
> On Tue, 2013-04-23 at 18:29 +0800, Josh Wu wrote:
>> This patch series enable NFC support for SAMA5 soc. It can send command,
>> address cycles automaticly. Also when enable NFC sram, NFC will transfer
>> data to sram. Which can save lots of cpu time.
>>
>> Josh Wu (4):
>>    mtd: atmel_nand: replace pmecc enable code with one function.
>>    mtd: atmel_nand: add Nand Flash Controller (NFC) support
>>    mtd: atmel_nand: enable Nand Flash Controller (NFC) read data
>>      via sram
>>    mtd: atmel_nand: enable Nand Flash Controller (NFC) write via
>>      sram
> Please, re-base against the latest l2-mtd.git tree. The patches do not
> compile:

I've sent out the v2 version which is rebased on the latest l2-mtd.git 
tree. It fixed the compiler error and imcompatible parameters of the 
write_page().
Thanks for point out.

Best Regards,
Josh Wu

> --------------------------------------------------------------------------------
> Failed to build the following commit for configuration "arm-at91cap9_defconfig" (architecture arm)":
>
> 2bd4bff mtd: atmel_nand: enable Nand Flash Controller (NFC) write via sram
>
> drivers/mtd/nand/atmel_nand.c: In function 'nfc_nand_command':
> drivers/mtd/nand/atmel_nand.c:1848: error: 'NAND_CMD_DEPLETE1' undeclared (first use in this function)
> drivers/mtd/nand/atmel_nand.c:1848: error: (Each undeclared identifier is reported only once
> drivers/mtd/nand/atmel_nand.c:1848: error: for each function it appears in.)
> drivers/mtd/nand/atmel_nand.c:1854: error: 'NAND_CMD_STATUS_ERROR' undeclared (first use in this function)
> drivers/mtd/nand/atmel_nand.c:1855: error: 'NAND_CMD_STATUS_ERROR0' undeclared (first use in this function)
> drivers/mtd/nand/atmel_nand.c:1856: error: 'NAND_CMD_STATUS_ERROR1' undeclared (first use in this function)
> drivers/mtd/nand/atmel_nand.c:1857: error: 'NAND_CMD_STATUS_ERROR2' undeclared (first use in this function)
> drivers/mtd/nand/atmel_nand.c:1858: error: 'NAND_CMD_STATUS_ERROR3' undeclared (first use in this function)
> drivers/mtd/nand/atmel_nand.c: In function 'nfc_sram_init':
> drivers/mtd/nand/atmel_nand.c:1979: warning: assignment from incompatible pointer type
> make[4]: *** [drivers/mtd/nand/atmel_nand.o] Error 1
>

  reply	other threads:[~2013-05-17  9:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-23 10:29 [PATCH 0/4] mtd: atmel_nand: enable Nand Flash Controller (NFC) support Josh Wu
2013-04-23 10:29 ` Josh Wu
2013-04-23 10:29 ` [PATCH 1/4] mtd: atmel_nand: replace pmecc enable code with one function Josh Wu
2013-04-23 10:29   ` Josh Wu
2013-04-23 10:29 ` [PATCH 2/4] mtd: atmel_nand: add Nand Flash Controller (NFC) support Josh Wu
2013-04-23 10:29   ` Josh Wu
2013-04-23 10:29 ` [PATCH 3/4] mtd: atmel_nand: enable Nand Flash Controller (NFC) read data via sram Josh Wu
2013-04-23 10:29   ` Josh Wu
2013-04-23 10:29 ` [PATCH 4/4] mtd: atmel_nand: enable Nand Flash Controller (NFC) write " Josh Wu
2013-04-23 10:29   ` Josh Wu
2013-05-16  9:32 ` [PATCH 0/4] mtd: atmel_nand: enable Nand Flash Controller (NFC) support Artem Bityutskiy
2013-05-16  9:32   ` Artem Bityutskiy
2013-05-17  9:58   ` Josh Wu [this message]
2013-05-17  9:58     ` Josh Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5195FF58.4070909@atmel.com \
    --to=josh.wu@atmel.com \
    --cc=dedekind1@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.