From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: "Keir (Xen.org)" <keir@xen.org>, Jan Beulich <JBeulich@suse.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] xen/makefile: Allow XEN_CHANGESET to be set externally
Date: Fri, 17 May 2013 15:41:58 +0100 [thread overview]
Message-ID: <519641B6.5030602@citrix.com> (raw)
In-Reply-To: <20130517143233.GA18796@aepfle.de>
On 17/05/2013 15:32, Olaf Hering wrote:
> On Fri, May 17, Andrew Cooper wrote:
>
>> Build systems based on tarballs rather than source code trees, such as
>> rpms/debs are unable to obtain changeset infomation.
>>
>> Allow XEN_CHANGESET to be optionally specified in the environment.
> Isnt that already possible with 'echo "$XEN_CHANGESET" > .scmversion'?
>
> Olaf
No - that results in the literal string "$XEN_CHANGESET"
I have however identified a bug with the way in which
xen/tools/scmversion deals with git. Patch on the way.
~Andrew
next prev parent reply other threads:[~2013-05-17 14:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 13:21 [PATCH] xen/makefile: Allow XEN_CHANGESET to be set externally Andrew Cooper
2013-05-17 14:32 ` Olaf Hering
2013-05-17 14:41 ` Andrew Cooper [this message]
2013-05-17 17:04 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519641B6.5030602@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.