* [PATCH 0/1] posix timers: Expand exitsting info in proc file @ 2013-05-16 22:12 ` Pavel Tikhomirov 0 siblings, 0 replies; 12+ messages in thread From: Pavel Tikhomirov @ 2013-05-16 22:12 UTC (permalink / raw) To: Thomas Gleixner Cc: Ingo Molnar, Michael Kerrisk, Matthew Helsley, linux-api-u79uwXL29TY76Z2rM5mHXA, Linux Kernel Mailing List, Pavel Emelyanov, Pavel Tikhomirov Hi. I'm working on the checkpoint-restore project (http://criu.org), on realisation of posix-timers. To compleatly checkpoint and restore these timers we need to know which clock they are using. So I d'like to add this information to existing syscall which shows posix-timers info. Pavel Tikhomirov (1): posix-timers: Show clock ID in proc file fs/proc/base.c | 1 + 1 file changed, 1 insertion(+) -- 1.7.9.5 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/1] posix timers: Expand exitsting info in proc file @ 2013-05-16 22:12 ` Pavel Tikhomirov 0 siblings, 0 replies; 12+ messages in thread From: Pavel Tikhomirov @ 2013-05-16 22:12 UTC (permalink / raw) To: Thomas Gleixner Cc: Ingo Molnar, Michael Kerrisk, Matthew Helsley, linux-api, Linux Kernel Mailing List, Pavel Emelyanov, Pavel Tikhomirov Hi. I'm working on the checkpoint-restore project (http://criu.org), on realisation of posix-timers. To compleatly checkpoint and restore these timers we need to know which clock they are using. So I d'like to add this information to existing syscall which shows posix-timers info. Pavel Tikhomirov (1): posix-timers: Show clock ID in proc file fs/proc/base.c | 1 + 1 file changed, 1 insertion(+) -- 1.7.9.5 ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <1368742323-46949-1-git-send-email-snorcht-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* [PATCH 1/1] posix-timers: Show clock ID in proc file 2013-05-16 22:12 ` Pavel Tikhomirov @ 2013-05-16 22:12 ` Pavel Tikhomirov -1 siblings, 0 replies; 12+ messages in thread From: Pavel Tikhomirov @ 2013-05-16 22:12 UTC (permalink / raw) To: Thomas Gleixner Cc: Ingo Molnar, Michael Kerrisk, Matthew Helsley, linux-api-u79uwXL29TY76Z2rM5mHXA, Linux Kernel Mailing List, Pavel Emelyanov, Pavel Tikhomirov Expand information about posix-timers in /proc/<pid>/timers by adding info about clock, with which the timer was created. I.e. in the forth line of timer info after "notify:" line go "ClockID: <clock_id>". Signed-off-by: Pavel Tikhomirov <snorcht-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- fs/proc/base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/proc/base.c b/fs/proc/base.c index 2dad4a9..8a38eef 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -2079,6 +2079,7 @@ static int show_timer(struct seq_file *m, void *v) nstr[notify & ~SIGEV_THREAD_ID], (notify & SIGEV_THREAD_ID) ? "tid" : "pid", pid_nr_ns(timer->it_pid, tp->ns)); + seq_printf(m, "ClockID: %d\n", timer->it_clock); return 0; } -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/1] posix-timers: Show clock ID in proc file @ 2013-05-16 22:12 ` Pavel Tikhomirov 0 siblings, 0 replies; 12+ messages in thread From: Pavel Tikhomirov @ 2013-05-16 22:12 UTC (permalink / raw) To: Thomas Gleixner Cc: Ingo Molnar, Michael Kerrisk, Matthew Helsley, linux-api, Linux Kernel Mailing List, Pavel Emelyanov, Pavel Tikhomirov Expand information about posix-timers in /proc/<pid>/timers by adding info about clock, with which the timer was created. I.e. in the forth line of timer info after "notify:" line go "ClockID: <clock_id>". Signed-off-by: Pavel Tikhomirov <snorcht@gmail.com> --- fs/proc/base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/proc/base.c b/fs/proc/base.c index 2dad4a9..8a38eef 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -2079,6 +2079,7 @@ static int show_timer(struct seq_file *m, void *v) nstr[notify & ~SIGEV_THREAD_ID], (notify & SIGEV_THREAD_ID) ? "tid" : "pid", pid_nr_ns(timer->it_pid, tp->ns)); + seq_printf(m, "ClockID: %d\n", timer->it_clock); return 0; } -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 12+ messages in thread
[parent not found: <1368742323-46949-2-git-send-email-snorcht-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 1/1] posix-timers: Show clock ID in proc file 2013-05-16 22:12 ` Pavel Tikhomirov @ 2013-05-17 15:59 ` Greg KH -1 siblings, 0 replies; 12+ messages in thread From: Greg KH @ 2013-05-17 15:59 UTC (permalink / raw) To: Pavel Tikhomirov Cc: Thomas Gleixner, Ingo Molnar, Michael Kerrisk, Matthew Helsley, linux-api-u79uwXL29TY76Z2rM5mHXA, Linux Kernel Mailing List, Pavel Emelyanov On Fri, May 17, 2013 at 02:12:03AM +0400, Pavel Tikhomirov wrote: > Expand information about posix-timers in /proc/<pid>/timers by adding > info about clock, with which the timer was created. I.e. in the forth > line of timer info after "notify:" line go "ClockID: <clock_id>". > > Signed-off-by: Pavel Tikhomirov <snorcht-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > fs/proc/base.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/proc/base.c b/fs/proc/base.c > index 2dad4a9..8a38eef 100644 > --- a/fs/proc/base.c > +++ b/fs/proc/base.c > @@ -2079,6 +2079,7 @@ static int show_timer(struct seq_file *m, void *v) > nstr[notify & ~SIGEV_THREAD_ID], > (notify & SIGEV_THREAD_ID) ? "tid" : "pid", > pid_nr_ns(timer->it_pid, tp->ns)); > + seq_printf(m, "ClockID: %d\n", timer->it_clock); What userspace tool just broke by adding a new field to this file? thanks, greg k-h ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] posix-timers: Show clock ID in proc file @ 2013-05-17 15:59 ` Greg KH 0 siblings, 0 replies; 12+ messages in thread From: Greg KH @ 2013-05-17 15:59 UTC (permalink / raw) To: Pavel Tikhomirov Cc: Thomas Gleixner, Ingo Molnar, Michael Kerrisk, Matthew Helsley, linux-api, Linux Kernel Mailing List, Pavel Emelyanov On Fri, May 17, 2013 at 02:12:03AM +0400, Pavel Tikhomirov wrote: > Expand information about posix-timers in /proc/<pid>/timers by adding > info about clock, with which the timer was created. I.e. in the forth > line of timer info after "notify:" line go "ClockID: <clock_id>". > > Signed-off-by: Pavel Tikhomirov <snorcht@gmail.com> > --- > fs/proc/base.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/proc/base.c b/fs/proc/base.c > index 2dad4a9..8a38eef 100644 > --- a/fs/proc/base.c > +++ b/fs/proc/base.c > @@ -2079,6 +2079,7 @@ static int show_timer(struct seq_file *m, void *v) > nstr[notify & ~SIGEV_THREAD_ID], > (notify & SIGEV_THREAD_ID) ? "tid" : "pid", > pid_nr_ns(timer->it_pid, tp->ns)); > + seq_printf(m, "ClockID: %d\n", timer->it_clock); What userspace tool just broke by adding a new field to this file? thanks, greg k-h ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] posix-timers: Show clock ID in proc file 2013-05-17 15:59 ` Greg KH (?) @ 2013-05-17 16:12 ` Pavel Emelyanov [not found] ` <51965707.5010305-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> -1 siblings, 1 reply; 12+ messages in thread From: Pavel Emelyanov @ 2013-05-17 16:12 UTC (permalink / raw) To: Greg KH Cc: Pavel Tikhomirov, Thomas Gleixner, Ingo Molnar, Michael Kerrisk, Matthew Helsley, linux-api, Linux Kernel Mailing List On 05/17/2013 07:59 PM, Greg KH wrote: > On Fri, May 17, 2013 at 02:12:03AM +0400, Pavel Tikhomirov wrote: >> Expand information about posix-timers in /proc/<pid>/timers by adding >> info about clock, with which the timer was created. I.e. in the forth >> line of timer info after "notify:" line go "ClockID: <clock_id>". >> >> Signed-off-by: Pavel Tikhomirov <snorcht@gmail.com> >> --- >> fs/proc/base.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/fs/proc/base.c b/fs/proc/base.c >> index 2dad4a9..8a38eef 100644 >> --- a/fs/proc/base.c >> +++ b/fs/proc/base.c >> @@ -2079,6 +2079,7 @@ static int show_timer(struct seq_file *m, void *v) >> nstr[notify & ~SIGEV_THREAD_ID], >> (notify & SIGEV_THREAD_ID) ? "tid" : "pid", >> pid_nr_ns(timer->it_pid, tp->ns)); >> + seq_printf(m, "ClockID: %d\n", timer->it_clock); > > What userspace tool just broke by adding a new field to this file? Zero for two reasons: 1. this proc file appeared this merge window 2. this file format is <name>: <value> and should be parsed line-by-line by applications like e.g. /proc/pid/status or /proc/pid/smaps. Both these files were extended with fields in the past with no worries to tools, so should be this new one. > thanks, > > greg k-h > . > Thanks, Pavel ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <51965707.5010305-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>]
* Re: [PATCH 1/1] posix-timers: Show clock ID in proc file 2013-05-17 16:12 ` Pavel Emelyanov @ 2013-05-17 16:22 ` Greg KH 0 siblings, 0 replies; 12+ messages in thread From: Greg KH @ 2013-05-17 16:22 UTC (permalink / raw) To: Pavel Emelyanov Cc: Pavel Tikhomirov, Thomas Gleixner, Ingo Molnar, Michael Kerrisk, Matthew Helsley, linux-api-u79uwXL29TY76Z2rM5mHXA, Linux Kernel Mailing List On Fri, May 17, 2013 at 08:12:55PM +0400, Pavel Emelyanov wrote: > On 05/17/2013 07:59 PM, Greg KH wrote: > > On Fri, May 17, 2013 at 02:12:03AM +0400, Pavel Tikhomirov wrote: > >> Expand information about posix-timers in /proc/<pid>/timers by adding > >> info about clock, with which the timer was created. I.e. in the forth > >> line of timer info after "notify:" line go "ClockID: <clock_id>". > >> > >> Signed-off-by: Pavel Tikhomirov <snorcht-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > >> --- > >> fs/proc/base.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/fs/proc/base.c b/fs/proc/base.c > >> index 2dad4a9..8a38eef 100644 > >> --- a/fs/proc/base.c > >> +++ b/fs/proc/base.c > >> @@ -2079,6 +2079,7 @@ static int show_timer(struct seq_file *m, void *v) > >> nstr[notify & ~SIGEV_THREAD_ID], > >> (notify & SIGEV_THREAD_ID) ? "tid" : "pid", > >> pid_nr_ns(timer->it_pid, tp->ns)); > >> + seq_printf(m, "ClockID: %d\n", timer->it_clock); > > > > What userspace tool just broke by adding a new field to this file? > > Zero for two reasons: > > 1. this proc file appeared this merge window > 2. this file format is > > <name>: <value> > > and should be parsed line-by-line by applications like e.g. /proc/pid/status > or /proc/pid/smaps. Both these files were extended with fields in the past with > no worries to tools, so should be this new one. Ok, just making sure :) ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] posix-timers: Show clock ID in proc file @ 2013-05-17 16:22 ` Greg KH 0 siblings, 0 replies; 12+ messages in thread From: Greg KH @ 2013-05-17 16:22 UTC (permalink / raw) To: Pavel Emelyanov Cc: Pavel Tikhomirov, Thomas Gleixner, Ingo Molnar, Michael Kerrisk, Matthew Helsley, linux-api, Linux Kernel Mailing List On Fri, May 17, 2013 at 08:12:55PM +0400, Pavel Emelyanov wrote: > On 05/17/2013 07:59 PM, Greg KH wrote: > > On Fri, May 17, 2013 at 02:12:03AM +0400, Pavel Tikhomirov wrote: > >> Expand information about posix-timers in /proc/<pid>/timers by adding > >> info about clock, with which the timer was created. I.e. in the forth > >> line of timer info after "notify:" line go "ClockID: <clock_id>". > >> > >> Signed-off-by: Pavel Tikhomirov <snorcht@gmail.com> > >> --- > >> fs/proc/base.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/fs/proc/base.c b/fs/proc/base.c > >> index 2dad4a9..8a38eef 100644 > >> --- a/fs/proc/base.c > >> +++ b/fs/proc/base.c > >> @@ -2079,6 +2079,7 @@ static int show_timer(struct seq_file *m, void *v) > >> nstr[notify & ~SIGEV_THREAD_ID], > >> (notify & SIGEV_THREAD_ID) ? "tid" : "pid", > >> pid_nr_ns(timer->it_pid, tp->ns)); > >> + seq_printf(m, "ClockID: %d\n", timer->it_clock); > > > > What userspace tool just broke by adding a new field to this file? > > Zero for two reasons: > > 1. this proc file appeared this merge window > 2. this file format is > > <name>: <value> > > and should be parsed line-by-line by applications like e.g. /proc/pid/status > or /proc/pid/smaps. Both these files were extended with fields in the past with > no worries to tools, so should be this new one. Ok, just making sure :) ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] posix-timers: Show clock ID in proc file 2013-05-16 22:12 ` Pavel Tikhomirov @ 2013-05-17 16:10 ` Pavel Emelyanov -1 siblings, 0 replies; 12+ messages in thread From: Pavel Emelyanov @ 2013-05-17 16:10 UTC (permalink / raw) To: Thomas Gleixner Cc: Pavel Tikhomirov, Ingo Molnar, Michael Kerrisk, Matthew Helsley, linux-api-u79uwXL29TY76Z2rM5mHXA, Linux Kernel Mailing List On 05/17/2013 02:12 AM, Pavel Tikhomirov wrote: > Expand information about posix-timers in /proc/<pid>/timers by adding > info about clock, with which the timer was created. I.e. in the forth > line of timer info after "notify:" line go "ClockID: <clock_id>". > > Signed-off-by: Pavel Tikhomirov <snorcht-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Acked-by: Pavel Emelyanov <xemul-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> > --- > fs/proc/base.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/proc/base.c b/fs/proc/base.c > index 2dad4a9..8a38eef 100644 > --- a/fs/proc/base.c > +++ b/fs/proc/base.c > @@ -2079,6 +2079,7 @@ static int show_timer(struct seq_file *m, void *v) > nstr[notify & ~SIGEV_THREAD_ID], > (notify & SIGEV_THREAD_ID) ? "tid" : "pid", > pid_nr_ns(timer->it_pid, tp->ns)); > + seq_printf(m, "ClockID: %d\n", timer->it_clock); > > return 0; > } > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] posix-timers: Show clock ID in proc file @ 2013-05-17 16:10 ` Pavel Emelyanov 0 siblings, 0 replies; 12+ messages in thread From: Pavel Emelyanov @ 2013-05-17 16:10 UTC (permalink / raw) To: Thomas Gleixner Cc: Pavel Tikhomirov, Ingo Molnar, Michael Kerrisk, Matthew Helsley, linux-api, Linux Kernel Mailing List On 05/17/2013 02:12 AM, Pavel Tikhomirov wrote: > Expand information about posix-timers in /proc/<pid>/timers by adding > info about clock, with which the timer was created. I.e. in the forth > line of timer info after "notify:" line go "ClockID: <clock_id>". > > Signed-off-by: Pavel Tikhomirov <snorcht@gmail.com> Acked-by: Pavel Emelyanov <xemul@parallels.com> > --- > fs/proc/base.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/proc/base.c b/fs/proc/base.c > index 2dad4a9..8a38eef 100644 > --- a/fs/proc/base.c > +++ b/fs/proc/base.c > @@ -2079,6 +2079,7 @@ static int show_timer(struct seq_file *m, void *v) > nstr[notify & ~SIGEV_THREAD_ID], > (notify & SIGEV_THREAD_ID) ? "tid" : "pid", > pid_nr_ns(timer->it_pid, tp->ns)); > + seq_printf(m, "ClockID: %d\n", timer->it_clock); > > return 0; > } > ^ permalink raw reply [flat|nested] 12+ messages in thread
* [tip:timers/urgent] posix-timers: Show clock ID in proc file 2013-05-16 22:12 ` Pavel Tikhomirov (?) (?) @ 2013-05-28 9:44 ` tip-bot for Pavel Tikhomirov -1 siblings, 0 replies; 12+ messages in thread From: tip-bot for Pavel Tikhomirov @ 2013-05-28 9:44 UTC (permalink / raw) To: linux-tip-commits Cc: linux-kernel, hpa, mingo, matt.helsley, xemul, snorcht, tglx, mtk.manpages Commit-ID: 15ef0298deb3929eb6ad6d2334fd2059fd53807c Gitweb: http://git.kernel.org/tip/15ef0298deb3929eb6ad6d2334fd2059fd53807c Author: Pavel Tikhomirov <snorcht@gmail.com> AuthorDate: Fri, 17 May 2013 02:12:03 +0400 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Tue, 28 May 2013 11:41:14 +0200 posix-timers: Show clock ID in proc file Expand information about posix-timers in /proc/<pid>/timers by adding info about clock, with which the timer was created. I.e. in the forth line of timer info after "notify:" line go "ClockID: <clock_id>". Signed-off-by: Pavel Tikhomirov <snorcht@gmail.com> Cc: Michael Kerrisk <mtk.manpages@gmail.com> Cc: Matthew Helsley <matt.helsley@gmail.com> Cc: Pavel Emelyanov <xemul@parallels.com> Link: http://lkml.kernel.org/r/1368742323-46949-2-git-send-email-snorcht@gmail.com Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- fs/proc/base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/proc/base.c b/fs/proc/base.c index dd51e50..c3834da 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -2118,6 +2118,7 @@ static int show_timer(struct seq_file *m, void *v) nstr[notify & ~SIGEV_THREAD_ID], (notify & SIGEV_THREAD_ID) ? "tid" : "pid", pid_nr_ns(timer->it_pid, tp->ns)); + seq_printf(m, "ClockID: %d\n", timer->it_clock); return 0; } ^ permalink raw reply related [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-05-28 9:45 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-16 22:12 [PATCH 0/1] posix timers: Expand exitsting info in proc file Pavel Tikhomirov
2013-05-16 22:12 ` Pavel Tikhomirov
[not found] ` <1368742323-46949-1-git-send-email-snorcht-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-05-16 22:12 ` [PATCH 1/1] posix-timers: Show clock ID " Pavel Tikhomirov
2013-05-16 22:12 ` Pavel Tikhomirov
[not found] ` <1368742323-46949-2-git-send-email-snorcht-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-05-17 15:59 ` Greg KH
2013-05-17 15:59 ` Greg KH
2013-05-17 16:12 ` Pavel Emelyanov
[not found] ` <51965707.5010305-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-05-17 16:22 ` Greg KH
2013-05-17 16:22 ` Greg KH
2013-05-17 16:10 ` Pavel Emelyanov
2013-05-17 16:10 ` Pavel Emelyanov
2013-05-28 9:44 ` [tip:timers/urgent] " tip-bot for Pavel Tikhomirov
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.