From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv6 0/3] Add support for velocity network driver on platform devices
Date: Sat, 18 May 2013 14:22:57 +1200 [thread overview]
Message-ID: <5196E601.10202@prisktech.co.nz> (raw)
In-Reply-To: <20130517.173644.1877140985770026320.davem@davemloft.net>
On 18/05/13 12:36, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Fri, 17 May 2013 14:19:38 -0700 (PDT)
>
>> Series applied, thanks.
> I'm reverting this, you're not using the correct types for the PM
> functions you're hooking up.
>
> drivers/net/ethernet/via/via-velocity.c:3238:8: warning: initialization from incompatible pointer type [enabled by default]
> drivers/net/ethernet/via/via-velocity.c:3238:8: warning: (near initialization for ?velocity_pm_ops.suspend?) [enabled by default]
> drivers/net/ethernet/via/via-velocity.c:3238:8: warning: initialization from incompatible pointer type [enabled by default]
> drivers/net/ethernet/via/via-velocity.c:3238:8: warning: (near initialization for ?velocity_pm_ops.freeze?) [enabled by default]
> drivers/net/ethernet/via/via-velocity.c:3238:8: warning: initialization from incompatible pointer type [enabled by default]
> drivers/net/ethernet/via/via-velocity.c:3238:8: warning: (near initialization for ?velocity_pm_ops.poweroff?) [enabled by default]
Argh.. sorry Dave.
I forgot to merge the fixup for this before sending. Fixed version to
follow.
Regards
Tony P
WARNING: multiple messages have this Message-ID (diff)
From: Tony Prisk <linux@prisktech.co.nz>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, romieu@fr.zoreil.com,
netdev@vger.kernel.org
Subject: Re: [PATCHv6 0/3] Add support for velocity network driver on platform devices
Date: Sat, 18 May 2013 14:22:57 +1200 [thread overview]
Message-ID: <5196E601.10202@prisktech.co.nz> (raw)
In-Reply-To: <20130517.173644.1877140985770026320.davem@davemloft.net>
On 18/05/13 12:36, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Fri, 17 May 2013 14:19:38 -0700 (PDT)
>
>> Series applied, thanks.
> I'm reverting this, you're not using the correct types for the PM
> functions you're hooking up.
>
> drivers/net/ethernet/via/via-velocity.c:3238:8: warning: initialization from incompatible pointer type [enabled by default]
> drivers/net/ethernet/via/via-velocity.c:3238:8: warning: (near initialization for ‘velocity_pm_ops.suspend’) [enabled by default]
> drivers/net/ethernet/via/via-velocity.c:3238:8: warning: initialization from incompatible pointer type [enabled by default]
> drivers/net/ethernet/via/via-velocity.c:3238:8: warning: (near initialization for ‘velocity_pm_ops.freeze’) [enabled by default]
> drivers/net/ethernet/via/via-velocity.c:3238:8: warning: initialization from incompatible pointer type [enabled by default]
> drivers/net/ethernet/via/via-velocity.c:3238:8: warning: (near initialization for ‘velocity_pm_ops.poweroff’) [enabled by default]
Argh.. sorry Dave.
I forgot to merge the fixup for this before sending. Fixed version to
follow.
Regards
Tony P
next prev parent reply other threads:[~2013-05-18 2:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 5:21 [PATCHv6 0/3] Add support for velocity network driver on platform devices Tony Prisk
2013-05-17 5:21 ` Tony Prisk
2013-05-17 5:21 ` [PATCHv6 1/3] net: velocity: Rename vptr->dev to vptr->netdev Tony Prisk
2013-05-17 5:21 ` Tony Prisk
2013-05-17 5:21 ` [PATCHv6 2/3] net: velocity: Convert to generic dma functions Tony Prisk
2013-05-17 5:21 ` Tony Prisk
2013-05-17 5:21 ` [PATCHv6 3/3] net: velocity: Add platform device support to VIA velocity driver Tony Prisk
2013-05-17 5:21 ` Tony Prisk
2013-05-17 21:19 ` [PATCHv6 0/3] Add support for velocity network driver on platform devices David Miller
2013-05-17 21:19 ` David Miller
2013-05-18 0:36 ` David Miller
2013-05-18 0:36 ` David Miller
2013-05-18 0:36 ` David Miller
2013-05-18 2:22 ` Tony Prisk [this message]
2013-05-18 2:22 ` Tony Prisk
-- strict thread matches above, loose matches on Subject: below --
2013-05-13 5:47 Tony Prisk
2013-05-13 5:47 ` Tony Prisk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5196E601.10202@prisktech.co.nz \
--to=linux@prisktech.co.nz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.