From: Libo Chen <clbchenlibo.chen@huawei.com>
To: matthew.garrett@nebula.com
Cc: platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Li Zefan <lizefan@huawei.com>
Subject: [PATCH 3/3] x86 platform drivers: fix gpio leak
Date: Mon, 20 May 2013 10:30:10 +0800 [thread overview]
Message-ID: <51998AB2.4080909@huawei.com> (raw)
In-Reply-To: <1368889004-5520-4-git-send-email-libo.chen@huawei.com>
when request_irq faild, we should release gpiochip
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/platform/x86/intel_pmic_gpio.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
mode change 100644 => 100755 drivers/platform/x86/intel_pmic_gpio.c
diff --git a/drivers/platform/x86/intel_pmic_gpio.c b/drivers/platform/x86/intel_pmic_gpio.c
old mode 100644
new mode 100755
index 6f4b728..478c3a5
--- a/drivers/platform/x86/intel_pmic_gpio.c
+++ b/drivers/platform/x86/intel_pmic_gpio.c
@@ -288,7 +288,7 @@ static int platform_pmic_gpio_probe(struct platform_device *pdev)
retval = request_irq(pg->irq, pmic_irq_handler, 0, "pmic", pg);
if (retval) {
pr_warn("Interrupt request failed\n");
- goto err;
+ goto fail_request_irq;
}
for (i = 0; i < 8; i++) {
@@ -299,6 +299,9 @@ static int platform_pmic_gpio_probe(struct platform_device *pdev)
irq_set_chip_data(i + pg->irq_base, pg);
}
return 0;
+
+fail_request_irq:
+ gpiochip_remove(&pg->chip);
err:
iounmap(pg->gpiointr);
err2:
--
1.8.1.2
WARNING: multiple messages have this Message-ID (diff)
From: Libo Chen <clbchenlibo.chen@huawei.com>
To: <matthew.garrett@nebula.com>
Cc: <platform-driver-x86@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Li Zefan <lizefan@huawei.com>
Subject: [PATCH 3/3] x86 platform drivers: fix gpio leak
Date: Mon, 20 May 2013 10:30:10 +0800 [thread overview]
Message-ID: <51998AB2.4080909@huawei.com> (raw)
In-Reply-To: <1368889004-5520-4-git-send-email-libo.chen@huawei.com>
when request_irq faild, we should release gpiochip
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/platform/x86/intel_pmic_gpio.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
mode change 100644 => 100755 drivers/platform/x86/intel_pmic_gpio.c
diff --git a/drivers/platform/x86/intel_pmic_gpio.c b/drivers/platform/x86/intel_pmic_gpio.c
old mode 100644
new mode 100755
index 6f4b728..478c3a5
--- a/drivers/platform/x86/intel_pmic_gpio.c
+++ b/drivers/platform/x86/intel_pmic_gpio.c
@@ -288,7 +288,7 @@ static int platform_pmic_gpio_probe(struct platform_device *pdev)
retval = request_irq(pg->irq, pmic_irq_handler, 0, "pmic", pg);
if (retval) {
pr_warn("Interrupt request failed\n");
- goto err;
+ goto fail_request_irq;
}
for (i = 0; i < 8; i++) {
@@ -299,6 +299,9 @@ static int platform_pmic_gpio_probe(struct platform_device *pdev)
irq_set_chip_data(i + pg->irq_base, pg);
}
return 0;
+
+fail_request_irq:
+ gpiochip_remove(&pg->chip);
err:
iounmap(pg->gpiointr);
err2:
--
1.8.1.2
next parent reply other threads:[~2013-05-20 2:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1368889004-5520-4-git-send-email-libo.chen@huawei.com>
2013-05-20 2:30 ` Libo Chen [this message]
2013-05-20 2:30 ` [PATCH 3/3] x86 platform drivers: fix gpio leak Libo Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51998AB2.4080909@huawei.com \
--to=clbchenlibo.chen@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.