From: Libo Chen <clbchenlibo.chen@huawei.com>
To: matthew.garrett@nebula.com
Cc: platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Li Zefan <lizefan@huawei.com>
Subject: [PATCH 2/3] x86: asus-laptop: fix invalid point access
Date: Mon, 20 May 2013 10:30:24 +0800 [thread overview]
Message-ID: <51998AC0.3070501@huawei.com> (raw)
In-Reply-To: <1368889004-5520-3-git-send-email-libo.chen@huawei.com>
asus->name is null or point to const string,so it is not suitable to kfree it.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/platform/x86/asus-laptop.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
index 0eea09c..8e268da 100644
--- a/drivers/platform/x86/asus-laptop.c
+++ b/drivers/platform/x86/asus-laptop.c
@@ -1935,7 +1935,6 @@ fail_input:
fail_backlight:
asus_platform_exit(asus);
fail_platform:
- kfree(asus->name);
kfree(asus);
return result;
--
1.8.1.2
WARNING: multiple messages have this Message-ID (diff)
From: Libo Chen <clbchenlibo.chen@huawei.com>
To: <matthew.garrett@nebula.com>
Cc: <platform-driver-x86@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Li Zefan <lizefan@huawei.com>
Subject: [PATCH 2/3] x86: asus-laptop: fix invalid point access
Date: Mon, 20 May 2013 10:30:24 +0800 [thread overview]
Message-ID: <51998AC0.3070501@huawei.com> (raw)
In-Reply-To: <1368889004-5520-3-git-send-email-libo.chen@huawei.com>
asus->name is null or point to const string,so it is not suitable to kfree it.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/platform/x86/asus-laptop.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
index 0eea09c..8e268da 100644
--- a/drivers/platform/x86/asus-laptop.c
+++ b/drivers/platform/x86/asus-laptop.c
@@ -1935,7 +1935,6 @@ fail_input:
fail_backlight:
asus_platform_exit(asus);
fail_platform:
- kfree(asus->name);
kfree(asus);
return result;
--
1.8.1.2
next parent reply other threads:[~2013-05-20 2:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1368889004-5520-3-git-send-email-libo.chen@huawei.com>
2013-05-20 2:30 ` Libo Chen [this message]
2013-05-20 2:30 ` [PATCH 2/3] x86: asus-laptop: fix invalid point access Libo Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51998AC0.3070501@huawei.com \
--to=clbchenlibo.chen@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.