From: clbchenlibo.chen@huawei.com (Libo Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/19] driver:usb&net: add missing platform_driver owner
Date: Tue, 21 May 2013 17:42:34 +0800 [thread overview]
Message-ID: <519B418A.7060805@huawei.com> (raw)
In-Reply-To: <20130521110616.21eee053@skate>
On 2013/5/21 17:06, Thomas Petazzoni wrote:
> Dear Gu Zheng,
>
> On Tue, 21 May 2013 16:00:19 +0800, Gu Zheng wrote:
>
>>> Or, maybe make the existing module_platform_driver() macro do this?
>>
>> But not all the modules use module_platform_driver() macro to replace the module init/exit.
>
> Then maybe it's a good opportunity to convert those ones to use
> module_platform_driver() ?
>
> Thomas
>
In my opinion, not all modules can use module_platform_driver() macro to replace the module init/exit easily, like us3mc_init.
Furthermore this work will touch various platforms and architectures, I am worried it is hard to *test* (compile and boot).
What do you think?
WARNING: multiple messages have this Message-ID (diff)
From: Libo Chen <clbchenlibo.chen@huawei.com>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gu Zheng <guz.fnst@cn.fujitsu.com>,
David Miller <davem@davemloft.net>, <libo.chen@huawei.com>,
<gregkh@linuxfoundation.org>, <samuel@sortiz.org>,
<stern@rowland.harvard.edu>, <khc@pm.waw.pl>,
<akpm@linux-foundation.org>, <balbi@ti.com>,
<sarah.a.sharp@linux.intel.com>,
<alexander.shishkin@linux.intel.com>, <brudley@broadcom.com>,
<linux-usb@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <lizefan@huawei.com>
Subject: Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner
Date: Tue, 21 May 2013 17:42:34 +0800 [thread overview]
Message-ID: <519B418A.7060805@huawei.com> (raw)
In-Reply-To: <20130521110616.21eee053@skate>
On 2013/5/21 17:06, Thomas Petazzoni wrote:
> Dear Gu Zheng,
>
> On Tue, 21 May 2013 16:00:19 +0800, Gu Zheng wrote:
>
>>> Or, maybe make the existing module_platform_driver() macro do this?
>>
>> But not all the modules use module_platform_driver() macro to replace the module init/exit.
>
> Then maybe it's a good opportunity to convert those ones to use
> module_platform_driver() ?
>
> Thomas
>
In my opinion, not all modules can use module_platform_driver() macro to replace the module init/exit easily, like us3mc_init.
Furthermore this work will touch various platforms and architectures, I am worried it is hard to *test* (compile and boot).
What do you think?
next prev parent reply other threads:[~2013-05-21 9:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 2:42 [PATCH 00/19] driver:usb&net: add missing platform_driver owner Libo Chen
2013-05-21 2:42 ` Libo Chen
2013-05-21 6:26 ` David Miller
2013-05-21 6:26 ` David Miller
2013-05-21 6:41 ` Thomas Petazzoni
2013-05-21 6:41 ` Thomas Petazzoni
2013-05-21 7:13 ` David Miller
2013-05-21 7:13 ` David Miller
2013-05-21 8:00 ` Gu Zheng
2013-05-21 8:00 ` Gu Zheng
2013-05-21 8:26 ` Libo Chen
2013-05-21 8:26 ` Libo Chen
2013-05-21 8:50 ` Gu Zheng
2013-05-21 8:50 ` Gu Zheng
2013-05-21 9:06 ` Thomas Petazzoni
2013-05-21 9:06 ` Thomas Petazzoni
2013-05-21 9:42 ` Libo Chen [this message]
2013-05-21 9:42 ` Libo Chen
2013-05-22 1:30 ` Gu Zheng
2013-05-22 1:30 ` Gu Zheng
2013-05-21 18:40 ` Greg KH
2013-05-21 18:40 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519B418A.7060805@huawei.com \
--to=clbchenlibo.chen@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.