From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Hiroshi Doyu <hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [v2 2/6] ARM: tegra20: convert device tree files to use CLK defines
Date: Tue, 21 May 2013 10:13:31 -0600 [thread overview]
Message-ID: <519B9D2B.5010101@wwwdotorg.org> (raw)
In-Reply-To: <1369127450-15203-3-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 05/21/2013 03:10 AM, Hiroshi Doyu wrote:
> Use the Tegra20 CAR binding header (tegra20-car.h) to replace magic
> numbers in the device tree. For example,
>
> - clocks = <&tegra_car 28>;
> + clocks = <&tegra_car CLK_HOST1X>;
> diff --git a/arch/arm/boot/dts/tegra20-paz00.dts b/arch/arm/boot/dts/tegra20-paz00.dts
> - clocks = <&tegra_car 112>, <&tegra_car 113>, <&tegra_car 94>;
> + clocks = <&tegra_car TEGRA20_CLK_PLL_A>, <&tegra_car TEGRA20_CLK_PLL_A_OUT0>, <&tegra_car TEGRA20_CLK_CDEV1>;
That's well over 80 columns. Can you wrap it and make sure there aren't
any other instances of this? I guess checkpatch doesn't actually impose
this rule on *.dts files, since it didn't complain about this.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [v2 2/6] ARM: tegra20: convert device tree files to use CLK defines
Date: Tue, 21 May 2013 10:13:31 -0600 [thread overview]
Message-ID: <519B9D2B.5010101@wwwdotorg.org> (raw)
In-Reply-To: <1369127450-15203-3-git-send-email-hdoyu@nvidia.com>
On 05/21/2013 03:10 AM, Hiroshi Doyu wrote:
> Use the Tegra20 CAR binding header (tegra20-car.h) to replace magic
> numbers in the device tree. For example,
>
> - clocks = <&tegra_car 28>;
> + clocks = <&tegra_car CLK_HOST1X>;
> diff --git a/arch/arm/boot/dts/tegra20-paz00.dts b/arch/arm/boot/dts/tegra20-paz00.dts
> - clocks = <&tegra_car 112>, <&tegra_car 113>, <&tegra_car 94>;
> + clocks = <&tegra_car TEGRA20_CLK_PLL_A>, <&tegra_car TEGRA20_CLK_PLL_A_OUT0>, <&tegra_car TEGRA20_CLK_CDEV1>;
That's well over 80 columns. Can you wrap it and make sure there aren't
any other instances of this? I guess checkpatch doesn't actually impose
this rule on *.dts files, since it didn't complain about this.
next prev parent reply other threads:[~2013-05-21 16:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 9:10 [v2 0/6] CLK: tegra: convert device tree files to use CLK defines Hiroshi Doyu
2013-05-21 9:10 ` Hiroshi Doyu
[not found] ` <1369127450-15203-1-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-21 9:10 ` [v2 1/6] ARM: tegra20: create a DT header defining CLK IDs Hiroshi Doyu
2013-05-21 9:10 ` [v2 2/6] ARM: tegra20: convert device tree files to use CLK defines Hiroshi Doyu
[not found] ` <1369127450-15203-3-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-21 16:13 ` Stephen Warren [this message]
2013-05-21 16:13 ` Stephen Warren
2013-05-21 9:10 ` [v2 3/6] ARM: tegra30: create a DT header defining CLK IDs Hiroshi Doyu
2013-05-21 9:10 ` [v2 4/6] ARM: tegra30: convert device tree files to use CLK defines Hiroshi Doyu
2013-05-21 9:10 ` [v2 5/6] ARM: tegra114: create a DT header defining CLK IDs Hiroshi Doyu
2013-05-21 9:10 ` [v2 6/6] ARM: tegra114: convert device tree files to use CLK defines Hiroshi Doyu
2013-05-21 16:05 ` [v2 0/6] CLK: tegra: " Stephen Warren
2013-05-21 16:05 ` Stephen Warren
[not found] ` <519B9B5D.4050402-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-05-22 6:12 ` Hiroshi Doyu
2013-05-22 6:12 ` Hiroshi Doyu
[not found] ` <20130522091248.b3acd9c56ab66535d75b8fd1-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-22 10:07 ` Hiroshi Doyu
2013-05-22 10:07 ` Hiroshi Doyu
[not found] ` <20130522.130730.1153046210420942555.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-22 15:20 ` Stephen Warren
2013-05-22 15:20 ` Stephen Warren
2013-05-22 15:19 ` Stephen Warren
2013-05-22 15:19 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519B9D2B.5010101@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.