From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: tegra: add cpu_disable for hotplug
Date: Tue, 21 May 2013 10:15:48 -0600 [thread overview]
Message-ID: <519B9DB4.7070106@wwwdotorg.org> (raw)
In-Reply-To: <1369131215-2920-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 05/21/2013 04:13 AM, Joseph Lo wrote:
> The Tegra114 could hotplug the CPU0, but the common cpu_disable didn't
> support that. Adding a Tegra specific cpu_disable function for it.
>
> Signed-off-by: Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> diff --git a/arch/arm/mach-tegra/hotplug.c b/arch/arm/mach-tegra/hotplug.c
> +int tegra_cpu_disable(unsigned int cpu)
> +{
> + switch (tegra_chip_id) {
> + case TEGRA114:
> + return 0;
> + default:
> + return cpu == 0 ? -EPERM : 0;
> + }
> +}
Do we expect all/most future chips to support hotplug of CPU0? Or at
least, fewer chips to have the restriction than not? If so, it might be
more forward-looking to write that as:
if (tegra_chip_id == TEGRA30)
return cpu == 0 ? -EPERM : 0;
return 0;
?
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: add cpu_disable for hotplug
Date: Tue, 21 May 2013 10:15:48 -0600 [thread overview]
Message-ID: <519B9DB4.7070106@wwwdotorg.org> (raw)
In-Reply-To: <1369131215-2920-1-git-send-email-josephl@nvidia.com>
On 05/21/2013 04:13 AM, Joseph Lo wrote:
> The Tegra114 could hotplug the CPU0, but the common cpu_disable didn't
> support that. Adding a Tegra specific cpu_disable function for it.
>
> Signed-off-by: Joseph Lo <josephl@nvidia.com>
> diff --git a/arch/arm/mach-tegra/hotplug.c b/arch/arm/mach-tegra/hotplug.c
> +int tegra_cpu_disable(unsigned int cpu)
> +{
> + switch (tegra_chip_id) {
> + case TEGRA114:
> + return 0;
> + default:
> + return cpu == 0 ? -EPERM : 0;
> + }
> +}
Do we expect all/most future chips to support hotplug of CPU0? Or at
least, fewer chips to have the restriction than not? If so, it might be
more forward-looking to write that as:
if (tegra_chip_id == TEGRA30)
return cpu == 0 ? -EPERM : 0;
return 0;
?
next prev parent reply other threads:[~2013-05-21 16:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 10:13 [PATCH] ARM: tegra: add cpu_disable for hotplug Joseph Lo
2013-05-21 10:13 ` Joseph Lo
[not found] ` <1369131215-2920-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-21 16:15 ` Stephen Warren [this message]
2013-05-21 16:15 ` Stephen Warren
2013-05-22 9:03 ` Peter De Schrijver
2013-05-22 9:03 ` Peter De Schrijver
[not found] ` <20130522090304.GT21944-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2013-05-22 21:18 ` Stephen Warren
2013-05-22 21:18 ` Stephen Warren
[not found] ` <519D363E.4000409-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-05-23 10:03 ` Joseph Lo
2013-05-23 10:03 ` Joseph Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519B9DB4.7070106@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.