From: Stephen Warren <swarren@wwwdotorg.org>
To: Florian Vaussard <florian.vaussard@epfl.ch>
Cc: Benoit Cousson <b-cousson@ti.com>,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5] ARM: dts: OMAP2+: convert DT files to use the new OMAP_GPIO macro
Date: Wed, 22 May 2013 09:28:51 -0600 [thread overview]
Message-ID: <519CE433.10903@wwwdotorg.org> (raw)
In-Reply-To: <1369232864-14460-4-git-send-email-florian.vaussard@epfl.ch>
On 05/22/2013 08:27 AM, Florian Vaussard wrote:
> Use OMAP_GPIO(), in conjunction with standard GPIO flags, to enhance the
> readability of DT GPIOs.
> diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts
> index e0ce823..e773a5e 100644
> --- a/arch/arm/boot/dts/omap3-beagle-xm.dts
> +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
> @@ -29,13 +29,13 @@
>
> heartbeat {
> label = "beagleboard::usr0";
> - gpios = <&gpio5 22 0>; /* 150 -> D6 LED */
> + gpios = OMAP_GPIO(150, GPIO_ACTIVE_HIGH); /* 150 -> D6 LED */
One of the advantages of cpp support for me is the ability to remove the
redundant part of the command. In other words, perhaps remove the "150
->" since that information is part of the OMAP_GPIO() "call", leaving
just /* D6 LED */. I might have expected "D6" to be the label too, thus
removing any need for the comment.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] ARM: dts: OMAP2+: convert DT files to use the new OMAP_GPIO macro
Date: Wed, 22 May 2013 09:28:51 -0600 [thread overview]
Message-ID: <519CE433.10903@wwwdotorg.org> (raw)
In-Reply-To: <1369232864-14460-4-git-send-email-florian.vaussard@epfl.ch>
On 05/22/2013 08:27 AM, Florian Vaussard wrote:
> Use OMAP_GPIO(), in conjunction with standard GPIO flags, to enhance the
> readability of DT GPIOs.
> diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts
> index e0ce823..e773a5e 100644
> --- a/arch/arm/boot/dts/omap3-beagle-xm.dts
> +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
> @@ -29,13 +29,13 @@
>
> heartbeat {
> label = "beagleboard::usr0";
> - gpios = <&gpio5 22 0>; /* 150 -> D6 LED */
> + gpios = OMAP_GPIO(150, GPIO_ACTIVE_HIGH); /* 150 -> D6 LED */
One of the advantages of cpp support for me is the ability to remove the
redundant part of the command. In other words, perhaps remove the "150
->" since that information is part of the OMAP_GPIO() "call", leaving
just /* D6 LED */. I might have expected "D6" to be the label too, thus
removing any need for the comment.
next prev parent reply other threads:[~2013-05-22 15:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 14:27 [PATCH 0/5] ARM: dts: OMAP2+: use preprocessor for device trees Florian Vaussard
2013-05-22 14:27 ` Florian Vaussard
2013-05-22 14:27 ` [PATCH 1/5] ARM: dts: OMAP2+: use #include for all " Florian Vaussard
2013-05-22 14:27 ` Florian Vaussard
2013-05-22 15:40 ` Tony Lindgren
2013-05-22 15:40 ` Tony Lindgren
2013-05-22 16:05 ` Florian Vaussard
2013-05-22 16:05 ` Florian Vaussard
2013-05-22 14:27 ` [PATCH 2/5] ARM: dts: OMAP2+: create a DT header for GPIO Florian Vaussard
2013-05-22 14:27 ` Florian Vaussard
2013-05-22 15:26 ` Stephen Warren
2013-05-22 15:26 ` Stephen Warren
2013-05-22 15:34 ` Tony Lindgren
2013-05-22 15:34 ` Tony Lindgren
2013-05-22 16:00 ` Florian Vaussard
2013-05-22 16:00 ` Florian Vaussard
2013-05-22 16:03 ` Stephen Warren
2013-05-22 16:03 ` Stephen Warren
2013-05-22 14:27 ` [PATCH 3/5] ARM: dts: OMAP2+: convert DT files to use the new OMAP_GPIO macro Florian Vaussard
2013-05-22 14:27 ` Florian Vaussard
2013-05-22 15:28 ` Stephen Warren [this message]
2013-05-22 15:28 ` Stephen Warren
2013-05-22 16:02 ` Florian Vaussard
2013-05-22 16:02 ` Florian Vaussard
2013-05-22 14:27 ` [PATCH 4/5] ARM: dts: OMAP3: fix incorrect notation for musb-hdrc interrupt Florian Vaussard
2013-05-22 14:27 ` Florian Vaussard
2013-05-22 15:35 ` Tony Lindgren
2013-05-22 15:35 ` Tony Lindgren
2013-05-22 14:27 ` [PATCH 5/5] ARM: dts: OMAP4/5: use existing constants for IRQs Florian Vaussard
2013-05-22 14:27 ` Florian Vaussard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519CE433.10903@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=florian.vaussard@epfl.ch \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.