From: Florian Meier <florian.meier@koalo.de>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] ASoC: Add support for BCM2708
Date: Wed, 22 May 2013 18:08:18 +0200 [thread overview]
Message-ID: <519CED72.40406@koalo.de> (raw)
In-Reply-To: <519CE2B7.8080704@wwwdotorg.org>
On 22.05.2013 17:22, Stephen Warren wrote:
> On 05/22/2013 08:10 AM, Florian Meier wrote:
>> This driver adds support for digital audio (I2S)
>> for the BCM2708 SoC that is used by the
>> Raspberry Pi. External audio codecs can be
>> connected to the Raspberry Pi via P5 header.
>>
>> It relies on cyclic DMA engine support for BCM2708
>> that is not included in this patch.
>
> This SoC is actually the BCM2835, so the files should be named for that.
Actually, I changed the name several times and in the end I sticked to
https://github.com/raspberrypi/linux/issues/22
but if you think it is better to use BCM2835 I am happy to agree with
you and change it.
> Upstream only uses device tree for BCM2835. Does this driver support DT?
> Where is the DT binding definition file?
I have not accomplished to use the mainline kernel and DT with the
Raspberry Pi. Do you have any introductive information about how to do this?
> I assume you're planning on sending the DMA driver upstream too? I guess
> this driver isn't useful without it.
I would like to, but it only supports cyclic DMA. Should I send it
upstream anyway? In case you are interested:
https://github.com/koalo/linux/blob/rpi-3.8.y-asocdev/drivers/dma/bcm2708-dmaengine.c
> I'll take a look at the actual patch content later.
That would be great!
WARNING: multiple messages have this Message-ID (diff)
From: florian.meier@koalo.de (Florian Meier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: Add support for BCM2708
Date: Wed, 22 May 2013 18:08:18 +0200 [thread overview]
Message-ID: <519CED72.40406@koalo.de> (raw)
In-Reply-To: <519CE2B7.8080704@wwwdotorg.org>
On 22.05.2013 17:22, Stephen Warren wrote:
> On 05/22/2013 08:10 AM, Florian Meier wrote:
>> This driver adds support for digital audio (I2S)
>> for the BCM2708 SoC that is used by the
>> Raspberry Pi. External audio codecs can be
>> connected to the Raspberry Pi via P5 header.
>>
>> It relies on cyclic DMA engine support for BCM2708
>> that is not included in this patch.
>
> This SoC is actually the BCM2835, so the files should be named for that.
Actually, I changed the name several times and in the end I sticked to
https://github.com/raspberrypi/linux/issues/22
but if you think it is better to use BCM2835 I am happy to agree with
you and change it.
> Upstream only uses device tree for BCM2835. Does this driver support DT?
> Where is the DT binding definition file?
I have not accomplished to use the mainline kernel and DT with the
Raspberry Pi. Do you have any introductive information about how to do this?
> I assume you're planning on sending the DMA driver upstream too? I guess
> this driver isn't useful without it.
I would like to, but it only supports cyclic DMA. Should I send it
upstream anyway? In case you are interested:
https://github.com/koalo/linux/blob/rpi-3.8.y-asocdev/drivers/dma/bcm2708-dmaengine.c
> I'll take a look at the actual patch content later.
That would be great!
next prev parent reply other threads:[~2013-05-22 16:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 14:10 [PATCH] ASoC: Add support for BCM2708 Florian Meier
2013-05-22 14:10 ` Florian Meier
2013-05-22 15:22 ` Stephen Warren
2013-05-22 15:22 ` Stephen Warren
2013-05-22 16:08 ` Florian Meier [this message]
2013-05-22 16:08 ` Florian Meier
2013-05-22 16:15 ` Stephen Warren
2013-05-22 16:15 ` Stephen Warren
2013-05-22 17:11 ` Florian Meier
2013-05-22 17:11 ` Florian Meier
2013-05-22 16:42 ` Mark Brown
2013-05-22 16:42 ` Mark Brown
2013-05-22 16:42 ` Mark Brown
2013-05-22 16:39 ` Mark Brown
2013-05-22 16:39 ` Mark Brown
2013-05-22 16:39 ` Mark Brown
2013-05-22 17:16 ` Florian Meier
2013-05-22 17:16 ` Florian Meier
2013-05-22 17:26 ` Lars-Peter Clausen
2013-05-22 17:26 ` Lars-Peter Clausen
2013-05-24 15:32 ` Florian Meier
2013-05-24 15:32 ` Florian Meier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519CED72.40406@koalo.de \
--to=florian.meier@koalo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=perex@perex.cz \
--cc=swarren@wwwdotorg.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.