All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Daney <ddaney@caviumnetworks.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
	David Daney <ddaney.cavm@gmail.com>,
	linux-mips@linux-mips.org, David Daney <david.daney@cavium.com>,
	linux-ide@vger.kernel.org, linux-edac@vger.kernel.org,
	linux-i2c@vger.kernel.org, netdev@vger.kernel.org,
	spi-devel-general@lists.sourceforge.net,
	devel@driverdev.osuosl.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] MIPS: OCTEON: Rename Kconfig CAVIUM_OCTEON_REFERENCE_BOARD to CAVIUM_OCTEON_SOC
Date: Wed, 22 May 2013 09:13:50 -0700	[thread overview]
Message-ID: <519CEEBE.5020403@caviumnetworks.com> (raw)
In-Reply-To: <20130522122232.GD10769@linux-mips.org>

On 05/22/2013 05:22 AM, Ralf Baechle wrote:
> On Tue, May 21, 2013 at 03:07:23PM -0700, David Daney wrote:
>
>>>>   config USB_OCTEON_OHCI
>>>>   	bool "Octeon on-chip OHCI support"
>>>> -	depends on CPU_CAVIUM_OCTEON
>>>> +	depends on  CAVIUM_OCTEON_SOC
>>>
>>> Just a minor comment, here the extra whitespace after "depends on"
>>> could be eliminated.
>>>
>>
>> Good point.  I will regenerate the patch to correct this.
>
> I took care of that and queued the patch.
>

Can you take v2 instead?  It has the missing watchdog adjustment that is 
not in v1.

Thanks,
David Daney



WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney@caviumnetworks.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
	David Daney <ddaney.cavm@gmail.com>, <linux-mips@linux-mips.org>,
	David Daney <david.daney@cavium.com>, <linux-ide@vger.kernel.org>,
	<linux-edac@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
	<netdev@vger.kernel.org>,
	<spi-devel-general@lists.sourceforge.net>,
	<devel@driverdev.osuosl.org>, <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] MIPS: OCTEON: Rename Kconfig CAVIUM_OCTEON_REFERENCE_BOARD to CAVIUM_OCTEON_SOC
Date: Wed, 22 May 2013 09:13:50 -0700	[thread overview]
Message-ID: <519CEEBE.5020403@caviumnetworks.com> (raw)
In-Reply-To: <20130522122232.GD10769@linux-mips.org>

On 05/22/2013 05:22 AM, Ralf Baechle wrote:
> On Tue, May 21, 2013 at 03:07:23PM -0700, David Daney wrote:
>
>>>>   config USB_OCTEON_OHCI
>>>>   	bool "Octeon on-chip OHCI support"
>>>> -	depends on CPU_CAVIUM_OCTEON
>>>> +	depends on  CAVIUM_OCTEON_SOC
>>>
>>> Just a minor comment, here the extra whitespace after "depends on"
>>> could be eliminated.
>>>
>>
>> Good point.  I will regenerate the patch to correct this.
>
> I took care of that and queued the patch.
>

Can you take v2 instead?  It has the missing watchdog adjustment that is 
not in v1.

Thanks,
David Daney

  reply	other threads:[~2013-05-22 16:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-20 22:19 [PATCH] MIPS: OCTEON: Rename Kconfig CAVIUM_OCTEON_REFERENCE_BOARD to CAVIUM_OCTEON_SOC David Daney
2013-05-20 22:19 ` David Daney
2013-05-20 23:10 ` Greg KH
     [not found] ` <1369088378-13957-1-git-send-email-ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-05-21  9:26   ` Wolfram Sang
2013-05-21  9:26     ` Wolfram Sang
2013-05-21 10:25 ` Mauro Carvalho Chehab
2013-05-21 22:04 ` Aaro Koskinen
2013-05-21 22:07   ` David Daney
2013-05-21 22:07     ` David Daney
     [not found]     ` <519BF01B.1010600-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2013-05-22 12:22       ` Ralf Baechle
2013-05-22 12:22         ` Ralf Baechle
2013-05-22 16:13         ` David Daney [this message]
2013-05-22 16:13           ` David Daney
2013-05-22 17:14           ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519CEEBE.5020403@caviumnetworks.com \
    --to=ddaney@caviumnetworks.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=david.daney@cavium.com \
    --cc=ddaney.cavm@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.