Re: [f2fs-dev] [PATCH 3/4] f2fs: return proper error from start_gc_thread

[Jason Hrycay <jhrycay@gmail.com>]

On 5/23/2013 8:58 AM, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@samsung.com>
> 
> when there is an error from kthread_run, then return proper error
> rather than returning -ENOMEM.
> 
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
> ---
>  fs/f2fs/gc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index 25b083c..03d5ba1 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -105,7 +105,7 @@ int start_gc_thread(struct f2fs_sb_info *sbi)
>  	if (IS_ERR(gc_th->f2fs_gc_task)) {
>  		kfree(gc_th);

gc_th is free'd here, save off PTR_ERR result to avoid use-after-free?

>  		sbi->gc_thread = NULL;
> -		return -ENOMEM;
> +		return PTR_ERR(gc_th->f2fs_gc_task);
>  	}
>  	return 0;
>  }
> 

--
Jason Hrycay

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may