From: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Gu Zheng <guz.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Cc: Libo Chen <libo.chen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
sonic.zhang-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH RFC v3 2/3] i2c: pxa: convert to devm_* API
Date: Fri, 24 May 2013 11:42:23 +0800 [thread overview]
Message-ID: <519EE19F.3000306@huawei.com> (raw)
In-Reply-To: <519EDFFC.5020308-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
On 2013/5/24 11:35, Gu Zheng wrote:
> Hi Libo,
> I think you can merge patch 1/3 and 2/3, they do the same thing that using devm_* API to simplify
> and make the code clean, and the additional goal is it also can fix a bug.
nope. they should be separated.
> Besides, maybe you need to
> change the title and make it clear and self-described.
>
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizefan@huawei.com>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: Libo Chen <libo.chen@huawei.com>, <wsa@the-dreams.de>,
<sonic.zhang@analog.com>, <linux-i2c@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC v3 2/3] i2c: pxa: convert to devm_* API
Date: Fri, 24 May 2013 11:42:23 +0800 [thread overview]
Message-ID: <519EE19F.3000306@huawei.com> (raw)
In-Reply-To: <519EDFFC.5020308@cn.fujitsu.com>
On 2013/5/24 11:35, Gu Zheng wrote:
> Hi Libo,
> I think you can merge patch 1/3 and 2/3, they do the same thing that using devm_* API to simplify
> and make the code clean, and the additional goal is it also can fix a bug.
nope. they should be separated.
> Besides, maybe you need to
> change the title and make it clear and self-described.
>
next prev parent reply other threads:[~2013-05-24 3:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 12:00 [PATCH RFC v3 2/3] i2c: pxa: convert to devm_* API Libo Chen
2013-05-23 12:00 ` Libo Chen
[not found] ` <1369310408-10348-1-git-send-email-libo.chen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-05-24 3:35 ` Gu Zheng
2013-05-24 3:35 ` Gu Zheng
[not found] ` <519EDFFC.5020308-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2013-05-24 3:42 ` Li Zefan [this message]
2013-05-24 3:42 ` Li Zefan
2013-05-24 3:51 ` Libo Chen
2013-05-24 3:51 ` Libo Chen
2013-06-12 10:02 ` Wolfram Sang
2013-06-12 10:02 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519EE19F.3000306@huawei.com \
--to=lizefan-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=guz.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org \
--cc=libo.chen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sonic.zhang-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.