All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksij Rempel <linux@rempel-privat.de>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 2/2] ath9k: check for Rx-STBC flag and pass it to ieee80211
Date: Fri, 24 May 2013 12:32:46 +0200	[thread overview]
Message-ID: <519F41CE.70004@rempel-privat.de> (raw)
In-Reply-To: <1369391399.8290.6.camel@jlt4.sipsolutions.net>

Am 24.05.2013 12:29, schrieb Johannes Berg:
> On Fri, 2013-05-24 at 12:18 +0200, Oleksij Rempel wrote:
>> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
>> ---
>>   drivers/net/wireless/ath/ath9k/init.c | 9 +++++++--
>>   drivers/net/wireless/ath/ath9k/mac.c  | 5 +++++
>>   drivers/net/wireless/ath/ath9k/mac.h  | 3 ++-
>>   3 files changed, 14 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
>> index aba4151..7739b05 100644
>> --- a/drivers/net/wireless/ath/ath9k/init.c
>> +++ b/drivers/net/wireless/ath/ath9k/init.c
>> @@ -769,8 +769,13 @@ void ath9k_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw)
>>   		IEEE80211_HW_REPORTS_TX_ACK_STATUS |
>>   		IEEE80211_HW_SUPPORTS_RC_TABLE;
>>
>> -	if (sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_HT)
>> -		 hw->flags |= IEEE80211_HW_AMPDU_AGGREGATION;
>> +	if (sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_HT) {
>> +		hw->flags |= IEEE80211_HW_AMPDU_AGGREGATION;
>> +
>> +		if (AR_SREV_9280_20_OR_LATER(ah))
>> +			hw->radiotap_mcs_details |=
>> +				IEEE80211_RADIOTAP_MCS_HAVE_STBC;
>> +	}
>
> Are you sure this is right? It seems that if other devices don't support
> STBC they can report all frames to be w/o STBC. Or do they support STBC
> but don't report it?

They support STBC but don't report it. First device whhic can report it 
is ar9280.


-- 
Regards,
Oleksij

WARNING: multiple messages have this Message-ID (diff)
From: Oleksij Rempel <linux@rempel-privat.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] ath9k: check for Rx-STBC flag and pass it to ieee80211
Date: Fri, 24 May 2013 12:32:46 +0200	[thread overview]
Message-ID: <519F41CE.70004@rempel-privat.de> (raw)
In-Reply-To: <1369391399.8290.6.camel@jlt4.sipsolutions.net>

Am 24.05.2013 12:29, schrieb Johannes Berg:
> On Fri, 2013-05-24 at 12:18 +0200, Oleksij Rempel wrote:
>> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
>> ---
>>   drivers/net/wireless/ath/ath9k/init.c | 9 +++++++--
>>   drivers/net/wireless/ath/ath9k/mac.c  | 5 +++++
>>   drivers/net/wireless/ath/ath9k/mac.h  | 3 ++-
>>   3 files changed, 14 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
>> index aba4151..7739b05 100644
>> --- a/drivers/net/wireless/ath/ath9k/init.c
>> +++ b/drivers/net/wireless/ath/ath9k/init.c
>> @@ -769,8 +769,13 @@ void ath9k_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw)
>>   		IEEE80211_HW_REPORTS_TX_ACK_STATUS |
>>   		IEEE80211_HW_SUPPORTS_RC_TABLE;
>>
>> -	if (sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_HT)
>> -		 hw->flags |= IEEE80211_HW_AMPDU_AGGREGATION;
>> +	if (sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_HT) {
>> +		hw->flags |= IEEE80211_HW_AMPDU_AGGREGATION;
>> +
>> +		if (AR_SREV_9280_20_OR_LATER(ah))
>> +			hw->radiotap_mcs_details |=
>> +				IEEE80211_RADIOTAP_MCS_HAVE_STBC;
>> +	}
>
> Are you sure this is right? It seems that if other devices don't support
> STBC they can report all frames to be w/o STBC. Or do they support STBC
> but don't report it?

They support STBC but don't report it. First device whhic can report it 
is ar9280.


-- 
Regards,
Oleksij

  reply	other threads:[~2013-05-24 10:32 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-19  7:38 [ath9k-devel] [PATCH 0/3] Work on STBC Rx monitoring Oleksij Rempel
2013-05-19  7:38 ` Oleksij Rempel
2013-05-19  7:38 ` [ath9k-devel] [PATCH 1/3] mac80211: add STBC flag for radiotap Oleksij Rempel
2013-05-19  7:38   ` Oleksij Rempel
2013-05-22 19:24   ` [ath9k-devel] " Johannes Berg
2013-05-22 19:24     ` Johannes Berg
2013-05-23  7:17     ` [ath9k-devel] [PATCH v2 " Oleksij Rempel
2013-05-23  7:17       ` Oleksij Rempel
2013-05-23 12:24       ` [ath9k-devel] " Johannes Berg
2013-05-23 12:24         ` Johannes Berg
2013-05-23 14:11     ` [ath9k-devel] [PATCH v3 " Oleksij Rempel
2013-05-23 14:11       ` Oleksij Rempel
2013-05-23 21:33       ` [ath9k-devel] " Johannes Berg
2013-05-23 21:33         ` Johannes Berg
2013-05-24 10:05     ` [ath9k-devel] [PATCH v4 " Oleksij Rempel
2013-05-24 10:05       ` Oleksij Rempel
2013-05-24 10:08       ` [ath9k-devel] " Johannes Berg
2013-05-24 10:08         ` Johannes Berg
2013-05-24 10:11         ` [ath9k-devel] " Oleksij Rempel
2013-05-24 10:11           ` Oleksij Rempel
2013-05-19  7:38 ` [ath9k-devel] [PATCH 2/3] ath9k: remove useless flag conversation Oleksij Rempel
2013-05-19  7:38   ` Oleksij Rempel
2013-05-19  7:38 ` [ath9k-devel] [PATCH 3/3] ath9k: check for Rx-STBC flag and pass it to ieee80211 Oleksij Rempel
2013-05-19  7:38   ` Oleksij Rempel
2013-05-24 10:18 ` [ath9k-devel] [PATCH 0/2] ath9k: STBC Rx monitoring Oleksij Rempel
2013-05-24 10:18   ` Oleksij Rempel
2013-05-24 10:18   ` [ath9k-devel] [PATCH 1/2] ath9k: remove useless flag conversation Oleksij Rempel
2013-05-24 10:18     ` Oleksij Rempel
2013-05-24 10:18   ` [ath9k-devel] [PATCH 2/2] ath9k: check for Rx-STBC flag and pass it to ieee80211 Oleksij Rempel
2013-05-24 10:18     ` Oleksij Rempel
2013-05-24 10:29     ` [ath9k-devel] " Johannes Berg
2013-05-24 10:29       ` Johannes Berg
2013-05-24 10:32       ` Oleksij Rempel [this message]
2013-05-24 10:32         ` Oleksij Rempel
2013-05-24 11:35     ` [ath9k-devel] " Oleksij Rempel
2013-05-24 11:35       ` Oleksij Rempel
2013-05-24 18:30 ` [ath9k-devel] [PATCH v4 " Oleksij Rempel
2013-05-24 18:30   ` Oleksij Rempel
2013-05-30  8:57 ` [ath9k-devel] [PATCH 0/3] Work on STBC Rx monitoring Oleksij Rempel
2013-05-30  8:57   ` Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519F41CE.70004@rempel-privat.de \
    --to=linux@rempel-privat.de \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.