All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@gmail.com>
Cc: Tomasz Figa <t.figa@samsung.com>,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, kgene.kim@samsung.com,
	arnd@arndb.de, olof@lixom.net,
	Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] ARM: SAMSUNG: devs: Add names to fimd0 IRQ resources
Date: Sat, 25 May 2013 06:46:28 +0900	[thread overview]
Message-ID: <519FDFB4.50402@gmail.com> (raw)
In-Reply-To: <1368630584-30147-1-git-send-email-t.figa@samsung.com>

On 05/16/13 00:09, Tomasz Figa wrote:
> Since commit 1977e6d8 (drm/exynos: change the method for getting the
> interrupt) the Exynos DRM FIMD driver requires IRQ resources to be
> named. This patch fixes probe failure in non-DT cases by adding
> appropriate resource names to fimd0 platform device.
>
> Signed-off-by: Tomasz Figa<t.figa@samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
> ---
>   arch/arm/plat-samsung/devs.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> index 30c2fe2..0f9c3f4 100644
> --- a/arch/arm/plat-samsung/devs.c
> +++ b/arch/arm/plat-samsung/devs.c
> @@ -311,9 +311,9 @@ struct platform_device s5p_device_jpeg = {
>   #ifdef CONFIG_S5P_DEV_FIMD0
>   static struct resource s5p_fimd0_resource[] = {
>   	[0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K),
> -	[1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC),
> -	[2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO),
> -	[3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM),
> +	[1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"),
> +	[2] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_FIFO, "fifo"),
> +	[3] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_SYSTEM, "lcd_sys"),
>   };
>
>   struct platform_device s5p_device_fimd0 = {

Applied into fixes.

Thanks.

- Kukjin

WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@gmail.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: SAMSUNG: devs: Add names to fimd0 IRQ resources
Date: Sat, 25 May 2013 06:46:28 +0900	[thread overview]
Message-ID: <519FDFB4.50402@gmail.com> (raw)
In-Reply-To: <1368630584-30147-1-git-send-email-t.figa@samsung.com>

On 05/16/13 00:09, Tomasz Figa wrote:
> Since commit 1977e6d8 (drm/exynos: change the method for getting the
> interrupt) the Exynos DRM FIMD driver requires IRQ resources to be
> named. This patch fixes probe failure in non-DT cases by adding
> appropriate resource names to fimd0 platform device.
>
> Signed-off-by: Tomasz Figa<t.figa@samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
> ---
>   arch/arm/plat-samsung/devs.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> index 30c2fe2..0f9c3f4 100644
> --- a/arch/arm/plat-samsung/devs.c
> +++ b/arch/arm/plat-samsung/devs.c
> @@ -311,9 +311,9 @@ struct platform_device s5p_device_jpeg = {
>   #ifdef CONFIG_S5P_DEV_FIMD0
>   static struct resource s5p_fimd0_resource[] = {
>   	[0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K),
> -	[1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC),
> -	[2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO),
> -	[3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM),
> +	[1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"),
> +	[2] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_FIFO, "fifo"),
> +	[3] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_SYSTEM, "lcd_sys"),
>   };
>
>   struct platform_device s5p_device_fimd0 = {

Applied into fixes.

Thanks.

- Kukjin

  parent reply	other threads:[~2013-05-24 21:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-15 15:09 [PATCH] ARM: SAMSUNG: devs: Add names to fimd0 IRQ resources Tomasz Figa
2013-05-15 15:09 ` Tomasz Figa
2013-05-20 20:01 ` Tomasz Figa
2013-05-20 20:01   ` Tomasz Figa
2013-05-24 21:46 ` Kukjin Kim [this message]
2013-05-24 21:46   ` Kukjin Kim
2013-05-24 21:46 ` Kukjin Kim
2013-05-24 21:46   ` Kukjin Kim
  -- strict thread matches above, loose matches on Subject: below --
2013-05-16  8:12 Jingoo Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519FDFB4.50402@gmail.com \
    --to=kgene.kim@gmail.com \
    --cc=arnd@arndb.de \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=t.figa@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.