From: Michael Tokarev <mjt@tls.msk.ru>
To: Brad Smith <brad@comstyle.com>
Cc: qemu-stable@nongnu.org, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH for 1.5] ui/gtk.c: Fix *BSD build of Gtk+ UI
Date: Sat, 25 May 2013 13:14:59 +0400 [thread overview]
Message-ID: <51A08113.6010903@msgid.tls.msk.ru> (raw)
In-Reply-To: <20130524184737.GA9642@rox.home.comstyle.com>
24.05.2013 22:47, Brad Smith wrote:
>>> +++ b/include/qemu-common.h
>>> #elif defined CONFIG_BSD
>>> +# include <termios.h>
> Kinda late nit picking about it now.
It's not. And it's not nitpicking really, we're
carrying a ton of unnecessary #includes which slows
down compilation significantly.
The whole this piece of #include twist was to get
declaration of openpty() or equivalent. You just
stiffed an unrelated #include into this piece which
was okay to remove completely. I already removed
it from several other .c files where it went from
vl.c originally, which used to have chardev code
which is now in another file.
What was the original issue? Where exactly it was
failing? I mean, where's the _proper_ place to
fix it?
Speaking of "too late" -- it is definitely not late
to fix another bug.
Thanks,
/mjt
next parent reply other threads:[~2013-05-25 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130522223817.GB14845@rox.home.comstyle.com>
[not found] ` <519E3091.2060402@msgid.tls.msk.ru>
[not found] ` <20130524184737.GA9642@rox.home.comstyle.com>
2013-05-25 9:14 ` Michael Tokarev [this message]
2013-06-05 18:22 ` [Qemu-devel] [Qemu-stable] [PATCH for 1.5] ui/gtk.c: Fix *BSD build of Gtk+ UI Brad Smith
2013-06-05 10:13 ` [Qemu-devel] [Qemu] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A08113.6010903@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=brad@comstyle.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.