From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Jiang Liu <jiang.liu@huawei.com>,
Tang Chen <tangchen@cn.fujitsu.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH v2 1/4] mm/memory-hotplug: fix lowmem count overflow when offline pages
Date: Sat, 25 May 2013 21:44:00 -0400 [thread overview]
Message-ID: <51A168E0.3020305@gmail.com> (raw)
In-Reply-To: <51a1642b.077c320a.3884.161cSMTPIN_ADDED_BROKEN@mx.google.com>
(5/25/13 9:23 PM), Wanpeng Li wrote:
> Hi KOSAKI,
> On Sat, May 25, 2013 at 09:16:24PM -0400, KOSAKI Motohiro wrote:
>>> ---
>>> mm/page_alloc.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>>> index 98cbdf6..23b921f 100644
>>> --- a/mm/page_alloc.c
>>> +++ b/mm/page_alloc.c
>>> @@ -6140,6 +6140,8 @@ __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn)
>>> list_del(&page->lru);
>>> rmv_page_order(page);
>>> zone->free_area[order].nr_free--;
>>> + if (PageHighMem(page))
>>> + totalhigh_pages -= 1 << order;
>>> for (i = 0; i < (1 << order); i++)
>>> SetPageReserved((page+i));
>>> pfn += (1 << order);
>>
>> memory hotplug don't support 32bit since it was born, at least, when the system has highmem.
>> Why can't we disable memory hotremove when 32bit at compile time?
>
> Here is logic memory remove instead of ACPI based memory remove. ;-)
I know.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Jiang Liu <jiang.liu@huawei.com>,
Tang Chen <tangchen@cn.fujitsu.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH v2 1/4] mm/memory-hotplug: fix lowmem count overflow when offline pages
Date: Sat, 25 May 2013 21:44:00 -0400 [thread overview]
Message-ID: <51A168E0.3020305@gmail.com> (raw)
In-Reply-To: <51a1642b.077c320a.3884.161cSMTPIN_ADDED_BROKEN@mx.google.com>
(5/25/13 9:23 PM), Wanpeng Li wrote:
> Hi KOSAKI,
> On Sat, May 25, 2013 at 09:16:24PM -0400, KOSAKI Motohiro wrote:
>>> ---
>>> mm/page_alloc.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>>> index 98cbdf6..23b921f 100644
>>> --- a/mm/page_alloc.c
>>> +++ b/mm/page_alloc.c
>>> @@ -6140,6 +6140,8 @@ __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn)
>>> list_del(&page->lru);
>>> rmv_page_order(page);
>>> zone->free_area[order].nr_free--;
>>> + if (PageHighMem(page))
>>> + totalhigh_pages -= 1 << order;
>>> for (i = 0; i < (1 << order); i++)
>>> SetPageReserved((page+i));
>>> pfn += (1 << order);
>>
>> memory hotplug don't support 32bit since it was born, at least, when the system has highmem.
>> Why can't we disable memory hotremove when 32bit at compile time?
>
> Here is logic memory remove instead of ACPI based memory remove. ;-)
I know.
next prev parent reply other threads:[~2013-05-26 1:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 8:42 [PATCH v2 1/4] mm/memory-hotplug: fix lowmem count overflow when offline pages Wanpeng Li
2013-05-23 8:42 ` Wanpeng Li
2013-05-23 8:42 ` [PATCH v2 2/4] mm/pageblock: remove get/set_pageblock_flags Wanpeng Li
2013-05-23 8:42 ` Wanpeng Li
2013-05-23 8:42 ` [PATCH v2 3/4] mm/hugetlb: remove hugetlb_prefault Wanpeng Li
2013-05-23 8:42 ` Wanpeng Li
2013-05-23 8:42 ` [PATCH v2 4/4] mm/hugetlb: use already exist interface huge_page_shift Wanpeng Li
2013-05-23 8:42 ` Wanpeng Li
2013-05-26 1:16 ` [PATCH v2 1/4] mm/memory-hotplug: fix lowmem count overflow when offline pages KOSAKI Motohiro
2013-05-26 1:16 ` KOSAKI Motohiro
2013-05-26 1:23 ` Wanpeng Li
2013-05-26 1:23 ` Wanpeng Li
[not found] ` <51a1642b.077c320a.3884.161cSMTPIN_ADDED_BROKEN@mx.google.com>
2013-05-26 1:44 ` KOSAKI Motohiro [this message]
2013-05-26 1:44 ` KOSAKI Motohiro
2013-05-26 14:29 ` Liu Jiang
2013-05-26 14:29 ` Liu Jiang
2013-05-26 14:59 ` KOSAKI Motohiro
2013-05-26 14:59 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A168E0.3020305@gmail.com \
--to=kosaki.motohiro@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=jiang.liu@huawei.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
--cc=tangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.