From: Chen Gang <gang.chen@asianux.com>
To: tony.luck@intel.com, fenghua.yu@intel.com,
Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-ia64@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: [PATCH] arch: ia64: kernel: flow control, need use 'return' instead of 'break'
Date: Mon, 27 May 2013 14:30:29 +0800 [thread overview]
Message-ID: <51A2FD85.6080808@asianux.com> (raw)
In this case, the original author did not provide the related reason
string for die_if_kernel(), so the 'buf' is not initialized.
The original author wants to generic a 'SIGSEGV' and 'return', not want
to 'break' to fall to die.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/ia64/kernel/traps.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/ia64/kernel/traps.c b/arch/ia64/kernel/traps.c
index f7f9f9c..d3636e6 100644
--- a/arch/ia64/kernel/traps.c
+++ b/arch/ia64/kernel/traps.c
@@ -630,7 +630,7 @@ ia64_fault (unsigned long vector, unsigned long isr, unsigned long ifa,
printk(KERN_ERR " iip - 0x%lx, ifa - 0x%lx, isr - 0x%lx\n",
iip, ifa, isr);
force_sig(SIGSEGV, current);
- break;
+ return;
case 46:
printk(KERN_ERR "Unexpected IA-32 intercept trap (Trap 46)\n");
--
1.7.7.6
WARNING: multiple messages have this Message-ID (diff)
From: Chen Gang <gang.chen@asianux.com>
To: tony.luck@intel.com, fenghua.yu@intel.com,
Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-ia64@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: [PATCH] arch: ia64: kernel: flow control, need use 'return' instead of 'break'
Date: Mon, 27 May 2013 06:30:29 +0000 [thread overview]
Message-ID: <51A2FD85.6080808@asianux.com> (raw)
In this case, the original author did not provide the related reason
string for die_if_kernel(), so the 'buf' is not initialized.
The original author wants to generic a 'SIGSEGV' and 'return', not want
to 'break' to fall to die.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/ia64/kernel/traps.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/ia64/kernel/traps.c b/arch/ia64/kernel/traps.c
index f7f9f9c..d3636e6 100644
--- a/arch/ia64/kernel/traps.c
+++ b/arch/ia64/kernel/traps.c
@@ -630,7 +630,7 @@ ia64_fault (unsigned long vector, unsigned long isr, unsigned long ifa,
printk(KERN_ERR " iip - 0x%lx, ifa - 0x%lx, isr - 0x%lx\n",
iip, ifa, isr);
force_sig(SIGSEGV, current);
- break;
+ return;
case 46:
printk(KERN_ERR "Unexpected IA-32 intercept trap (Trap 46)\n");
--
1.7.7.6
next reply other threads:[~2013-05-27 6:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 6:30 Chen Gang [this message]
2013-05-27 6:30 ` [PATCH] arch: ia64: kernel: flow control, need use 'return' instead of 'break' Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A2FD85.6080808@asianux.com \
--to=gang.chen@asianux.com \
--cc=fenghua.yu@intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.