All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: qemu-trivial@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Anthony Liguori" <aliguori@us.ibm.com>,
	qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON
Date: Mon, 27 May 2013 11:13:24 +0200	[thread overview]
Message-ID: <51A323B4.2000101@redhat.com> (raw)
In-Reply-To: <1369363654-7063-1-git-send-email-lig.fnst@cn.fujitsu.com>

On 05/24/13 04:47, liguang wrote:
> when enable DEBUG_DEBUGCON, there are some message
> printing bugs, so fix them.

I'd suggest to either simply remove the debug printfs or turn them into
tracepoints.

cheers,
  Gerd




WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: qemu-trivial@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Anthony Liguori" <aliguori@us.ibm.com>,
	qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON
Date: Mon, 27 May 2013 11:13:24 +0200	[thread overview]
Message-ID: <51A323B4.2000101@redhat.com> (raw)
In-Reply-To: <1369363654-7063-1-git-send-email-lig.fnst@cn.fujitsu.com>

On 05/24/13 04:47, liguang wrote:
> when enable DEBUG_DEBUGCON, there are some message
> printing bugs, so fix them.

I'd suggest to either simply remove the debug printfs or turn them into
tracepoints.

cheers,
  Gerd

  parent reply	other threads:[~2013-05-27  9:13 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-24  2:47 [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON liguang
2013-05-24  2:47 ` [Qemu-devel] " liguang
2013-05-24  2:47 ` [Qemu-trivial] [PATCH 1/4] debugcon: fix always print "addr=0x0, val=0x0" bug when use DEBUG_DEBUGCON liguang
2013-05-24  2:47   ` [Qemu-devel] " liguang
2013-05-24  2:47 ` [Qemu-trivial] [PATCH 2/4] debugcon: make debug message more readable liguang
2013-05-24  2:47   ` [Qemu-devel] " liguang
2013-05-24  2:47 ` [Qemu-trivial] [PATCH 3/4] debugcon: fix compiler warning when open DEBUG_DEBUGCON liguang
2013-05-24  2:47   ` [Qemu-devel] " liguang
2013-05-24  2:47 ` [Qemu-trivial] [PATCH 4/4] debugcon: use fprintf(stderr...) instead of printf liguang
2013-05-24  2:47   ` [Qemu-devel] " liguang
2013-05-24 11:55   ` [Qemu-trivial] " Andreas Färber
2013-05-24 11:55     ` Andreas Färber
2013-05-25  9:28 ` [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON Michael Tokarev
2013-05-25  9:28   ` [Qemu-devel] " Michael Tokarev
2013-05-25 10:35   ` [Qemu-trivial] [Qemu-devel] " Andreas Färber
2013-05-25 10:35     ` [Qemu-devel] [Qemu-trivial] " Andreas Färber
2013-05-25 10:42     ` [Qemu-trivial] [Qemu-devel] " Michael Tokarev
2013-05-25 10:42       ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-05-27  1:40       ` [Qemu-trivial] [Qemu-devel] " li guang
2013-05-27  1:40         ` [Qemu-devel] [Qemu-trivial] " li guang
2013-05-27 20:42         ` [Qemu-trivial] [Qemu-devel] " Michael Tokarev
2013-05-27 20:42           ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-05-28  0:14           ` [Qemu-trivial] [Qemu-devel] " li guang
2013-05-28  0:14             ` [Qemu-devel] [Qemu-trivial] " li guang
2013-05-27  9:13 ` Gerd Hoffmann [this message]
2013-05-27  9:13   ` [Qemu-devel] " Gerd Hoffmann
2013-05-28  0:31   ` [Qemu-trivial] " li guang
2013-05-28  0:31     ` [Qemu-devel] " li guang
2013-05-28  5:46     ` [Qemu-trivial] " Gerd Hoffmann
2013-05-28  5:46       ` [Qemu-devel] " Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A323B4.2000101@redhat.com \
    --to=kraxel@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=lig.fnst@cn.fujitsu.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.