* [PATCH] arch: mips: ralink: using strlcpy() instead of strncpy()
@ 2013-05-26 8:01 Chen Gang
2013-05-27 10:37 ` John Crispin
0 siblings, 1 reply; 3+ messages in thread
From: Chen Gang @ 2013-05-26 8:01 UTC (permalink / raw)
To: ralf, blogic, juhosg; +Cc: linux-mips, Linux-Arch
'compatible' is used by strlen() in __of_device_is_compatible().
So for NUL terminated string, need always be sure of ended by zero.
'of_ids' is not a structure in "include/uapi/*", so not need initialize
all bytes, just use strlcpy() instead of strncpy().
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/mips/ralink/of.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mips/ralink/of.c b/arch/mips/ralink/of.c
index fb15695..508f28f 100644
--- a/arch/mips/ralink/of.c
+++ b/arch/mips/ralink/of.c
@@ -104,7 +104,7 @@ static int __init plat_of_setup(void)
if (!of_have_populated_dt())
panic("device tree not present");
- strncpy(of_ids[0].compatible, soc_info.compatible, len);
+ strlcpy(of_ids[0].compatible, soc_info.compatible, len);
strncpy(of_ids[1].compatible, "palmbus", len);
if (of_platform_populate(NULL, of_ids, NULL, NULL))
--
1.7.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arch: mips: ralink: using strlcpy() instead of strncpy()
@ 2013-05-27 10:37 ` John Crispin
0 siblings, 0 replies; 3+ messages in thread
From: John Crispin @ 2013-05-27 10:37 UTC (permalink / raw)
Cc: linux-mips
On 26/05/13 10:01, Chen Gang wrote:
> 'compatible' is used by strlen() in __of_device_is_compatible().
>
> So for NUL terminated string, need always be sure of ended by zero.
>
> 'of_ids' is not a structure in "include/uapi/*", so not need initialize
> all bytes, just use strlcpy() instead of strncpy().
>
>
> Signed-off-by: Chen Gang<gang.chen@asianux.com>
Acked-by: John Crispin <blogic@openwrt.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arch: mips: ralink: using strlcpy() instead of strncpy()
@ 2013-05-27 10:37 ` John Crispin
0 siblings, 0 replies; 3+ messages in thread
From: John Crispin @ 2013-05-27 10:37 UTC (permalink / raw)
Cc: linux-mips
On 26/05/13 10:01, Chen Gang wrote:
> 'compatible' is used by strlen() in __of_device_is_compatible().
>
> So for NUL terminated string, need always be sure of ended by zero.
>
> 'of_ids' is not a structure in "include/uapi/*", so not need initialize
> all bytes, just use strlcpy() instead of strncpy().
>
>
> Signed-off-by: Chen Gang<gang.chen@asianux.com>
Acked-by: John Crispin <blogic@openwrt.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-27 10:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-26 8:01 [PATCH] arch: mips: ralink: using strlcpy() instead of strncpy() Chen Gang
2013-05-27 10:37 ` John Crispin
2013-05-27 10:37 ` John Crispin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.