* [Ocfs2-devel] [PATCH] Remove unecessary ERROR when removing non-empty directory
@ 2013-05-20 15:06 Goldwyn Rodrigues
2013-05-22 22:53 ` Sunil Mushran
2013-05-24 6:20 ` xiaowei.hu
0 siblings, 2 replies; 6+ messages in thread
From: Goldwyn Rodrigues @ 2013-05-20 15:06 UTC (permalink / raw)
To: ocfs2-devel
While removing a non-empty directory, the kernel dumps a message:
(rmdir,21743,1):ocfs2_unlink:953 ERROR: status = -39
Suppress the error message from being printed in the dmesg so users
don't panic.
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
---
diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
index 04ee1b5..33c7b91 100644
--- a/fs/ocfs2/namei.c
+++ b/fs/ocfs2/namei.c
@@ -947,7 +947,7 @@ leave:
ocfs2_free_dir_lookup_result(&orphan_insert);
ocfs2_free_dir_lookup_result(&lookup);
- if (status)
+ if (status && (status != -ENOTEMPTY))
mlog_errno(status);
return status;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Ocfs2-devel] [PATCH] Remove unecessary ERROR when removing non-empty directory
2013-05-20 15:06 [Ocfs2-devel] [PATCH] Remove " Goldwyn Rodrigues
@ 2013-05-22 22:53 ` Sunil Mushran
2013-05-24 6:20 ` xiaowei.hu
1 sibling, 0 replies; 6+ messages in thread
From: Sunil Mushran @ 2013-05-22 22:53 UTC (permalink / raw)
To: ocfs2-devel
Acked-by: Sunil Mushran <sunil.mushran@gmail.com>
On Mon, May 20, 2013 at 8:06 AM, Goldwyn Rodrigues <rgoldwyn@gmail.com>wrote:
> While removing a non-empty directory, the kernel dumps a message:
> (rmdir,21743,1):ocfs2_unlink:953 ERROR: status = -39
>
> Suppress the error message from being printed in the dmesg so users
> don't panic.
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> ---
> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
> index 04ee1b5..33c7b91 100644
> --- a/fs/ocfs2/namei.c
> +++ b/fs/ocfs2/namei.c
> @@ -947,7 +947,7 @@ leave:
> ocfs2_free_dir_lookup_result(&orphan_insert);
> ocfs2_free_dir_lookup_result(&lookup);
>
> - if (status)
> + if (status && (status != -ENOTEMPTY))
> mlog_errno(status);
>
> return status;
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20130522/23383a46/attachment.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Ocfs2-devel] [PATCH] Remove unecessary ERROR when removing non-empty directory
2013-05-20 15:06 [Ocfs2-devel] [PATCH] Remove " Goldwyn Rodrigues
2013-05-22 22:53 ` Sunil Mushran
@ 2013-05-24 6:20 ` xiaowei.hu
2013-05-27 6:53 ` Jeff Liu
1 sibling, 1 reply; 6+ messages in thread
From: xiaowei.hu @ 2013-05-24 6:20 UTC (permalink / raw)
To: ocfs2-devel
Should we also add this (status != -ENOTEMPTY) in end of ocfs2_rename?
It also may hit this unecessary error.
Thanks,
xiaowei
On 05/20/2013 11:06 PM, Goldwyn Rodrigues wrote:
> While removing a non-empty directory, the kernel dumps a message:
> (rmdir,21743,1):ocfs2_unlink:953 ERROR: status = -39
>
> Suppress the error message from being printed in the dmesg so users
> don't panic.
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> ---
> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
> index 04ee1b5..33c7b91 100644
> --- a/fs/ocfs2/namei.c
> +++ b/fs/ocfs2/namei.c
> @@ -947,7 +947,7 @@ leave:
> ocfs2_free_dir_lookup_result(&orphan_insert);
> ocfs2_free_dir_lookup_result(&lookup);
>
> - if (status)
> + if (status && (status != -ENOTEMPTY))
> mlog_errno(status);
>
> return status;
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Ocfs2-devel] [PATCH] Remove unecessary ERROR when removing non-empty directory
2013-05-24 6:20 ` xiaowei.hu
@ 2013-05-27 6:53 ` Jeff Liu
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Liu @ 2013-05-27 6:53 UTC (permalink / raw)
To: ocfs2-devel
On 05/24/2013 02:20 PM, xiaowei.hu wrote:
> Should we also add this (status != -ENOTEMPTY) in end of ocfs2_rename?
> It also may hit this unecessary error.
This definitely is the same thing like ocfs2_unlink() that need to be fixed.
Thanks,
-Jeff
>
> Thanks,
> xiaowei
>
> On 05/20/2013 11:06 PM, Goldwyn Rodrigues wrote:
>> While removing a non-empty directory, the kernel dumps a message:
>> (rmdir,21743,1):ocfs2_unlink:953 ERROR: status = -39
>>
>> Suppress the error message from being printed in the dmesg so users
>> don't panic.
>>
>> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
>>
>> ---
>> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
>> index 04ee1b5..33c7b91 100644
>> --- a/fs/ocfs2/namei.c
>> +++ b/fs/ocfs2/namei.c
>> @@ -947,7 +947,7 @@ leave:
>> ocfs2_free_dir_lookup_result(&orphan_insert);
>> ocfs2_free_dir_lookup_result(&lookup);
>>
>> - if (status)
>> + if (status && (status != -ENOTEMPTY))
>> mlog_errno(status);
>>
>> return status;
>>
>> _______________________________________________
>> Ocfs2-devel mailing list
>> Ocfs2-devel at oss.oracle.com
>> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
>>
>>
>
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Ocfs2-devel] [PATCH]Remove unecessary ERROR when removing non-empty directory
@ 2013-05-28 1:12 xiaowei.hu at oracle.com
2013-05-28 11:08 ` Jeff Liu
0 siblings, 1 reply; 6+ messages in thread
From: xiaowei.hu at oracle.com @ 2013-05-28 1:12 UTC (permalink / raw)
To: ocfs2-devel
From: "Xiaowei.Hu" <xiaowei.hu@oracle.com>
Suppress the error message from being printed in ocfs2_rename
Did same thing with Goldwyn Rodrigues last patch.
While removing a non-empty directory, the kernel dumps a message:
(mv,29521,1):ocfs2_rename:1474 ERROR: status = -39
Signed-off-by: Xiaowei Hu <xiaowei.hu@oracle.com>
---
fs/ocfs2/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
index 50c93a8..8ef1776 100644
--- a/fs/ocfs2/namei.c
+++ b/fs/ocfs2/namei.c
@@ -1470,7 +1470,7 @@ bail:
brelse(old_dir_bh);
brelse(new_dir_bh);
- if (status)
+ if (status && (status != -ENOTEMPTY))
mlog_errno(status);
return status;
--
1.7.11.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Ocfs2-devel] [PATCH]Remove unecessary ERROR when removing non-empty directory
2013-05-28 1:12 [Ocfs2-devel] [PATCH]Remove unecessary ERROR when removing non-empty directory xiaowei.hu at oracle.com
@ 2013-05-28 11:08 ` Jeff Liu
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Liu @ 2013-05-28 11:08 UTC (permalink / raw)
To: ocfs2-devel
On 05/28/2013 09:12 AM, xiaowei.hu at oracle.com wrote:
> From: "Xiaowei.Hu" <xiaowei.hu@oracle.com>
>
> Suppress the error message from being printed in ocfs2_rename
> Did same thing with Goldwyn Rodrigues last patch.
>
> While removing a non-empty directory, the kernel dumps a message:
> (mv,29521,1):ocfs2_rename:1474 ERROR: status = -39
>
> Signed-off-by: Xiaowei Hu <xiaowei.hu@oracle.com>
Reviewed-by: Jie Liu <jeff.liu@oracle.com>
>
> ---
> fs/ocfs2/namei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
> index 50c93a8..8ef1776 100644
> --- a/fs/ocfs2/namei.c
> +++ b/fs/ocfs2/namei.c
> @@ -1470,7 +1470,7 @@ bail:
> brelse(old_dir_bh);
> brelse(new_dir_bh);
>
> - if (status)
> + if (status && (status != -ENOTEMPTY))
> mlog_errno(status);
>
> return status;
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-05-28 11:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-28 1:12 [Ocfs2-devel] [PATCH]Remove unecessary ERROR when removing non-empty directory xiaowei.hu at oracle.com
2013-05-28 11:08 ` Jeff Liu
-- strict thread matches above, loose matches on Subject: below --
2013-05-20 15:06 [Ocfs2-devel] [PATCH] Remove " Goldwyn Rodrigues
2013-05-22 22:53 ` Sunil Mushran
2013-05-24 6:20 ` xiaowei.hu
2013-05-27 6:53 ` Jeff Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.