From: gang.chen@asianux.com (Chen Gang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: compiling issue for allmodconfig, need "asm/parport.h" by "drivers/parport/parport_pc.c"
Date: Wed, 29 May 2013 10:06:14 +0800 [thread overview]
Message-ID: <51A56296.1090404@asianux.com> (raw)
In-Reply-To: <20130528170219.GI17912@arm.com>
On 05/29/2013 01:02 AM, Catalin Marinas wrote:
>> >
>> > After check the Kconfig in drivers, we can find quite a few using long
>> > list args which related with ARCH.
>> >
>> > And they are not only depend on ARCHs, but also depend on another
>> > things (e.g. VGA_CONSOL also depend on !4xx && !8xx, and another
>> > combinations).
> Given this dependency is on the negation of that symbol, you just remove
> it and have a "depends on HAVE_VGA_CONSOLE". The few architectures that
> need it will have to define it (X86, ARM with a few configurations).
>
it is "depends on !4xx && !8xx && !SPARC && !M68K && !PARISC && !FRV &&
!SUPERH && !BLACKFIN && !AVR32 && !MN10300 && (!ARM || ARCH_FOOTBRIDGE
|| ARCH_INTEGRATOR || ARCH_NETWINDER)"
So, not only x86, ARM, but also s390, xtensa, alpha, cris, h8300, ia64,
mips... (at least, we do not know, they whether need it or not).
>> > We also can find another long list for depend on, but not related with
>> > ARCH.
>> >
>> > They seems not quit difficult for reading (in fact, if we separate them
>> > into pieces and let them spread into another areas, the reader will not
>> > see the whole dependency clearly)
>> >
>> > For fixing bug, better as local as possible, as independent as possible,
>> > it will be OK if only add !ARM64 for PARPORT_PC depend on, and it has
>> > no any negative effect. But if we define CONFIG_HAVE_*, we have to let
>> > it related with multiple platforms.
>> >
>> > For design: if can bear current design, better not to touch it, I think
>> > current design is still sustainable, and not complex for understanding,
>> > so not need redesign.
> We usually clean some of these as we hit them, otherwise people forget
> about the clean-up later ;).
In fact, I have sent another configuration modification about disabling
CONFIG_BUG. it is in discussing...
We are sure most of architectures do not need CONFIG_BUG, but for
VGA_CONSOLE, we can not be sure most of architectures do not need it.
For CONFIG_BUG issue, it will make noisy for most of architectures, but
for VGA_CONSOLE issue, at least now, it is only effect with arm64.
For CONFIG_BUG issue, it seems we can not provide a satisfied fixing if
not get rid of it, but for VGA_CONSOLE issue, at least we have a
complete fixing way for it.
And now for CONFIG_BUG issue, it is still continuing discussing, and it
seems that can not get a result quickly.
So for VGA_CONSOLE... ;-)
Thanks.
--
Chen Gang
Asianux Corporation
WARNING: multiple messages have this Message-ID (diff)
From: Chen Gang <gang.chen@asianux.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <Will.Deacon@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] arm64: compiling issue for allmodconfig, need "asm/parport.h" by "drivers/parport/parport_pc.c"
Date: Wed, 29 May 2013 10:06:14 +0800 [thread overview]
Message-ID: <51A56296.1090404@asianux.com> (raw)
In-Reply-To: <20130528170219.GI17912@arm.com>
On 05/29/2013 01:02 AM, Catalin Marinas wrote:
>> >
>> > After check the Kconfig in drivers, we can find quite a few using long
>> > list args which related with ARCH.
>> >
>> > And they are not only depend on ARCHs, but also depend on another
>> > things (e.g. VGA_CONSOL also depend on !4xx && !8xx, and another
>> > combinations).
> Given this dependency is on the negation of that symbol, you just remove
> it and have a "depends on HAVE_VGA_CONSOLE". The few architectures that
> need it will have to define it (X86, ARM with a few configurations).
>
it is "depends on !4xx && !8xx && !SPARC && !M68K && !PARISC && !FRV &&
!SUPERH && !BLACKFIN && !AVR32 && !MN10300 && (!ARM || ARCH_FOOTBRIDGE
|| ARCH_INTEGRATOR || ARCH_NETWINDER)"
So, not only x86, ARM, but also s390, xtensa, alpha, cris, h8300, ia64,
mips... (at least, we do not know, they whether need it or not).
>> > We also can find another long list for depend on, but not related with
>> > ARCH.
>> >
>> > They seems not quit difficult for reading (in fact, if we separate them
>> > into pieces and let them spread into another areas, the reader will not
>> > see the whole dependency clearly)
>> >
>> > For fixing bug, better as local as possible, as independent as possible,
>> > it will be OK if only add !ARM64 for PARPORT_PC depend on, and it has
>> > no any negative effect. But if we define CONFIG_HAVE_*, we have to let
>> > it related with multiple platforms.
>> >
>> > For design: if can bear current design, better not to touch it, I think
>> > current design is still sustainable, and not complex for understanding,
>> > so not need redesign.
> We usually clean some of these as we hit them, otherwise people forget
> about the clean-up later ;).
In fact, I have sent another configuration modification about disabling
CONFIG_BUG. it is in discussing...
We are sure most of architectures do not need CONFIG_BUG, but for
VGA_CONSOLE, we can not be sure most of architectures do not need it.
For CONFIG_BUG issue, it will make noisy for most of architectures, but
for VGA_CONSOLE issue, at least now, it is only effect with arm64.
For CONFIG_BUG issue, it seems we can not provide a satisfied fixing if
not get rid of it, but for VGA_CONSOLE issue, at least we have a
complete fixing way for it.
And now for CONFIG_BUG issue, it is still continuing discussing, and it
seems that can not get a result quickly.
So for VGA_CONSOLE... ;-)
Thanks.
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-05-29 2:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 3:44 [PATCH] arm64: compiling issue, need add include/asm/vga.h file Chen Gang
2013-04-24 3:44 ` Chen Gang
2013-04-24 8:22 ` Catalin Marinas
2013-04-24 8:22 ` Catalin Marinas
2013-04-24 8:44 ` Chen Gang
2013-04-24 8:44 ` Chen Gang
2013-04-24 10:20 ` [PATCH v2] " Chen Gang
2013-04-24 10:20 ` Chen Gang
2013-04-24 10:23 ` Will Deacon
2013-04-24 10:23 ` Will Deacon
2013-04-24 10:50 ` Chen Gang
2013-04-24 10:50 ` Chen Gang
2013-04-24 10:58 ` [PATCH v3] " Chen Gang
2013-04-24 10:58 ` Chen Gang
2013-04-24 11:05 ` Catalin Marinas
2013-04-24 11:05 ` Catalin Marinas
2013-04-24 11:06 ` Chen Gang
2013-04-24 11:06 ` Chen Gang
2013-05-20 4:19 ` [PATCH] arm64: compiling issue for allmodconfig, need "asm/parport.h" by "drivers/parport/parport_pc.c" Chen Gang
2013-05-20 4:19 ` Chen Gang
2013-05-21 13:17 ` Catalin Marinas
2013-05-21 13:17 ` Catalin Marinas
2013-05-22 0:45 ` Chen Gang
2013-05-22 0:45 ` Chen Gang
2013-05-22 7:32 ` Chen Gang
2013-05-22 7:32 ` Chen Gang
2013-05-28 17:02 ` Catalin Marinas
2013-05-28 17:02 ` Catalin Marinas
2013-05-29 2:06 ` Chen Gang [this message]
2013-05-29 2:06 ` Chen Gang
2013-04-24 10:42 ` [PATCH v2] arm64: compiling issue, need add include/asm/vga.h file Catalin Marinas
2013-04-24 10:42 ` Catalin Marinas
2013-04-24 10:51 ` Chen Gang
2013-04-24 10:51 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A56296.1090404@asianux.com \
--to=gang.chen@asianux.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.