From: Libo Chen <clbchenlibo.chen@huawei.com>
To: timur@tabi.org, Greg KH <gregkh@linuxfoundation.org>
Cc: jslaby@suse.cz, Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Li Zefan <lizefan@huawei.com>
Subject: [PATCH] driver: tty: add missing unregister in err case
Date: Wed, 29 May 2013 10:33:16 +0800 [thread overview]
Message-ID: <51A568EC.2070103@huawei.com> (raw)
when platform_driver_register broken, we should unregister ucc_uart_driver
Signed-off-by: Libo chen <libo.chen@huawei.com>
---
drivers/tty/serial/ucc_uart.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c
index 7355303..f86f447 100644
--- a/drivers/tty/serial/ucc_uart.c
+++ b/drivers/tty/serial/ucc_uart.c
@@ -1518,9 +1518,11 @@ static int __init ucc_uart_init(void)
}
ret = platform_driver_register(&ucc_uart_of_driver);
- if (ret)
+ if (ret) {
printk(KERN_ERR
"ucc-uart: could not register platform driver\n");
+ uart_unregister_driver(&ucc_uart_driver);
+ }
return ret;
}
--
1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: Libo Chen <clbchenlibo.chen@huawei.com>
To: <timur@tabi.org>, Greg KH <gregkh@linuxfoundation.org>
Cc: jslaby@suse.cz, linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
Li Zefan <lizefan@huawei.com>,
linux-serial@vger.kernel.org,
Grant Likely <grant.likely@linaro.org>,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH] driver: tty: add missing unregister in err case
Date: Wed, 29 May 2013 10:33:16 +0800 [thread overview]
Message-ID: <51A568EC.2070103@huawei.com> (raw)
when platform_driver_register broken, we should unregister ucc_uart_driver
Signed-off-by: Libo chen <libo.chen@huawei.com>
---
drivers/tty/serial/ucc_uart.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c
index 7355303..f86f447 100644
--- a/drivers/tty/serial/ucc_uart.c
+++ b/drivers/tty/serial/ucc_uart.c
@@ -1518,9 +1518,11 @@ static int __init ucc_uart_init(void)
}
ret = platform_driver_register(&ucc_uart_of_driver);
- if (ret)
+ if (ret) {
printk(KERN_ERR
"ucc-uart: could not register platform driver\n");
+ uart_unregister_driver(&ucc_uart_driver);
+ }
return ret;
}
--
1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: Libo Chen <clbchenlibo.chen@huawei.com>
To: <timur@tabi.org>, Greg KH <gregkh@linuxfoundation.org>
Cc: <jslaby@suse.cz>, Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
<linux-serial@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
<linux-kernel@vger.kernel.org>, Li Zefan <lizefan@huawei.com>
Subject: [PATCH] driver: tty: add missing unregister in err case
Date: Wed, 29 May 2013 10:33:16 +0800 [thread overview]
Message-ID: <51A568EC.2070103@huawei.com> (raw)
when platform_driver_register broken, we should unregister ucc_uart_driver
Signed-off-by: Libo chen <libo.chen@huawei.com>
---
drivers/tty/serial/ucc_uart.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c
index 7355303..f86f447 100644
--- a/drivers/tty/serial/ucc_uart.c
+++ b/drivers/tty/serial/ucc_uart.c
@@ -1518,9 +1518,11 @@ static int __init ucc_uart_init(void)
}
ret = platform_driver_register(&ucc_uart_of_driver);
- if (ret)
+ if (ret) {
printk(KERN_ERR
"ucc-uart: could not register platform driver\n");
+ uart_unregister_driver(&ucc_uart_driver);
+ }
return ret;
}
--
1.7.1
next reply other threads:[~2013-05-29 2:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 2:33 Libo Chen [this message]
2013-05-29 2:33 ` [PATCH] driver: tty: add missing unregister in err case Libo Chen
2013-05-29 2:33 ` Libo Chen
2013-05-29 2:37 ` Timur Tabi
2013-05-29 2:37 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A568EC.2070103@huawei.com \
--to=clbchenlibo.chen@huawei.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lizefan@huawei.com \
--cc=rob.herring@calxeda.com \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.