From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Wolfgang Denk <wd-ynQEQJNshbs@public.gmane.org>
Cc: u-boot-review-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
Devicetree Discuss
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
U-Boot Mailing List
<u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org>,
Tom Warren <twarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Tom Rini <trini-l0cyMroinI0@public.gmane.org>
Subject: Re: [U-Boot] [PATCH] fdt: Enhance dts/Makefile to be all things to all men
Date: Wed, 29 May 2013 11:02:45 -0600 [thread overview]
Message-ID: <51A634B5.5060309@wwwdotorg.org> (raw)
In-Reply-To: <20130528210829.850203831A2-C2Gvrrd9BC/j/ljBK/0BTg@public.gmane.org>
On 05/28/2013 03:08 PM, Wolfgang Denk wrote:
> Dear Simon Glass,
>
> In message <1369769778-12455-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> you wrote:
>>
>> Some device tree files use the word 'linux' which gets replaced with '1' by
>> many version of gcc, including version 4.7. So undefine this.
>
> I think this is not a good way to address this issue. The GCC
> documentation (section "System-specific Predefined Macros" [1])
> desribes how this should be handled. The "correct" (TM) way to fix
> this is by adding "-ansi" or any "-std" option that requests strict
> conformance to the compiler/preprocessor command line.
>
> [1] http://gcc.gnu.org/onlinedocs/cpp/System_002dspecific-Predefined-Macros.html#System_002dspecific-Predefined-Macros
-ansi at least was considered when the Linux kernel patches for dtc+cpp
support were being developed, but it was rejected. While it possibly
does solve this specific issue fine, there were other more general
problems; IIRC (and I might not) it completely changes the way macro
expansion happens, which results in it being pretty useless. Hence, "-x
assembler-with-cpp" was chosen over e.g. "-ansi".
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fdt: Enhance dts/Makefile to be all things to all men
Date: Wed, 29 May 2013 11:02:45 -0600 [thread overview]
Message-ID: <51A634B5.5060309@wwwdotorg.org> (raw)
In-Reply-To: <20130528210829.850203831A2@gemini.denx.de>
On 05/28/2013 03:08 PM, Wolfgang Denk wrote:
> Dear Simon Glass,
>
> In message <1369769778-12455-1-git-send-email-sjg@chromium.org> you wrote:
>>
>> Some device tree files use the word 'linux' which gets replaced with '1' by
>> many version of gcc, including version 4.7. So undefine this.
>
> I think this is not a good way to address this issue. The GCC
> documentation (section "System-specific Predefined Macros" [1])
> desribes how this should be handled. The "correct" (TM) way to fix
> this is by adding "-ansi" or any "-std" option that requests strict
> conformance to the compiler/preprocessor command line.
>
> [1] http://gcc.gnu.org/onlinedocs/cpp/System_002dspecific-Predefined-Macros.html#System_002dspecific-Predefined-Macros
-ansi at least was considered when the Linux kernel patches for dtc+cpp
support were being developed, but it was rejected. While it possibly
does solve this specific issue fine, there were other more general
problems; IIRC (and I might not) it completely changes the way macro
expansion happens, which results in it being pretty useless. Hence, "-x
assembler-with-cpp" was chosen over e.g. "-ansi".
next prev parent reply other threads:[~2013-05-29 17:02 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 19:36 [PATCH] fdt: Enhance dts/Makefile to be all things to all men Simon Glass
2013-05-28 19:36 ` [U-Boot] " Simon Glass
2013-05-28 19:53 ` Tom Warren
2013-05-28 19:53 ` [U-Boot] " Tom Warren
[not found] ` <1369769778-12455-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2013-05-28 20:57 ` Stephen Warren
2013-05-28 20:57 ` [U-Boot] " Stephen Warren
[not found] ` <51A51A50.4050308-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-05-29 15:59 ` Simon Glass
2013-05-29 15:59 ` [U-Boot] " Simon Glass
[not found] ` <CAPnjgZ04BKhQtpJct9tvN8rW5Wae+6fxxOOQDnEkmgrr-mAfwg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-29 16:40 ` Stephen Warren
2013-05-29 16:40 ` [U-Boot] " Stephen Warren
[not found] ` <51A62F8D.9010208-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-05-29 21:31 ` Wolfgang Denk
2013-05-29 21:31 ` Wolfgang Denk
[not found] ` <20130529213145.698353831A5-C2Gvrrd9BC/j/ljBK/0BTg@public.gmane.org>
2013-05-29 22:18 ` Stephen Warren
2013-05-29 22:18 ` Stephen Warren
[not found] ` <51A67EC1.2000208-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-05-29 22:36 ` Wolfgang Denk
2013-05-29 22:36 ` Wolfgang Denk
[not found] ` <20130529223621.8B147383069-C2Gvrrd9BC/j/ljBK/0BTg@public.gmane.org>
2013-05-29 23:07 ` Stephen Warren
2013-05-29 23:07 ` Stephen Warren
[not found] ` <51A68A4C.4060505-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-05-30 4:46 ` Simon Glass
2013-05-30 4:46 ` Simon Glass
[not found] ` <CAPnjgZ2_dR90CDtihSun3Yu7_i8TVpxn85XMFQRmzNJeRzDSmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-30 5:11 ` Stephen Warren
2013-05-30 5:11 ` Stephen Warren
[not found] ` <51A6DF7C.30903-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-05-30 5:33 ` Simon Glass
2013-05-30 5:33 ` Simon Glass
2013-05-30 7:56 ` Wolfgang Denk
2013-05-30 7:56 ` Wolfgang Denk
2013-05-30 17:38 ` Stephen Warren
2013-05-30 17:38 ` [U-Boot] " Stephen Warren
2013-05-30 7:49 ` Wolfgang Denk
2013-05-30 7:49 ` Wolfgang Denk
2013-05-28 21:08 ` Wolfgang Denk
2013-05-28 21:08 ` Wolfgang Denk
2013-05-29 16:00 ` Simon Glass
2013-05-29 16:00 ` [U-Boot] " Simon Glass
[not found] ` <CAPnjgZ2a+qrsPWTz5Y=48m_LCRqAikY0-seJudW8AY5asdwmxw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-29 21:02 ` Wolfgang Denk
2013-05-29 21:02 ` Wolfgang Denk
[not found] ` <20130528210829.850203831A2-C2Gvrrd9BC/j/ljBK/0BTg@public.gmane.org>
2013-05-29 17:02 ` Stephen Warren [this message]
2013-05-29 17:02 ` Stephen Warren
[not found] ` <51A634B5.5060309-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-05-29 21:33 ` Wolfgang Denk
2013-05-29 21:33 ` Wolfgang Denk
[not found] ` <20130529213347.821AE3831A5-C2Gvrrd9BC/j/ljBK/0BTg@public.gmane.org>
2013-05-29 22:52 ` Stephen Warren
2013-05-29 22:52 ` Stephen Warren
[not found] ` <51A6869F.1020004-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-05-30 7:05 ` Wolfgang Denk
2013-05-30 7:05 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A634B5.5060309@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=trini-l0cyMroinI0@public.gmane.org \
--cc=twarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org \
--cc=u-boot-review-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=wd-ynQEQJNshbs@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.