All of lore.kernel.org
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/5] rtc-at91rm9200: add shadow interrupt mask
Date: Thu, 30 May 2013 09:50:27 +0200	[thread overview]
Message-ID: <51A704C3.6010109@atmel.com> (raw)
In-Reply-To: <CAOCHtYiK8Y6iTnb4dWAE+cKHqEta-64gj+PorSFVGBF5wmg1+Q@mail.gmail.com>

On 29/05/2013 22:41, Robert Nelson :
> On Wed, May 29, 2013 at 3:33 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
>> On Thu, 23 May 2013 10:38:50 +0200 Johan Hovold <jhovold@gmail.com> wrote:
>>
>>> This is an update of the shadow-interrupt-mask series against v3.10-rc2.
>>>
>>> I guess we need Atmel to confirm that all sam9x5 SoCs are indeed
>>> affected. If not, then some probing mechanism as the one Doug suggested
>>> could be implemented on top of (a subset of) these patches. What do you
>>> say, Nicolas?
>>>
>>> Note that the first patch (adding a missing OF compile guard) could be
>>> applied straight away.
>>
>> At this stage it is unclear to me how to proceed with patches 2-5.
>
> fyi:
>
> A version of these patches had been applied once before:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=0ef1594c017521ea89278e80fe3f80dafb17abde
>
> But due to a few issues it was later reverted:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e24b0bfa2f0446ffaad2661040be23668133aef8

This new revision doesn't have the issue encountered by first version.

Andrew,

The review of this patch series was in my TODO list for some time...

Today, I magically took time to review it ;-)
The patch series is good and I (even if it is too late) here is my:

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

I do not know if the series can be stacked for inclusion in 3.10-rc but 
the resolution of this bug can help a lot (as Douglas is saying in 
subsequent email...).

Best regards,
-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Robert Nelson <robertcnelson@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Johan Hovold <jhovold@gmail.com>
Cc: Robert Nelson <Robert.Nelson@digikey.com>,
	<linux-kernel@vger.kernel.org>,
	Ludovic Desroches <ludovic.desroches@atmel.com>,
	Douglas Gilbert <dgilbert@interlog.com>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 0/5] rtc-at91rm9200: add shadow interrupt mask
Date: Thu, 30 May 2013 09:50:27 +0200	[thread overview]
Message-ID: <51A704C3.6010109@atmel.com> (raw)
In-Reply-To: <CAOCHtYiK8Y6iTnb4dWAE+cKHqEta-64gj+PorSFVGBF5wmg1+Q@mail.gmail.com>

On 29/05/2013 22:41, Robert Nelson :
> On Wed, May 29, 2013 at 3:33 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
>> On Thu, 23 May 2013 10:38:50 +0200 Johan Hovold <jhovold@gmail.com> wrote:
>>
>>> This is an update of the shadow-interrupt-mask series against v3.10-rc2.
>>>
>>> I guess we need Atmel to confirm that all sam9x5 SoCs are indeed
>>> affected. If not, then some probing mechanism as the one Doug suggested
>>> could be implemented on top of (a subset of) these patches. What do you
>>> say, Nicolas?
>>>
>>> Note that the first patch (adding a missing OF compile guard) could be
>>> applied straight away.
>>
>> At this stage it is unclear to me how to proceed with patches 2-5.
>
> fyi:
>
> A version of these patches had been applied once before:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=0ef1594c017521ea89278e80fe3f80dafb17abde
>
> But due to a few issues it was later reverted:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e24b0bfa2f0446ffaad2661040be23668133aef8

This new revision doesn't have the issue encountered by first version.

Andrew,

The review of this patch series was in my TODO list for some time...

Today, I magically took time to review it ;-)
The patch series is good and I (even if it is too late) here is my:

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

I do not know if the series can be stacked for inclusion in 3.10-rc but 
the resolution of this bug can help a lot (as Douglas is saying in 
subsequent email...).

Best regards,
-- 
Nicolas Ferre

  parent reply	other threads:[~2013-05-30  7:50 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-29 16:03 [RFC 1/5] rtc-at91rm9200: add configuration support Johan Hovold
2013-03-29 16:03 ` Johan Hovold
2013-03-29 16:03 ` [RFC 2/5] rtc-at91rm9200: add device-tree support Johan Hovold
2013-03-29 16:12   ` Johan Hovold
2013-03-29 16:12     ` Johan Hovold
2013-03-29 16:03 ` [RFC 3/5] rtc-at91rm9200: refactor interrupt-register handling Johan Hovold
2013-03-29 16:03 ` [RFC 4/5] rtc-at91rm9200: add shadow interrupt mask Johan Hovold
2013-03-29 16:03 ` [RFC 5/5] rtc-at91rm9200: add support for at91sam9x5 Johan Hovold
2013-03-29 16:39   ` Douglas Gilbert
2013-03-29 16:39     ` Douglas Gilbert
2013-04-02 13:06   ` [RFC PATCH] rtc: rtc-at91rm9200: manage IMR depending on revision Nicolas Ferre
2013-04-02 13:06     ` Nicolas Ferre
2013-04-02 15:32     ` Douglas Gilbert
2013-04-02 15:32       ` Douglas Gilbert
2013-04-02 16:28       ` Nicolas Ferre
2013-04-02 16:28         ` Nicolas Ferre
2013-04-02 16:36     ` [RFC PATCH v2] " Nicolas Ferre
2013-04-02 16:36       ` Nicolas Ferre
2013-04-03  9:51       ` Johan Hovold
2013-04-03  9:51         ` Johan Hovold
2013-04-03  9:54         ` [PATCH] Revert "drivers/rtc/rtc-at91rm9200.c: use a variable for storing IMR" Johan Hovold
2013-04-03  9:54           ` Johan Hovold
2013-04-03 10:03           ` [RFC v2 0/4] rtc-at91rm9200: add support for at91sam9x5 Johan Hovold
2013-04-03 10:03             ` [RFC v2 1/4] rtc-at91rm9200: add configuration support Johan Hovold
2013-04-03 10:03             ` [RFC v2 2/4] rtc-at91rm9200: refactor interrupt-register handling Johan Hovold
2013-04-03 10:03             ` [RFC v2 3/4] rtc-at91rm9200: add shadow interrupt mask Johan Hovold
2013-04-03 10:03             ` [RFC v2 4/4] rtc-at91rm9200: add support for at91sam9x5 Johan Hovold
2013-05-23  8:38             ` [PATCH v3 0/5] rtc-at91rm9200: add shadow interrupt mask Johan Hovold
2013-05-23  8:38               ` Johan Hovold
2013-05-23  8:38               ` [PATCH v3 1/5] rtc-at91rm9200: add match-table compile guard Johan Hovold
2013-05-23  8:38                 ` Johan Hovold
2013-05-23  8:38               ` [PATCH v3 2/5] rtc-at91rm9200: add configuration support Johan Hovold
2013-05-23  8:38                 ` Johan Hovold
2013-05-23  8:38               ` [PATCH v3 3/5] rtc-at91rm9200: refactor interrupt-register handling Johan Hovold
2013-05-23  8:38                 ` Johan Hovold
2013-05-23  8:38               ` [PATCH v3 4/5] rtc-at91rm9200: add shadow interrupt mask Johan Hovold
2013-05-23  8:38                 ` Johan Hovold
2013-05-23  8:38               ` [PATCH v3 5/5] rtc-at91rm9200: use shadow IMR on at91sam9x5 Johan Hovold
2013-05-23  8:38                 ` Johan Hovold
2013-05-29 20:33               ` [PATCH v3 0/5] rtc-at91rm9200: add shadow interrupt mask Andrew Morton
2013-05-29 20:33                 ` Andrew Morton
2013-05-29 20:41                 ` Robert Nelson
2013-05-29 20:41                   ` Robert Nelson
2013-05-29 23:22                   ` Douglas Gilbert
2013-05-29 23:22                     ` Douglas Gilbert
2013-05-30  8:18                     ` Nicolas Ferre
2013-05-30  8:18                       ` Nicolas Ferre
2013-05-30  7:50                   ` Nicolas Ferre [this message]
2013-05-30  7:50                     ` Nicolas Ferre
2013-05-30 19:36                     ` Andrew Morton
2013-05-30 19:36                       ` Andrew Morton
2013-05-30 23:17                       ` Douglas Gilbert
2013-05-30 23:17                         ` Douglas Gilbert
2013-05-31  7:54                         ` Nicolas Ferre
2013-05-31  7:54                           ` Nicolas Ferre
2013-05-30  7:41               ` Nicolas Ferre
2013-05-30  7:41                 ` Nicolas Ferre
2013-04-03 10:18           ` [PATCH] Revert "drivers/rtc/rtc-at91rm9200.c: use a variable for storing IMR" Nicolas Ferre
2013-04-03 10:18             ` Nicolas Ferre
2013-04-05 14:14             ` Nicolas Ferre
2013-04-05 14:14               ` Nicolas Ferre
2013-04-05 15:35               ` Greg KH
2013-04-05 15:35                 ` Greg KH
2013-04-05 16:16                 ` Nicolas Ferre
2013-04-05 16:16                   ` Nicolas Ferre
2013-04-03 10:37         ` [RFC PATCH v2] rtc: rtc-at91rm9200: manage IMR depending on revision Nicolas Ferre
2013-04-03 10:37           ` Nicolas Ferre
2013-04-03 13:46           ` Johan Hovold
2013-04-03 13:46             ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A704C3.6010109@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.