From: "Egger, Christoph" <chegger@amazon.de>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] build: disable building kernel subsystem by default.
Date: Thu, 30 May 2013 12:32:22 +0200 [thread overview]
Message-ID: <51A72AB6.5000807@amazon.de> (raw)
In-Reply-To: <1369904954-13283-1-git-send-email-ian.campbell@citrix.com>
On 30.05.13 11:09, Ian Campbell wrote:
> This support is obsolete and harks back to the days of out of tree Linux
> kernel trees.
>
> I think this could really be deleted entirely but for 4.3 lets just disable.
> The list of kernels to build is empty by default anyway.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Cc: Christoph Egger <chegger@amazon.de>
> Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
> Cc: George Dunlap <george.dunlap@eu.citrix.com>
Acked-by: Christoph Egger <chegger@amazon.de>
> ---
> As well as George's release Ack this needs confirmation from Ian J that it
> isn't going to confuse the test system.
> ---
> Makefile | 2 +-
> configure | 5 ++---
> configure.ac | 2 +-
> 3 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 5a7107e..e47f29c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -7,7 +7,7 @@
> all: dist
>
> -include config/Toplevel.mk
> -SUBSYSTEMS?=xen kernels tools stubdom docs
> +SUBSYSTEMS?=xen tools stubdom docs
> TARGS_DIST=$(patsubst %, dist-%, $(SUBSYSTEMS))
> TARGS_INSTALL=$(patsubst %, install-%, $(SUBSYSTEMS))
>
> diff --git a/configure b/configure
> index d15b539..07cac69 100755
> --- a/configure
> +++ b/configure
> @@ -1245,7 +1245,7 @@ Optional Features:
> --disable-FEATURE do not include FEATURE (same as --enable-FEATURE=no)
> --enable-FEATURE[=ARG] include FEATURE [ARG=yes]
> --disable-xen Disable build and install of xen
> - --disable-kernels Disable build and install of kernels
> + --enable-kernels Enable build and install of kernels
> --disable-tools Disable build and install of tools
> --enable-stubdom Enable build and install of stubdom
> --disable-docs Disable build and install of docs
> @@ -1892,8 +1892,7 @@ fi
> else
>
>
> -kernels=y
> -SUBSYSTEMS="$SUBSYSTEMS kernels"
> +kernels=n
>
>
> fi
> diff --git a/configure.ac b/configure.ac
> index ce06dad..1164fbf 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -23,7 +23,7 @@ case "$host_cpu" in
> esac
>
> AX_SUBSYSTEM_DEFAULT_ENABLE([xen])
> -AX_SUBSYSTEM_DEFAULT_ENABLE([kernels])
> +AX_SUBSYSTEM_DEFAULT_DISABLE([kernels])
> AX_SUBSYSTEM_DEFAULT_ENABLE([tools])
> AX_SUBSYSTEM_CONDITIONAL([stubdom], $arch_enable_stubdom)
> AX_SUBSYSTEM_DEFAULT_ENABLE([docs])
>
next prev parent reply other threads:[~2013-05-30 10:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 14:05 [PATCH] build system: build kernels subsystem on Linux only Christoph Egger
2013-05-15 14:36 ` Ian Campbell
2013-05-30 9:09 ` [PATCH] build: disable building kernel subsystem by default Ian Campbell
2013-05-30 9:40 ` George Dunlap
2013-05-30 10:03 ` Ian Campbell
2013-05-30 10:32 ` Egger, Christoph [this message]
2013-05-30 11:22 ` Ian Jackson
2013-05-30 11:25 ` Ian Campbell
2013-05-30 11:40 ` Ian Jackson
2013-05-30 11:44 ` Ian Campbell
2013-05-30 13:18 ` Ian Jackson
2013-05-30 12:36 ` Christoph Egger
2013-05-30 13:02 ` Ian Campbell
2013-05-30 13:18 ` Pasi Kärkkäinen
2013-05-30 13:34 ` Ian Campbell
2013-05-30 13:59 ` Pasi Kärkkäinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A72AB6.5000807@amazon.de \
--to=chegger@amazon.de \
--cc=Ian.Jackson@eu.citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.