* [PATCH] tools/libxl: fix array subscript has type 'char'
@ 2013-05-30 12:06 Christoph Egger
2013-05-30 12:10 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Egger @ 2013-05-30 12:06 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Jackson, Ian Campbell
[-- Attachment #1: Type: text/plain, Size: 721 bytes --]
commit cad172d7b88bd443c81d865051297875ce2551bc
Author: Christoph Egger <chegger@amazon.de>
Date: Thu Feb 7 14:42:29 2013 +0000
tools/libxl: fix array subscript has type 'char'
Signed-off-by: Christoph Egger <chegger@amazon.de>
Reviewed-by: Matt Wilson <msw@amazon.com>
diff --git a/tools/libxl/libxl_utils.c b/tools/libxl/libxl_utils.c
index 35da71c..0c039b1 100644
--- a/tools/libxl/libxl_utils.c
+++ b/tools/libxl/libxl_utils.c
@@ -95,7 +95,7 @@ int libxl_domain_qualifier_to_domid(libxl_ctx *ctx,
const char *name,
{
int i, rv;
for (i=0; name[i]; i++) {
- if (!isdigit(name[i])) {
+ if (!isdigit((unsigned char)name[i])) {
goto nondigit_found;
}
}
[-- Attachment #2: patch_libxl.diff --]
[-- Type: text/plain, Size: 721 bytes --]
commit cad172d7b88bd443c81d865051297875ce2551bc
Author: Christoph Egger <chegger@amazon.de>
Date: Thu Feb 7 14:42:29 2013 +0000
tools/libxl: fix array subscript has type 'char'
Signed-off-by: Christoph Egger <chegger@amazon.de>
Reviewed-by: Matt Wilson <msw@amazon.com>
diff --git a/tools/libxl/libxl_utils.c b/tools/libxl/libxl_utils.c
index 35da71c..0c039b1 100644
--- a/tools/libxl/libxl_utils.c
+++ b/tools/libxl/libxl_utils.c
@@ -95,7 +95,7 @@ int libxl_domain_qualifier_to_domid(libxl_ctx *ctx, const char *name,
{
int i, rv;
for (i=0; name[i]; i++) {
- if (!isdigit(name[i])) {
+ if (!isdigit((unsigned char)name[i])) {
goto nondigit_found;
}
}
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/libxl: fix array subscript has type 'char'
2013-05-30 12:06 [PATCH] tools/libxl: fix array subscript has type 'char' Christoph Egger
@ 2013-05-30 12:10 ` Ian Campbell
2013-05-30 12:12 ` Egger, Christoph
0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2013-05-30 12:10 UTC (permalink / raw)
To: Christoph Egger; +Cc: Ian Jackson, xen-devel
On Thu, 2013-05-30 at 14:06 +0200, Christoph Egger wrote:
> commit cad172d7b88bd443c81d865051297875ce2551bc
> Author: Christoph Egger <chegger@amazon.de>
> Date: Thu Feb 7 14:42:29 2013 +0000
>
> tools/libxl: fix array subscript has type 'char'
Please use the CTYPE macro from libxl_internal.h.
Ian.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/libxl: fix array subscript has type 'char'
2013-05-30 12:10 ` Ian Campbell
@ 2013-05-30 12:12 ` Egger, Christoph
0 siblings, 0 replies; 3+ messages in thread
From: Egger, Christoph @ 2013-05-30 12:12 UTC (permalink / raw)
To: Ian Campbell; +Cc: Ian Jackson, xen-devel
On 30.05.13 14:10, Ian Campbell wrote:
> On Thu, 2013-05-30 at 14:06 +0200, Christoph Egger wrote:
>> commit cad172d7b88bd443c81d865051297875ce2551bc
>> Author: Christoph Egger <chegger@amazon.de>
>> Date: Thu Feb 7 14:42:29 2013 +0000
>>
>> tools/libxl: fix array subscript has type 'char'
>
> Please use the CTYPE macro from libxl_internal.h.
Oh, ok. I completely missend when that was introduced.
Christoph
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-30 12:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-30 12:06 [PATCH] tools/libxl: fix array subscript has type 'char' Christoph Egger
2013-05-30 12:10 ` Ian Campbell
2013-05-30 12:12 ` Egger, Christoph
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.