From: "Egger, Christoph" <chegger@amazon.de>
To: Miguel Clara <miguelmclara@gmail.com>
Cc: xen-devel@lists.xensource.com, Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: tools/misc/xencov.c: build failure on NetBSD
Date: Thu, 30 May 2013 14:43:26 +0200 [thread overview]
Message-ID: <51A7496E.2060600@amazon.de> (raw)
In-Reply-To: <CADGo8CVrOCO8is4Rx-+qPTV9AfpY2PZKNR8iyBq0quCb3M9i0w@mail.gmail.com>
On 23.05.13 12:59, Miguel Clara wrote:
> For now I simply added the code to tools/misc/xencov.c
>
> Not sure if its the best way to do it.
>
> On Thu, May 23, 2013 at 10:13 AM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
>> On Wed, 2013-05-22 at 23:43 +0000, Miguel Clara wrote:
>>> Christoph Egger <chegger <at> amazon.de> writes:
>>>
>>>>
>>>> Hi,
>>>>
>>>> tools/misc/xencov.c fails to build.
>>>> NetBSD does not have MAP_LOCKED.
>>>>
>>>> Christoph
>>>>
>>>
>>> I wanted to test 4.3 on NetBSD but ended up with this problem too... In fact
>>> this happened before in other parts of the code...
>>> http://lists.xen.org/archives/html/xen-devel/2012-06/msg00576.html
>>>
>>> I guess this would fix it...
>>
>> Please can you confirm and if so submit a patch
>>
>> See http://wiki.xen.org/wiki/Submitting_Xen_Patches for some hints on
>> how to do that.
>>
>>>
>>> #ifdef __NetBSD__
>>> /* MAP_LOCKED is Linux specific. MAP_WIRED is NetBSD's equivalent. */
>>> #define MAP_LOCKED MAP_WIRED
>>> #endif
>>>
>>> Sadly I came across another error, still searching if it was already posted,
>>> otherwise I will!
I send this as a proper patch. Please add your Signed-off-by.
Christoph
prev parent reply other threads:[~2013-05-30 12:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 13:04 tools/misc/xencov.c: build failure on NetBSD Christoph Egger
2013-05-22 23:43 ` Miguel Clara
2013-05-23 1:04 ` Miguel Clara
2013-05-23 9:14 ` Ian Campbell
2013-05-23 11:02 ` Miguel Clara
2013-05-23 9:13 ` Ian Campbell
2013-05-23 10:59 ` Miguel Clara
2013-05-30 12:43 ` Egger, Christoph [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A7496E.2060600@amazon.de \
--to=chegger@amazon.de \
--cc=Ian.Campbell@citrix.com \
--cc=miguelmclara@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.