* [Ocfs2-devel] [PATCH] ocfs2: Add missing dlm_put() in dlm_begin_reco_handler
@ 2013-05-31 5:44 Xue jiufei
2013-05-31 7:42 ` Jeff Liu
0 siblings, 1 reply; 2+ messages in thread
From: Xue jiufei @ 2013-05-31 5:44 UTC (permalink / raw)
To: ocfs2-devel
Function dlm_begin_reco_handler returns without putting dlm
when dlm recovery state is DLM_RECO_STATE_FINALIZE.
Signed-off-by: joyce <xuejiufei@huawei.com>
---
fs/ocfs2/dlm/dlmrecovery.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
index eeac97b..a145cf8 100644
--- a/fs/ocfs2/dlm/dlmrecovery.c
+++ b/fs/ocfs2/dlm/dlmrecovery.c
@@ -2697,6 +2697,7 @@ int dlm_begin_reco_handler(struct o2net_msg *msg, u32 len, void *data,
dlm->name, br->node_idx, br->dead_node,
dlm->reco.dead_node, dlm->reco.new_master);
spin_unlock(&dlm->spinlock);
+ dlm_put(dlm);
return -EAGAIN;
}
spin_unlock(&dlm->spinlock);
-- 1.7.9.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2: Add missing dlm_put() in dlm_begin_reco_handler
2013-05-31 5:44 [Ocfs2-devel] [PATCH] ocfs2: Add missing dlm_put() in dlm_begin_reco_handler Xue jiufei
@ 2013-05-31 7:42 ` Jeff Liu
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Liu @ 2013-05-31 7:42 UTC (permalink / raw)
To: ocfs2-devel
Hi Jiufei,
On 05/31/2013 02:44 PM, Xue jiufei wrote:
> Function dlm_begin_reco_handler returns without putting dlm
> when dlm recovery state is DLM_RECO_STATE_FINALIZE.
>
> Signed-off-by: joyce <xuejiufei@huawei.com>
The patch looks good to me, you can consider adding:
Reviewed-by: Jie Liu <jeff.liu@oracle.com>
Thanks,
-Jeff
> ---
> fs/ocfs2/dlm/dlmrecovery.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
> index eeac97b..a145cf8 100644
> --- a/fs/ocfs2/dlm/dlmrecovery.c
> +++ b/fs/ocfs2/dlm/dlmrecovery.c
> @@ -2697,6 +2697,7 @@ int dlm_begin_reco_handler(struct o2net_msg *msg, u32 len, void *data,
> dlm->name, br->node_idx, br->dead_node,
> dlm->reco.dead_node, dlm->reco.new_master);
> spin_unlock(&dlm->spinlock);
> + dlm_put(dlm);
> return -EAGAIN;
> }
> spin_unlock(&dlm->spinlock);
> -- 1.7.9.7
>
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-31 7:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-31 5:44 [Ocfs2-devel] [PATCH] ocfs2: Add missing dlm_put() in dlm_begin_reco_handler Xue jiufei
2013-05-31 7:42 ` Jeff Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.