All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Jordan Justen <jljusten@gmail.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	Luiz Capitulino <lcapitulino@redhat.com>,
	Gleb Natapov <gleb@redhat.com>, KVM <kvm@vger.kernel.org>
Subject: [PATCH uq/master] fix double free the memslot in kvm_set_phys_mem
Date: Fri, 31 May 2013 16:52:18 +0800	[thread overview]
Message-ID: <51A864C2.8090904@linux.vnet.ibm.com> (raw)
In-Reply-To: <51A85DE8.2090600@redhat.com>

Luiz Capitulino reported that guest refused to boot and qemu
complained with:
kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument

It is caused by commit 235e8982ad that did double free for the memslot
so that the second one raises the -EINVAL error

Fix it by reset memory size only if it is needed

Reported-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
---
 kvm-all.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/kvm-all.c b/kvm-all.c
index 8e7bbf8..405480e 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -206,7 +206,8 @@ static int kvm_set_user_memory_region(KVMState *s, KVMSlot *slot)
     if (s->migration_log) {
         mem.flags |= KVM_MEM_LOG_DIRTY_PAGES;
     }
-    if (mem.flags & KVM_MEM_READONLY) {
+
+    if (slot->memory_size && mem.flags & KVM_MEM_READONLY) {
         /* Set the slot size to 0 before setting the slot to the desired
          * value. This is needed based on KVM commit 75d61fbc. */
         mem.memory_size = 0;
-- 
1.7.7.6


WARNING: multiple messages have this Message-ID (diff)
From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>, KVM <kvm@vger.kernel.org>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Luiz Capitulino <lcapitulino@redhat.com>,
	Jordan Justen <jljusten@gmail.com>
Subject: [Qemu-devel] [PATCH uq/master] fix double free the memslot in kvm_set_phys_mem
Date: Fri, 31 May 2013 16:52:18 +0800	[thread overview]
Message-ID: <51A864C2.8090904@linux.vnet.ibm.com> (raw)
In-Reply-To: <51A85DE8.2090600@redhat.com>

Luiz Capitulino reported that guest refused to boot and qemu
complained with:
kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument

It is caused by commit 235e8982ad that did double free for the memslot
so that the second one raises the -EINVAL error

Fix it by reset memory size only if it is needed

Reported-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
---
 kvm-all.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/kvm-all.c b/kvm-all.c
index 8e7bbf8..405480e 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -206,7 +206,8 @@ static int kvm_set_user_memory_region(KVMState *s, KVMSlot *slot)
     if (s->migration_log) {
         mem.flags |= KVM_MEM_LOG_DIRTY_PAGES;
     }
-    if (mem.flags & KVM_MEM_READONLY) {
+
+    if (slot->memory_size && mem.flags & KVM_MEM_READONLY) {
         /* Set the slot size to 0 before setting the slot to the desired
          * value. This is needed based on KVM commit 75d61fbc. */
         mem.memory_size = 0;
-- 
1.7.7.6

  reply	other threads:[~2013-05-31  8:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-30 15:46 [Qemu-devel] [BUG]: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument Luiz Capitulino
2013-05-30 16:03 ` Paolo Bonzini
2013-05-30 16:08   ` Luiz Capitulino
2013-05-30 16:50     ` Jordan Justen
2013-05-30 17:03       ` Luiz Capitulino
2013-05-30 17:32         ` Jordan Justen
2013-05-30 17:56           ` Luiz Capitulino
2013-05-30 18:05             ` Paolo Bonzini
2013-05-30 20:32               ` Luiz Capitulino
2013-05-30 21:23                 ` Paolo Bonzini
2013-05-30 23:43                   ` Jordan Justen
2013-05-31  6:51       ` Xiao Guangrong
2013-05-31  7:14         ` Jordan Justen
2013-05-31  8:01           ` Jordan Justen
2013-05-31  8:23         ` Paolo Bonzini
2013-05-31  8:52           ` Xiao Guangrong [this message]
2013-05-31  8:52             ` [Qemu-devel] [PATCH uq/master] fix double free the memslot in kvm_set_phys_mem Xiao Guangrong
2013-05-31 12:27             ` Paolo Bonzini
2013-05-31 12:27               ` [Qemu-devel] " Paolo Bonzini
2013-05-31 12:39             ` Luiz Capitulino
2013-05-31 12:39               ` [Qemu-devel] " Luiz Capitulino
2013-06-02 17:35             ` Richard W.M. Jones
2013-06-02 17:35               ` Richard W.M. Jones
2013-06-02 22:08             ` Jordan Justen
2013-06-02 22:08               ` [Qemu-devel] " Jordan Justen
2013-06-03  6:57             ` Gleb Natapov
2013-06-03  6:57               ` [Qemu-devel] " Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A864C2.8090904@linux.vnet.ibm.com \
    --to=xiaoguangrong@linux.vnet.ibm.com \
    --cc=gleb@redhat.com \
    --cc=jljusten@gmail.com \
    --cc=jordan.l.justen@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=lcapitulino@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.