All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
	"Keir (Xen.org)" <keir@xen.org>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: Xen 4.3 development update -- RC3 willo be an actual candidate, please test
Date: Fri, 31 May 2013 11:42:33 +0100	[thread overview]
Message-ID: <51A87E99.9040707@citrix.com> (raw)
In-Reply-To: <51A85BA702000078000D9DFA@nat28.tlf.novell.com>

On 31/05/13 07:13, Jan Beulich wrote:
>>>> On 30.05.13 at 19:33, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> FWIW,
>>
>> http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=2ae8b9173fb2388af651 
>> 4c730d620ed5f450bc34
>>
>> was also debugging and should probably come back out.  I am not certain
>> that it actually caught any issues, but we did the fixing up of legacy
>> PIC interrupts which I suspect might have been the cause of this.
> Indeed, though I would just frame the block by #ifndef NDEBUG.
> Keir - do you have any preference here?
>
> Jan
>

Having used similar debugging structures for this recent XSA-36 related
issue, the result from this change is not actually too useful.

I would certainly suggest complete removal over having in in an NDEBUG
section.

~Andrew

  reply	other threads:[~2013-05-31 10:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-30 16:16 Xen 4.3 development update -- RC3 willo be an actual candidate, please test George Dunlap
2013-05-30 16:28 ` George Dunlap
2013-05-30 16:59   ` Ian Campbell
2013-05-30 19:35   ` Alex Bligh
2013-05-30 16:30 ` George Dunlap
2013-05-30 16:31 ` George Dunlap
2013-05-30 16:39   ` Jan Beulich
2013-05-30 17:33     ` Andrew Cooper
2013-05-31  6:13       ` Jan Beulich
2013-05-31 10:42         ` Andrew Cooper [this message]
2013-05-31  6:41   ` Jan Beulich
2013-05-30 16:35 ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A87E99.9040707@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.