From: Corey Minyard <tcminyard@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] ipmi: info leak in compat_ipmi_ioctl()
Date: Fri, 31 May 2013 12:58:24 +0000 [thread overview]
Message-ID: <51A89E70.3010703@acm.org> (raw)
In-Reply-To: <20130531124658.GU23987@mwanda>
On 05/31/2013 07:46 AM, Dan Carpenter wrote:
> On x86_64 there is a 4 byte hole between ->recv_type and ->addr.
Got it, in my tree now. Thanks.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: fixed the changelog a little. Also added LKML because the
> openipmi is a moderated list (and the moderator thought my email was
> spam).
I apologize, the list gets a lot of spam, and I must have made a mistake.
-corey
>
> diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
> index 9eb360f..8e306ac 100644
> --- a/drivers/char/ipmi/ipmi_devintf.c
> +++ b/drivers/char/ipmi/ipmi_devintf.c
> @@ -810,6 +810,7 @@ static long compat_ipmi_ioctl(struct file *filep, unsigned int cmd,
> struct ipmi_recv __user *precv64;
> struct ipmi_recv recv64;
>
> + memset(&recv64, 0, sizeof(recv64));
> if (get_compat_ipmi_recv(&recv64, compat_ptr(arg)))
> return -EFAULT;
>
WARNING: multiple messages have this Message-ID (diff)
From: Corey Minyard <tcminyard@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] ipmi: info leak in compat_ipmi_ioctl()
Date: Fri, 31 May 2013 07:58:24 -0500 [thread overview]
Message-ID: <51A89E70.3010703@acm.org> (raw)
In-Reply-To: <20130531124658.GU23987@mwanda>
On 05/31/2013 07:46 AM, Dan Carpenter wrote:
> On x86_64 there is a 4 byte hole between ->recv_type and ->addr.
Got it, in my tree now. Thanks.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: fixed the changelog a little. Also added LKML because the
> openipmi is a moderated list (and the moderator thought my email was
> spam).
I apologize, the list gets a lot of spam, and I must have made a mistake.
-corey
>
> diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
> index 9eb360f..8e306ac 100644
> --- a/drivers/char/ipmi/ipmi_devintf.c
> +++ b/drivers/char/ipmi/ipmi_devintf.c
> @@ -810,6 +810,7 @@ static long compat_ipmi_ioctl(struct file *filep, unsigned int cmd,
> struct ipmi_recv __user *precv64;
> struct ipmi_recv recv64;
>
> + memset(&recv64, 0, sizeof(recv64));
> if (get_compat_ipmi_recv(&recv64, compat_ptr(arg)))
> return -EFAULT;
>
next prev parent reply other threads:[~2013-05-31 12:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 12:46 [patch v2] ipmi: info leak in compat_ipmi_ioctl() Dan Carpenter
2013-05-31 12:46 ` Dan Carpenter
2013-05-31 12:58 ` Corey Minyard [this message]
2013-05-31 12:58 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A89E70.3010703@acm.org \
--to=tcminyard@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.