From: Timur Tabi <timur@tabi.org>
To: monstr@monstr.eu
Cc: Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v3 7/8] video: xilinxfb: Fix sparse warnings
Date: Fri, 31 May 2013 13:41:48 +0000 [thread overview]
Message-ID: <51A8A89C.8030404@tabi.org> (raw)
In-Reply-To: <51A8A7B1.3040709@monstr.eu>
On 05/31/2013 08:37 AM, Michal Simek wrote:
> The same is for Microblaze. Driver shares fb_virt for IO memory
> and for allocated memory. The purpose of this driver wasn't
> to change the driver logic just resolved sparse warnings.
> The other way is also wrong.
> I have compiled this driver with ppc toolchain and it should
> remove sparse warnings for PPC.
But it's not I/O memory. It's regular memory. __iomem is for
memory-mapped I/O, which is limited to a specific range of memory locations.
If sometimes you use regular memory for the framebuffer, and other times
you use real I/O memory for the framebuffer, then you should have two
different pointers.
--
Timur Tabi
WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@tabi.org>
To: monstr@monstr.eu
Cc: Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v3 7/8] video: xilinxfb: Fix sparse warnings
Date: Fri, 31 May 2013 08:41:48 -0500 [thread overview]
Message-ID: <51A8A89C.8030404@tabi.org> (raw)
In-Reply-To: <51A8A7B1.3040709@monstr.eu>
On 05/31/2013 08:37 AM, Michal Simek wrote:
> The same is for Microblaze. Driver shares fb_virt for IO memory
> and for allocated memory. The purpose of this driver wasn't
> to change the driver logic just resolved sparse warnings.
> The other way is also wrong.
> I have compiled this driver with ppc toolchain and it should
> remove sparse warnings for PPC.
But it's not I/O memory. It's regular memory. __iomem is for
memory-mapped I/O, which is limited to a specific range of memory locations.
If sometimes you use regular memory for the framebuffer, and other times
you use real I/O memory for the framebuffer, then you should have two
different pointers.
--
Timur Tabi
next prev parent reply other threads:[~2013-05-31 13:41 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 12:55 [PATCH v3 0/8] xilinxfb changes Michal Simek
2013-05-31 12:55 ` Michal Simek
2013-05-31 12:55 ` Michal Simek
[not found] ` <cover.1370004925.git.michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2013-05-31 12:55 ` [PATCH v3 1/8] video: xilinxfb: Fix OF probing on little-endian systems Michal Simek
2013-05-31 12:55 ` Michal Simek
2013-05-31 12:55 ` Michal Simek
2013-05-31 13:05 ` Timur Tabi
2013-05-31 13:05 ` Timur Tabi
2013-05-31 13:09 ` Michal Simek
2013-05-31 13:09 ` Michal Simek
2013-05-31 12:55 ` [PATCH v3 2/8] video: xilinxfb: Do not name out_be32 in function name Michal Simek
2013-05-31 12:55 ` Michal Simek
2013-05-31 12:55 ` [PATCH v3 3/8] video: xilinxfb: Rename PLB_ACCESS_FLAG to BUS_ACCESS_FLAG Michal Simek
2013-05-31 12:55 ` Michal Simek
2013-05-31 12:55 ` [PATCH v3 4/8] video: xilinxfb: Use drvdata->regs_phys instead of physaddr Michal Simek
2013-05-31 12:55 ` Michal Simek
2013-05-31 12:55 ` [PATCH v3 5/8] video: xilinxfb: Group bus initialization Michal Simek
2013-05-31 12:55 ` Michal Simek
2013-05-31 12:55 ` [PATCH v3 6/8] video: xilinxfb: Add support for little endian accesses Michal Simek
2013-05-31 12:55 ` Michal Simek
2013-05-31 13:38 ` Arnd Bergmann
2013-05-31 13:38 ` Arnd Bergmann
2013-05-31 12:55 ` [PATCH v3 7/8] video: xilinxfb: Fix sparse warnings Michal Simek
2013-05-31 12:55 ` Michal Simek
2013-05-31 13:26 ` Timur Tabi
2013-05-31 13:26 ` Timur Tabi
2013-05-31 13:37 ` Michal Simek
2013-05-31 13:37 ` Michal Simek
2013-05-31 13:41 ` Timur Tabi [this message]
2013-05-31 13:41 ` Timur Tabi
2013-05-31 14:22 ` Michal Simek
2013-05-31 14:22 ` Michal Simek
2013-05-31 14:56 ` Arnd Bergmann
2013-05-31 14:56 ` Arnd Bergmann
2013-05-31 15:06 ` Timur Tabi
2013-05-31 15:06 ` Timur Tabi
2013-05-31 15:29 ` Arnd Bergmann
2013-05-31 15:29 ` Arnd Bergmann
2013-05-31 16:33 ` Michal Simek
2013-05-31 16:33 ` Michal Simek
2013-05-31 15:28 ` Arnd Bergmann
2013-05-31 15:28 ` Arnd Bergmann
2013-05-31 12:55 ` [PATCH v3 8/8] video: xilinxfb: Use driver for Xilinx ARM Zynq Michal Simek
2013-05-31 12:55 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A8A89C.8030404@tabi.org \
--to=timur@tabi.org \
--cc=arnd@arndb.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.