From: Dan Murphy <dmurphy@ti.com>
To: Benoit Cousson <b-cousson@ti.com>
Cc: linux@arm.linux.org.uk, tony@atomide.com,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7] ARM: dts: omap4-panda: Update the LED support for the panda DTS
Date: Fri, 31 May 2013 09:29:42 -0500 [thread overview]
Message-ID: <51A8B3D6.1020608@ti.com> (raw)
In-Reply-To: <51A8AE72.5010601@ti.com>
Hi
On 05/31/2013 09:06 AM, Benoit Cousson wrote:
> Hi Dan,
>
> On 05/29/2013 01:20 PM, Dan Murphy wrote:
>> The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es
>> are different.
>>
>> A1-A3 = gpio_wk7clean
>> ES = gpio_110
>>
>> There is no change to LED D2
>>
>> Abstract away the pinmux and the LED definitions for the two boards into
>> the respective DTS files.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> That patch was good... until Florian introduces some new constant to
> improve the readability of the DTS [1].
>
> Could you rebase on the lastest for_3.11/dts and use the macros for the
> GPIO and pinctrl nodes?
N/P working on it now
Thanks
> Thanks,
> Benoit
>
> [1] http://www.mail-archive.com/linux-omap@vger.kernel.org/msg89684.html
>
--
------------------
Dan Murphy
WARNING: multiple messages have this Message-ID (diff)
From: dmurphy@ti.com (Dan Murphy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7] ARM: dts: omap4-panda: Update the LED support for the panda DTS
Date: Fri, 31 May 2013 09:29:42 -0500 [thread overview]
Message-ID: <51A8B3D6.1020608@ti.com> (raw)
In-Reply-To: <51A8AE72.5010601@ti.com>
Hi
On 05/31/2013 09:06 AM, Benoit Cousson wrote:
> Hi Dan,
>
> On 05/29/2013 01:20 PM, Dan Murphy wrote:
>> The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es
>> are different.
>>
>> A1-A3 = gpio_wk7clean
>> ES = gpio_110
>>
>> There is no change to LED D2
>>
>> Abstract away the pinmux and the LED definitions for the two boards into
>> the respective DTS files.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> That patch was good... until Florian introduces some new constant to
> improve the readability of the DTS [1].
>
> Could you rebase on the lastest for_3.11/dts and use the macros for the
> GPIO and pinctrl nodes?
N/P working on it now
Thanks
> Thanks,
> Benoit
>
> [1] http://www.mail-archive.com/linux-omap at vger.kernel.org/msg89684.html
>
--
------------------
Dan Murphy
WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com>
To: Benoit Cousson <b-cousson@ti.com>
Cc: <tony@atomide.com>, <linux@arm.linux.org.uk>,
<linux-omap@vger.kernel.org>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7] ARM: dts: omap4-panda: Update the LED support for the panda DTS
Date: Fri, 31 May 2013 09:29:42 -0500 [thread overview]
Message-ID: <51A8B3D6.1020608@ti.com> (raw)
In-Reply-To: <51A8AE72.5010601@ti.com>
Hi
On 05/31/2013 09:06 AM, Benoit Cousson wrote:
> Hi Dan,
>
> On 05/29/2013 01:20 PM, Dan Murphy wrote:
>> The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es
>> are different.
>>
>> A1-A3 = gpio_wk7clean
>> ES = gpio_110
>>
>> There is no change to LED D2
>>
>> Abstract away the pinmux and the LED definitions for the two boards into
>> the respective DTS files.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> That patch was good... until Florian introduces some new constant to
> improve the readability of the DTS [1].
>
> Could you rebase on the lastest for_3.11/dts and use the macros for the
> GPIO and pinctrl nodes?
N/P working on it now
Thanks
> Thanks,
> Benoit
>
> [1] http://www.mail-archive.com/linux-omap@vger.kernel.org/msg89684.html
>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2013-05-31 14:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 11:20 [PATCH v7] ARM: dts: omap4-panda: Update the LED support for the panda DTS Dan Murphy
2013-05-29 11:20 ` Dan Murphy
2013-05-29 11:20 ` Dan Murphy
2013-05-31 14:06 ` Benoit Cousson
2013-05-31 14:06 ` Benoit Cousson
2013-05-31 14:06 ` Benoit Cousson
2013-05-31 14:29 ` Dan Murphy [this message]
2013-05-31 14:29 ` Dan Murphy
2013-05-31 14:29 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A8B3D6.1020608@ti.com \
--to=dmurphy@ti.com \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.