From: Stephen Warren <swarren@wwwdotorg.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: David Gibson <david@gibson.dropbear.id.au>,
jdl@jdl.com, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
mmarek@suse.cz, rob.herring@calxeda.com,
grant.likely@secretlab.ca, linux-kbuild@vger.kernel.org,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH] dtc: Ensure #line directives don't consume data from the next line
Date: Fri, 31 May 2013 11:42:06 -0600 [thread overview]
Message-ID: <51A8E0EE.1040305@wwwdotorg.org> (raw)
In-Reply-To: <87sj13dp72.fsf@hase.home>
On 05/31/2013 11:38 AM, Andreas Schwab wrote:
> Stephen Warren <swarren@wwwdotorg.org> writes:
>
>> Fix this by replacing {WS} with [ \t] so that it can't match line-breaks.
>
> I think the other uses of {WS} shouldn't span lines either.
That is true, but only the optional occurrence /should/ matter. Any
changes to the other occurrences would only affect malformed #line
directives, whereas changing this one occurrence would also affect
well-formed #line directives, due to the optional nature of the trailing
flags field.
Still, it may be reasonable just to change all the occurrences anyway.
Does anyone have a strong opinion either way?
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: mmarek@suse.cz, jdl@jdl.com, Stephen Warren <swarren@nvidia.com>,
linux-kbuild@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
linuxppc-dev@lists.ozlabs.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] dtc: Ensure #line directives don't consume data from the next line
Date: Fri, 31 May 2013 11:42:06 -0600 [thread overview]
Message-ID: <51A8E0EE.1040305@wwwdotorg.org> (raw)
In-Reply-To: <87sj13dp72.fsf@hase.home>
On 05/31/2013 11:38 AM, Andreas Schwab wrote:
> Stephen Warren <swarren@wwwdotorg.org> writes:
>
>> Fix this by replacing {WS} with [ \t] so that it can't match line-breaks.
>
> I think the other uses of {WS} shouldn't span lines either.
That is true, but only the optional occurrence /should/ matter. Any
changes to the other occurrences would only affect malformed #line
directives, whereas changing this one occurrence would also affect
well-formed #line directives, due to the optional nature of the trailing
flags field.
Still, it may be reasonable just to change all the occurrences anyway.
Does anyone have a strong opinion either way?
next prev parent reply other threads:[~2013-05-31 17:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 17:14 [PATCH] dtc: Ensure #line directives don't consume data from the next line Stephen Warren
2013-05-31 17:14 ` Stephen Warren
2013-05-31 17:38 ` Andreas Schwab
2013-05-31 17:38 ` Andreas Schwab
2013-05-31 17:42 ` Stephen Warren [this message]
2013-05-31 17:42 ` Stephen Warren
-- strict thread matches above, loose matches on Subject: below --
2013-06-03 15:36 [PATCH] dtc: ensure " Stephen Warren
2013-06-03 15:36 ` Stephen Warren
2013-06-03 16:02 ` Ian Campbell
2013-06-03 16:02 ` Ian Campbell
2013-06-03 16:02 ` Ian Campbell
2013-06-05 16:50 ` Stephen Warren
2013-06-05 16:50 ` Stephen Warren
2013-06-05 16:50 ` Stephen Warren
2013-06-14 22:01 ` Grant Likely
2013-06-14 22:01 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A8E0EE.1040305@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jdl@jdl.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mmarek@suse.cz \
--cc=rob.herring@calxeda.com \
--cc=schwab@linux-m68k.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.