All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: usb-audio: fix Roland/Cakewalk UM-3G support
@ 2013-06-02 17:49 Clemens Ladisch
  2013-06-03  7:42 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Clemens Ladisch @ 2013-06-02 17:49 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: alsa-devel

Commit 927c9423dd5f2d1c0b93d5e694ab84b4a5559713 (ALSA: usb-audio: add
Edirol UM-3G support) used a wrong quirk type, which would make the
driver refuse to attach with the error message "MIDIStreaming interface
descriptor not found".

Cc: <stable@vger.kernel.org> # 3.3 and later
Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
---
 sound/usb/quirks-table.h |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

--- a/sound/usb/quirks-table.h
+++ b/sound/usb/quirks-table.h
@@ -1792,7 +1792,11 @@
 	USB_DEVICE_VENDOR_SPEC(0x0582, 0x0108),
 	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
 		.ifnum = 0,
-		.type = QUIRK_MIDI_STANDARD_INTERFACE
+		.type = QUIRK_MIDI_FIXED_ENDPOINT,
+		.data = & (const struct snd_usb_midi_endpoint_info) {
+			.out_cables = 0x0007,
+			.in_cables  = 0x0007
+		}
 	}
 },
 {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: usb-audio: fix Roland/Cakewalk UM-3G support
  2013-06-02 17:49 [PATCH] ALSA: usb-audio: fix Roland/Cakewalk UM-3G support Clemens Ladisch
@ 2013-06-03  7:42 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2013-06-03  7:42 UTC (permalink / raw)
  To: Clemens Ladisch; +Cc: alsa-devel

At Sun, 02 Jun 2013 19:49:07 +0200,
Clemens Ladisch wrote:
> 
> Commit 927c9423dd5f2d1c0b93d5e694ab84b4a5559713 (ALSA: usb-audio: add
> Edirol UM-3G support) used a wrong quirk type, which would make the
> driver refuse to attach with the error message "MIDIStreaming interface
> descriptor not found".
> 
> Cc: <stable@vger.kernel.org> # 3.3 and later
> Signed-off-by: Clemens Ladisch <clemens@ladisch.de>

Thanks, applied.


Takashi

> ---
>  sound/usb/quirks-table.h |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> --- a/sound/usb/quirks-table.h
> +++ b/sound/usb/quirks-table.h
> @@ -1792,7 +1792,11 @@
>  	USB_DEVICE_VENDOR_SPEC(0x0582, 0x0108),
>  	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
>  		.ifnum = 0,
> -		.type = QUIRK_MIDI_STANDARD_INTERFACE
> +		.type = QUIRK_MIDI_FIXED_ENDPOINT,
> +		.data = & (const struct snd_usb_midi_endpoint_info) {
> +			.out_cables = 0x0007,
> +			.in_cables  = 0x0007
> +		}
>  	}
>  },
>  {
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-06-03  7:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-02 17:49 [PATCH] ALSA: usb-audio: fix Roland/Cakewalk UM-3G support Clemens Ladisch
2013-06-03  7:42 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.