From: elen.song@atmel.com (elen.song)
To: linux-arm-kernel@lists.infradead.org
Subject: warning introduced in "DMA: AT91: Get residual bytes in dma buffer"
Date: Mon, 3 Jun 2013 11:10:06 +0800 [thread overview]
Message-ID: <51AC090E.9090908@atmel.com> (raw)
In-Reply-To: <5527092.NRqFJAfgoB@wuerfel>
Hi Arnd:
On 5/31/2013 11:54 PM, Arnd Bergmann wrote:
> Patch 7c407d3e "DMA: AT91: Get residual bytes in dma buffer"
> causes a build warning
>
> /git/arm-soc/drivers/dma/at_hdmac.c:424:13: warning: 'atc_cleanup_descriptors' defined but not used [-Wunused-function]
> static void atc_cleanup_descriptors(struct at_dma_chan *atchan)
> ^
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>
> This may not be the right solution, but it should get fixed
> in linux-next in some way.
>
> Elen, please address this appropriately.
OK.
>
> Arnd
>
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index 6db5228..09929c8 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -421,7 +421,7 @@ static void atc_complete_all(struct at_dma_chan *atchan)
> *
> * Called with atchan->lock held and bh disabled
> */
> -static void atc_cleanup_descriptors(struct at_dma_chan *atchan)
> +static void __maybe_unused atc_cleanup_descriptors(struct at_dma_chan *atchan)
> {
> struct at_desc *desc, *_desc;
> struct at_desc *child;
>
Hi Nicolas and Ludovic:
I think atc_cleanup_descriptors could be removed, because ATC_DONE will
no longer support, what you think?
Best Regards
Elen song
prev parent reply other threads:[~2013-06-03 3:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 15:54 warning introduced in "DMA: AT91: Get residual bytes in dma buffer" Arnd Bergmann
2013-06-03 3:10 ` elen.song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AC090E.9090908@atmel.com \
--to=elen.song@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.