* warning introduced in "DMA: AT91: Get residual bytes in dma buffer"
@ 2013-05-31 15:54 Arnd Bergmann
2013-06-03 3:10 ` elen.song
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2013-05-31 15:54 UTC (permalink / raw)
To: linux-arm-kernel
Patch 7c407d3e "DMA: AT91: Get residual bytes in dma buffer"
causes a build warning
/git/arm-soc/drivers/dma/at_hdmac.c:424:13: warning: 'atc_cleanup_descriptors' defined but not used [-Wunused-function]
static void atc_cleanup_descriptors(struct at_dma_chan *atchan)
^
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
This may not be the right solution, but it should get fixed
in linux-next in some way.
Elen, please address this appropriately.
Arnd
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index 6db5228..09929c8 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -421,7 +421,7 @@ static void atc_complete_all(struct at_dma_chan *atchan)
*
* Called with atchan->lock held and bh disabled
*/
-static void atc_cleanup_descriptors(struct at_dma_chan *atchan)
+static void __maybe_unused atc_cleanup_descriptors(struct at_dma_chan *atchan)
{
struct at_desc *desc, *_desc;
struct at_desc *child;
^ permalink raw reply related [flat|nested] 2+ messages in thread* warning introduced in "DMA: AT91: Get residual bytes in dma buffer"
2013-05-31 15:54 warning introduced in "DMA: AT91: Get residual bytes in dma buffer" Arnd Bergmann
@ 2013-06-03 3:10 ` elen.song
0 siblings, 0 replies; 2+ messages in thread
From: elen.song @ 2013-06-03 3:10 UTC (permalink / raw)
To: linux-arm-kernel
Hi Arnd:
On 5/31/2013 11:54 PM, Arnd Bergmann wrote:
> Patch 7c407d3e "DMA: AT91: Get residual bytes in dma buffer"
> causes a build warning
>
> /git/arm-soc/drivers/dma/at_hdmac.c:424:13: warning: 'atc_cleanup_descriptors' defined but not used [-Wunused-function]
> static void atc_cleanup_descriptors(struct at_dma_chan *atchan)
> ^
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>
> This may not be the right solution, but it should get fixed
> in linux-next in some way.
>
> Elen, please address this appropriately.
OK.
>
> Arnd
>
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index 6db5228..09929c8 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -421,7 +421,7 @@ static void atc_complete_all(struct at_dma_chan *atchan)
> *
> * Called with atchan->lock held and bh disabled
> */
> -static void atc_cleanup_descriptors(struct at_dma_chan *atchan)
> +static void __maybe_unused atc_cleanup_descriptors(struct at_dma_chan *atchan)
> {
> struct at_desc *desc, *_desc;
> struct at_desc *child;
>
Hi Nicolas and Ludovic:
I think atc_cleanup_descriptors could be removed, because ATC_DONE will
no longer support, what you think?
Best Regards
Elen song
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-03 3:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-31 15:54 warning introduced in "DMA: AT91: Get residual bytes in dma buffer" Arnd Bergmann
2013-06-03 3:10 ` elen.song
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.