From: Josh Wu <josh.wu@atmel.com>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MTD: atmel_nand: using a stronger ECC is not dangerous
Date: Mon, 3 Jun 2013 13:44:00 +0800 [thread overview]
Message-ID: <51AC2D20.3040703@atmel.com> (raw)
In-Reply-To: <1370010850-20860-1-git-send-email-richard.genoud@gmail.com>
On 5/31/2013 10:34 PM, Richard Genoud wrote:
> We don't have to issue a warning when a stronger error correting
> capability is chosen.
>
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Acked-by: Josh Wu <josh.wu@atmel.com>
Best Regards,
Josh Wu
> ---
> drivers/mtd/nand/atmel_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index 2d23d29..2415cdc 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -1002,7 +1002,7 @@ static int __init atmel_pmecc_nand_init_params(struct platform_device *pdev,
> return err_no;
> }
>
> - if (cap != host->pmecc_corr_cap ||
> + if (cap > host->pmecc_corr_cap ||
> sector_size != host->pmecc_sector_size)
> dev_info(host->dev, "WARNING: Be Caution! Using different PMECC parameters from Nand ONFI ECC reqirement.\n");
>
WARNING: multiple messages have this Message-ID (diff)
From: Josh Wu <josh.wu@atmel.com>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] MTD: atmel_nand: using a stronger ECC is not dangerous
Date: Mon, 3 Jun 2013 13:44:00 +0800 [thread overview]
Message-ID: <51AC2D20.3040703@atmel.com> (raw)
In-Reply-To: <1370010850-20860-1-git-send-email-richard.genoud@gmail.com>
On 5/31/2013 10:34 PM, Richard Genoud wrote:
> We don't have to issue a warning when a stronger error correting
> capability is chosen.
>
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Acked-by: Josh Wu <josh.wu@atmel.com>
Best Regards,
Josh Wu
> ---
> drivers/mtd/nand/atmel_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index 2d23d29..2415cdc 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -1002,7 +1002,7 @@ static int __init atmel_pmecc_nand_init_params(struct platform_device *pdev,
> return err_no;
> }
>
> - if (cap != host->pmecc_corr_cap ||
> + if (cap > host->pmecc_corr_cap ||
> sector_size != host->pmecc_sector_size)
> dev_info(host->dev, "WARNING: Be Caution! Using different PMECC parameters from Nand ONFI ECC reqirement.\n");
>
next prev parent reply other threads:[~2013-06-03 5:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 14:34 [PATCH] MTD: atmel_nand: using a stronger ECC is not dangerous Richard Genoud
2013-05-31 14:34 ` Richard Genoud
2013-06-03 5:44 ` Josh Wu [this message]
2013-06-03 5:44 ` Josh Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AC2D20.3040703@atmel.com \
--to=josh.wu@atmel.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard.genoud@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.