All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
	Marcelo Tossati <mtosatti@redhat.com>,
	Gleb Natapov <gleb@redhat.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	KVM <kvm@vger.kernel.org>,
	linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [PATCH] KVM: s390: Add "devname:kvm" alias.
Date: Mon, 03 Jun 2013 09:50:24 +0200	[thread overview]
Message-ID: <51AC4AC0.9090607@redhat.com> (raw)
In-Reply-To: <51A48A71.3010705@redhat.com>

Il 28/05/2013 12:44, Paolo Bonzini ha scritto:
> Il 27/05/2013 18:42, Cornelia Huck ha scritto:
>> Providing a "devname:kvm" module alias enables automatic loading of
>> the kvm module when /dev/kvm is opened.
>>
>> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>> ---
>>  arch/s390/kvm/kvm-s390.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>> index 93444c4..3b597e5 100644
>> --- a/arch/s390/kvm/kvm-s390.c
>> +++ b/arch/s390/kvm/kvm-s390.c
>> @@ -1138,3 +1138,12 @@ static void __exit kvm_s390_exit(void)
>>  
>>  module_init(kvm_s390_init);
>>  module_exit(kvm_s390_exit);
>> +
>> +/*
>> + * Enable autoloading of the kvm module.
>> + * Note that we add the module alias here instead of virt/kvm/kvm_main.c
>> + * since x86 takes a different approach.
>> + */
>> +#include <linux/miscdevice.h>
>> +MODULE_ALIAS_MISCDEV(KVM_MINOR);
>> +MODULE_ALIAS("devname:kvm");
>>
> 
> Applied, thanks.

After discussion with Gleb, we have decided to postpone this patch to
3.11.  Thanks for your understanding. :)

I'll push pending patches to master and queue soon.

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
	Marcelo Tossati <mtosatti@redhat.com>,
	Gleb Natapov <gleb@redhat.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	KVM <kvm@vger.kernel.org>,
	linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [PATCH] KVM: s390: Add "devname:kvm" alias.
Date: Mon, 03 Jun 2013 09:50:24 +0200	[thread overview]
Message-ID: <51AC4AC0.9090607@redhat.com> (raw)
In-Reply-To: <51A48A71.3010705@redhat.com>

Il 28/05/2013 12:44, Paolo Bonzini ha scritto:
> Il 27/05/2013 18:42, Cornelia Huck ha scritto:
>> Providing a "devname:kvm" module alias enables automatic loading of
>> the kvm module when /dev/kvm is opened.
>>
>> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>> ---
>>  arch/s390/kvm/kvm-s390.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>> index 93444c4..3b597e5 100644
>> --- a/arch/s390/kvm/kvm-s390.c
>> +++ b/arch/s390/kvm/kvm-s390.c
>> @@ -1138,3 +1138,12 @@ static void __exit kvm_s390_exit(void)
>>  
>>  module_init(kvm_s390_init);
>>  module_exit(kvm_s390_exit);
>> +
>> +/*
>> + * Enable autoloading of the kvm module.
>> + * Note that we add the module alias here instead of virt/kvm/kvm_main.c
>> + * since x86 takes a different approach.
>> + */
>> +#include <linux/miscdevice.h>
>> +MODULE_ALIAS_MISCDEV(KVM_MINOR);
>> +MODULE_ALIAS("devname:kvm");
>>
> 
> Applied, thanks.

After discussion with Gleb, we have decided to postpone this patch to
3.11.  Thanks for your understanding. :)

I'll push pending patches to master and queue soon.

Paolo


  reply	other threads:[~2013-06-03  7:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-27 16:42 [PATCH] KVM: s390: Module autoloading Cornelia Huck
2013-05-27 16:42 ` [PATCH] KVM: s390: Add "devname:kvm" alias Cornelia Huck
2013-05-28  9:00   ` Paolo Bonzini
2013-05-28  9:07     ` Christian Borntraeger
2013-05-28 10:44   ` Paolo Bonzini
2013-06-03  7:50     ` Paolo Bonzini [this message]
2013-06-03  7:50       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51AC4AC0.9090607@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=gleb@redhat.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.