From: Amir Vadai <amirv@mellanox.com>
To: Eliezer Tamir <eliezer.tamir@linux.intel.com>
Cc: David Miller <davem@davemloft.net>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Don Skidmore <donald.c.skidmore@intel.com>,
<e1000-devel@lists.sourceforge.net>,
Willem de Bruijn <willemb@google.com>,
Eric Dumazet <erdnetdev@gmail.com>,
Ben Hutchings <bhutchings@solarflare.com>,
Andi Kleen <andi@firstfloor.org>, HPA <hpa@zytor.com>,
Eilon Greenstien <eilong@broadcom.com>,
Or Gerlitz <or.gerlitz@gmail.com>,
Alex Rosenbaum <alexr@mellanox.com>,
Eliezer Tamir <eliezer@tamir.org.il>
Subject: Re: [PATCH v8 net-next 2/7] net: add low latency socket poll
Date: Mon, 3 Jun 2013 15:22:29 +0300 [thread overview]
Message-ID: <51AC8A85.5020605@mellanox.com> (raw)
In-Reply-To: <20130603080128.18273.2408.stgit@ladj378.jer.intel.com>
On 03/06/2013 11:01, Eliezer Tamir wrote:
> diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c
> index 741db5fc..ae98c95 100644
> --- a/net/core/sysctl_net_core.c
> +++ b/net/core/sysctl_net_core.c
> @@ -19,6 +19,7 @@
> #include <net/ip.h>
> #include <net/sock.h>
> #include <net/net_ratelimit.h>
> +#include <net/ll_poll.h>
>
> static int one = 1;
>
> @@ -284,6 +285,15 @@ static struct ctl_table net_core_table[] = {
> .proc_handler = flow_limit_table_len_sysctl
> },
> #endif /* CONFIG_NET_FLOW_LIMIT */
> +#ifdef CONFIG_NET_LL_RX_POLL
> + {
> + .procname = "low_latency_poll",
> + .data = &sysctl_net_ll_poll,
> + .maxlen = sizeof(unsigned long),
One more thing I just noticed: should be 'sizeof(int)'.
Because proc_dointvec is expecting an int, sizeof(unsigned long) will
produce an array of two ints.
> + .mode = 0644,
> + .proc_handler = proc_dointvec
> + },
> +#endif
> #endif /* CONFIG_NET */
> {
> .procname = "netdev_budget",
WARNING: multiple messages have this Message-ID (diff)
From: Amir Vadai <amirv@mellanox.com>
To: Eliezer Tamir <eliezer.tamir@linux.intel.com>
Cc: Willem de Bruijn <willemb@google.com>,
Don, Or Gerlitz <or.gerlitz@gmail.com>,
e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
HPA <hpa@zytor.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Alex Rosenbaum <alexr@mellanox.com>,
linux-kernel@vger.kernel.org,
Eliezer Tamir <eliezer@tamir.org.il>,
Andi Kleen <andi@firstfloor.org>,
Ben Hutchings <bhutchings@solarflare.com>,
Eric Dumazet <erdnetdev@gmail.com>,
Eilon Greenstien <eilong@broadcom.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH v8 net-next 2/7] net: add low latency socket poll
Date: Mon, 3 Jun 2013 15:22:29 +0300 [thread overview]
Message-ID: <51AC8A85.5020605@mellanox.com> (raw)
In-Reply-To: <20130603080128.18273.2408.stgit@ladj378.jer.intel.com>
On 03/06/2013 11:01, Eliezer Tamir wrote:
> diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c
> index 741db5fc..ae98c95 100644
> --- a/net/core/sysctl_net_core.c
> +++ b/net/core/sysctl_net_core.c
> @@ -19,6 +19,7 @@
> #include <net/ip.h>
> #include <net/sock.h>
> #include <net/net_ratelimit.h>
> +#include <net/ll_poll.h>
>
> static int one = 1;
>
> @@ -284,6 +285,15 @@ static struct ctl_table net_core_table[] = {
> .proc_handler = flow_limit_table_len_sysctl
> },
> #endif /* CONFIG_NET_FLOW_LIMIT */
> +#ifdef CONFIG_NET_LL_RX_POLL
> + {
> + .procname = "low_latency_poll",
> + .data = &sysctl_net_ll_poll,
> + .maxlen = sizeof(unsigned long),
One more thing I just noticed: should be 'sizeof(int)'.
Because proc_dointvec is expecting an int, sizeof(unsigned long) will
produce an array of two ints.
> + .mode = 0644,
> + .proc_handler = proc_dointvec
> + },
> +#endif
> #endif /* CONFIG_NET */
> {
> .procname = "netdev_budget",
------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite
It's a free troubleshooting tool designed for production
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap2
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next prev parent reply other threads:[~2013-06-03 12:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 8:01 [PATCH v8 net-next 0/7] net: low latency Ethernet device polling Eliezer Tamir
2013-06-03 8:01 ` [PATCH v8 net-next 1/7] net: add napi_id and hash Eliezer Tamir
2013-06-03 12:58 ` Eric Dumazet
2013-06-03 8:01 ` [PATCH v8 net-next 2/7] net: add low latency socket poll Eliezer Tamir
2013-06-03 8:01 ` Eliezer Tamir
2013-06-03 12:22 ` Amir Vadai [this message]
2013-06-03 12:22 ` Amir Vadai
2013-06-03 13:05 ` Eric Dumazet
2013-06-03 13:05 ` Eric Dumazet
2013-06-03 13:53 ` Eliezer Tamir
2013-06-03 8:01 ` [PATCH v8 net-next 3/7] udp: add low latency socket poll support Eliezer Tamir
2013-06-03 8:01 ` Eliezer Tamir
2013-06-03 13:08 ` Eric Dumazet
2013-06-03 8:01 ` [PATCH v8 net-next 4/7] tcp: " Eliezer Tamir
2013-06-03 8:01 ` Eliezer Tamir
2013-06-03 13:09 ` Eric Dumazet
2013-06-03 13:09 ` Eric Dumazet
2013-06-03 8:02 ` [PATCH v8 net-next 5/7] net: simple poll/select low latency socket poll Eliezer Tamir
2013-06-03 8:02 ` Eliezer Tamir
2013-06-03 13:15 ` Eric Dumazet
2013-06-03 13:15 ` Eric Dumazet
2013-06-03 13:59 ` Eliezer Tamir
2013-06-03 13:59 ` Eliezer Tamir
2013-06-04 8:52 ` Eliezer Tamir
2013-06-04 8:52 ` Eliezer Tamir
2013-06-03 8:02 ` [PATCH v8 net-next 6/7] ixgbe: add support for ndo_ll_poll Eliezer Tamir
2013-06-03 8:02 ` Eliezer Tamir
2013-06-05 8:50 ` Cong Wang
2013-06-03 8:02 ` [PATCH v8 net-next 7/7] ixgbe: add extra stats " Eliezer Tamir
2013-06-03 8:02 ` Eliezer Tamir
2013-06-03 11:23 ` [PATCH v8 net-next 0/7] net: low latency Ethernet device polling Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AC8A85.5020605@mellanox.com \
--to=amirv@mellanox.com \
--cc=alexr@mellanox.com \
--cc=andi@firstfloor.org \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eilong@broadcom.com \
--cc=eliezer.tamir@linux.intel.com \
--cc=eliezer@tamir.org.il \
--cc=erdnetdev@gmail.com \
--cc=hpa@zytor.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.