* [Qemu-devel] [PATCH scsi-next] vhost-scsi: fix cut-and-paste typo @ 2013-05-31 11:15 Paolo Bonzini 2013-06-03 12:27 ` Markus Armbruster 0 siblings, 1 reply; 3+ messages in thread From: Paolo Bonzini @ 2013-05-31 11:15 UTC (permalink / raw) To: qemu-devel; +Cc: qemu-stable The copied code comes from vhost_scsi_start. Spotted by Coverity. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- hw/scsi/vhost-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c index d7a1c33..785e93f 100644 --- a/hw/scsi/vhost-scsi.c +++ b/hw/scsi/vhost-scsi.c @@ -123,7 +123,7 @@ static void vhost_scsi_stop(VHostSCSI *s) VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus); int ret = 0; - if (!k->set_guest_notifiers) { + if (k->set_guest_notifiers) { ret = k->set_guest_notifiers(qbus->parent, s->dev.nvqs, false); if (ret < 0) { error_report("vhost guest notifier cleanup failed: %d\n", ret); -- 1.8.1.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH scsi-next] vhost-scsi: fix cut-and-paste typo 2013-05-31 11:15 [Qemu-devel] [PATCH scsi-next] vhost-scsi: fix cut-and-paste typo Paolo Bonzini @ 2013-06-03 12:27 ` Markus Armbruster 2013-06-03 12:56 ` Paolo Bonzini 0 siblings, 1 reply; 3+ messages in thread From: Markus Armbruster @ 2013-06-03 12:27 UTC (permalink / raw) To: Paolo Bonzini; +Cc: qemu-devel, Stefan Hajnoczi, qemu-stable Paolo Bonzini <pbonzini@redhat.com> writes: > The copied code comes from vhost_scsi_start. Spotted by Coverity. > > Cc: qemu-stable@nongnu.org > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Same as Stefan's [PATCH 1/3] vhost-scsi: fix k->set_guest_notifiers() NULL dereference ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH scsi-next] vhost-scsi: fix cut-and-paste typo 2013-06-03 12:27 ` Markus Armbruster @ 2013-06-03 12:56 ` Paolo Bonzini 0 siblings, 0 replies; 3+ messages in thread From: Paolo Bonzini @ 2013-06-03 12:56 UTC (permalink / raw) To: Markus Armbruster; +Cc: qemu-devel, Stefan Hajnoczi, qemu-stable Il 03/06/2013 14:27, Markus Armbruster ha scritto: > Paolo Bonzini <pbonzini@redhat.com> writes: > >> The copied code comes from vhost_scsi_start. Spotted by Coverity. >> >> Cc: qemu-stable@nongnu.org >> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > > Same as Stefan's [PATCH 1/3] vhost-scsi: fix k->set_guest_notifiers() > NULL dereference Yes, but his commit message makes more fun of the guy who wrote the code. Since I deserve it, I'm applying his version. Paolo ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-03 13:40 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-05-31 11:15 [Qemu-devel] [PATCH scsi-next] vhost-scsi: fix cut-and-paste typo Paolo Bonzini 2013-06-03 12:27 ` Markus Armbruster 2013-06-03 12:56 ` Paolo Bonzini
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.