All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mmc: Update "mmc->part_num" when performing a partition switch
Date: Tue, 04 Jun 2013 13:36:31 -0600	[thread overview]
Message-ID: <51AE41BF.8060206@wwwdotorg.org> (raw)
In-Reply-To: <CAOMZO5BQm3OPmG96YC_sQLEo0RwJORe+nYN_p2nMF=ctZCye3Q@mail.gmail.com>

On 06/04/2013 01:30 PM, Fabio Estevam wrote:
> On Tue, Jun 4, 2013 at 4:21 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> 
>> This surely has exactly the same issue as the previous version, where
>> the update of part_num was done inside common/env_mmc.c?
> 
> My understading is that the mmc core should update mmc->part_num and I
> don't see such update, or am I missing something?

That seems like a reasonable way for the code to work. However, you'd
need to modify common/env_mmc.c:init_mmc_for_env() so that it saves off
mmc->part_num before switching MMC partitions, so that
fini_mmc_for_env() knows which partition to switch back to. Right now,
it relies on the fact that mmc_switch_part() does not update
mmc->part_num, and hence uses that value to save the previously selected
partition ID.

Also, if you make this change, I think you can update
common/cmd_mmc.c:do_mmcops(), since it will no longer need to update
mmc->part_num after a successful switch.

  reply	other threads:[~2013-06-04 19:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-04 19:17 [U-Boot] [PATCH v2] mmc: Update "mmc->part_num" when performing a partition switch Fabio Estevam
2013-06-04 19:21 ` Stephen Warren
2013-06-04 19:30   ` Fabio Estevam
2013-06-04 19:36     ` Stephen Warren [this message]
2013-06-04 20:45       ` Fabio Estevam
2013-06-04 22:12         ` Stephen Warren
2013-06-04 23:09           ` Fabio Estevam
2013-06-04 23:30             ` Stephen Warren
2013-06-04 23:48               ` Fabio Estevam
2013-06-04 23:16           ` Fabio Estevam
2013-06-04 23:31             ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51AE41BF.8060206@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.